Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rust client for Trusted Information Retrieval #1110

Merged
merged 8 commits into from
Jun 9, 2020
Merged

Add Rust client for Trusted Information Retrieval #1110

merged 8 commits into from
Jun 9, 2020

Conversation

ipetr0v
Copy link
Contributor

@ipetr0v ipetr0v commented Jun 5, 2020 •
edited
Loading

This change:

  • Adds a Rust client for Trusted Information Retrieval
  • Adds a -c argument for choosing client language in scripts

Fixes #1065

Checklist

  • Pull request affects core Oak functionality (e.g. runtime, SDK, ABI)
    • I have checked that these tests are run by Cloudbuild

@ipetr0v ipetr0v marked this pull request as ready for review June 8, 2020 13:16
@ipetr0v
Add Rust client
c322836 
Use Oak labels
@ipetr0v ipetr0v force-pushed the tir_rust_client branch from 3c216f0 to c322836 Compare June 8, 2020 13:20
daviddrysdale
daviddrysdale reviewed Jun 8, 2020
View reviewed changes
scripts/build_example
- rust (used by default)
- cpp
-c Example client variant:
- rust
- cpp (used by default)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This isn't quite selecting client implementation language; it's more selecting client build system: cargo (always Rust underneath) vs Bazel (usually C++ underneath, but could also be Go).

I don't think it worth changing just for pedantry's sake, but it may be relevant for thinking about how the Node.js client would fit in here (cc @juliettepretot )

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. I was a bit puzzled by this, since the go client is run as a "cpp" client. :)

tiziano88
tiziano88 approved these changes Jun 8, 2020
View reviewed changes
@ipetr0v ipetr0v mentioned this pull request Jun 9, 2020
Closed
@ipetr0v ipetr0v merged commit 19c442b into project-oak:master Jun 9, 2020
@ipetr0v ipetr0v deleted the tir_rust_client branch June 9, 2020 17:08
@github-actions
Copy link

github-actions bot commented Jun 9, 2020

Reproducibility Index:

a0f2fe4c258a93194d10ec7011bee2e11a78a50b25fbec377c230e553c169fa9  ./examples/target/wasm32-unknown-unknown/release/abitest_0_frontend.wasm
4ae04aa804f678fbf3b2cf1a0a89b6c99a238b92be65c0ac3d495327d1528535  ./examples/target/wasm32-unknown-unknown/release/abitest_1_backend.wasm
9b36e5dd48247ab45c55524910cb5372f4f23953c8d7cdea5e5aab60fc4f5d1d  ./examples/target/wasm32-unknown-unknown/release/aggregator.wasm
d6a1b0eda0dcece7dbe8a4cd20e02210f48a81a8c4d0e74d76f33e6bd0149a4a  ./examples/target/wasm32-unknown-unknown/release/chat.wasm
7f984c597596b0b2e9784b9c6138a7421a647914d813edccd5eb18bea0542be0  ./examples/target/wasm32-unknown-unknown/release/hello_world.wasm
b5a880ab6b42ef642ca99aed36985bbcea1907487c882ca6d54d1570d94ff615  ./examples/target/wasm32-unknown-unknown/release/machine_learning.wasm
f8b4bd6f86cb8d4bbd10919b66057388f2d6a32cbd06c1581f716f7bf35877f5  ./examples/target/wasm32-unknown-unknown/release/private_set_intersection.wasm
6bbb55c5423a78ddb4fa3916769cc2b815fc73e1be03436d5a9c50090f3a8c62  ./examples/target/wasm32-unknown-unknown/release/running_average.wasm
54a8fb024f3900baabb992cadf9e0faf7e3106113e5c161bab183dcd02fabee1  ./examples/target/wasm32-unknown-unknown/release/translator.wasm
63008f43c845ce5f8e9d5d3b149bee3b6b118904f16083098c7467b50e971de4  ./examples/target/wasm32-unknown-unknown/release/trusted_information_retrieval.wasm
f22610d3a783bb9c6da95aff5aa83c2336eae522dbd78149414eb99101173578  ./target/x86_64-unknown-linux-musl/release/oak_loader

Reproducibility Index diff:


      		
    

  





        


            

            

              
            

        

      


      

            
  

    
  
    
    

  

  



    












      

  
          

  

    
  


  

      

    @jul-sh
jul-sh



    mentioned this pull request
    
      Jun 11, 2020
    





  


  

      
   Merged

  





  
  

      
        
      
      

  
    
    
  


    6 tasks
  





  









      

  
        

  

      

  jul-sh
  

  
          

            
                  jul-sh
  

            

            reviewed


            
                
                  Jun 12, 2020
                
            
            
          


          



              
    View reviewed changes
  


          






      

  
  
  
            
  
    
    

              

          
                scripts/run_examples

          
        


      
          
  

    
      
    
    

          


              

              

            
                elif [[ "${example}" == 'chat' ]]; then

            
          

          


              

              

            
                    "${SCRIPTS_DIR}/run_example" -s "${server}" -a "${application_language}" -e chat -- --test

            
          

          


              

              

            
                elif [[ "${example}" == 'trusted_information_retrieval' ]]; then

            
          

          


              

              

            
                    "${SCRIPTS_DIR}/run_example" -s "${server}" -a "${application_language}" -c rust -e trusted_information_retrieval -- --latitude 0.0 --longitude 0.0

            
          

    








  

    

        

        

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  


  

    

  




        

      

  

  
 

  
    

    
Choose a reason for hiding this comment


    

      The reason will be displayed to describe this comment to others. Learn more.
    


    

      
      



  



  
    

      
Just looking over this, does this mean we no longer run the cpp client in our CI, and instead run the rust client? :)

    

  
  



    


        

      
  

    
  
    
    

  

  




        

      
    





  

        

  

    

        
    
    

  


      
          
  
      
            Copy link

  

      
    

  


  

      

  
    Contributor


      

  Author


  


  

    

  




        

      

  

  
 

  
    

    
Choose a reason for hiding this comment


    

      The reason will be displayed to describe this comment to others. Learn more.
    


    

      
      



  



  
    

      
Yes, but this is only for TIR example

    

  
  



    


        

      
  

    
  
    
    

  

  




        

      
    








    


  









  








  








      

  
          

  

    
  


  

      

    @daviddrysdale
daviddrysdale



    mentioned this pull request
    
      Jun 18, 2020
    





  


  

      
   Merged

  







  













  
  

    

      

  




    


    

      

              

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  



      

    

  




  
          




      

  

    
    

    
  

    Reviewers
  


    


        

          

  
      @jul-sh
  
    jul-sh



          
            
              
            
          
          jul-sh left review comments

        

        

          

  
      @tiziano88
  
    tiziano88



          
            
              
            
          
          tiziano88 approved these changes

        

        

          

  
      @conradgrobler
  
    conradgrobler



          
            
              
            
          
          conradgrobler approved these changes

        

      

          

  
      @daviddrysdale
  
    daviddrysdale


                Awaiting requested review from daviddrysdale


        
      


      






    

  


      
  

    Assignees
  



        

    No one assigned







      


  


  

    Labels
  



    

      

    cla: yes









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
    

    Development
  



            


Successfully merging this pull request may close these issues.


  
    
            
        Add Rust client for Trusted Information Retrieval example


  


      
    

  




      

    

  
      

  

    

      6 participants
    

    

        
          @ipetr0v 
        
          @tiziano88 
        
          @daviddrysdale 
        
          @jul-sh 
        
          @conradgrobler 
        
          @googlebot