-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Add command for closing an open connection #8430
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
approved these changes
Jul 15, 2021
4339065
to
b84d985
Compare
/rebase |
b84d985
to
55aeb04
Compare
55aeb04
to
d373569
Compare
Currently, the CHIP stack is not able to recover an open CASE session in certain circumstances such as a device reboot. Add a command for closing an open session on the controller side so that the connection can be started from scratch when necessary.
d373569
to
c8faebd
Compare
Size increase report for "esp32-example-build" from 110ef41
Full report output
|
LuDuda
approved these changes
Jul 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Could you update the README.md
with the new command? Alternatively, if it's expensive to maintain, instruct to call the help
command or sth..
msandstedt
approved these changes
Jul 16, 2021
yunhanw-google
approved these changes
Jul 16, 2021
Anyone merge this one? |
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
* [python] Add command for closing an open connection Currently, the CHIP stack is not able to recover an open CASE session in certain circumstances such as a device reboot. Add a command for closing an open session on the controller side so that the connection can be started from scratch when necessary. * Update README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, the CHIP stack is not able to automatically recover an open CASE session in certain circumstances such as a device
reboot.
Change overview
Add a command for closing an open session on the controller side so that the connection can be started from scratch when necessary.
Testing
Tested manually with nRF Connect Lock: