Extract OnOff cluster definition from general.xml and zll.xml #8330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
pan-apple
Damian-Nordic
approved these changes
Jul 13, 2021
msandstedt
approved these changes
Jul 13, 2021
andy31415
approved these changes
Jul 13, 2021
bzbarsky-apple
approved these changes
Jul 13, 2021
|
@vivien-apple The darwin test failure looks real? |
… it into its own file and reformat it to make it easier to read when comparing to the spec
…the Cluster Revision change
…ramework/CHIP/templates
vivien-apple
force-pushed
the
ZAP_UpdateOnOffClusterDefinition
branch
from
9873a57 to
6b109e7
Compare
Correct. There was a missing macro at https://github.com/project-chip/connectedhomeip/blob/master/src/darwin/Framework/CHIP/templates/partials/test_cluster.zapt#L12 I have added it and in the same time I replaced |
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…t-chip#8330) * Extract OnOff cluster definition from general.xml and zll.xml to have it into its own file and reformat it to make it easier to read when comparing to the spec * Update some attributes name into the tests file to match the name update in onoff.xml * Update zap files to takes into account the names changes, as well as the Cluster Revision change * Use as[Upper/Lower]CamelCase instead of asCamelCased for src/darwin/Framework/CHIP/templates * Update gen/ folders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The OnOff cluster definition from Silabs is defined in 2 separated files, and the attributes names formatting is a bit different from the spec at: https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/master/src/app_clusters/OnOff.adoc
Change overview
Silabs/general.xmlandSilabs/zll.xmland move it toChip/onoff-cluster.xml2to3gen/foldersFor reviewers, the last commit is autogenerated code from the changes in the previous commits.
Testing
I have runned
./scripts/tests/suites.shlocally with the changes from this patch. In fact this PR is a step to add an other set of test that uses the ZLL code from https://github.com/project-chip/connectedhomeip/tree/master/src/app/clusters/zll-on-off-server that I still need to port to cpp.