Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Message counter implementation #5390

Closed
wants to merge 4 commits into from
Closed

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Mar 16, 2021

A duplicate of #5389 with additional commits that automatically address
incorrect style, created by Restyled.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

  • whitespace
  • clang-format
  • gn

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

@todo
Copy link

todo bot commented Mar 16, 2021

Re-evaluate the storing of Admin ID in SecureSessionHandle

// TODO: Re-evaluate the storing of Admin ID in SecureSessionHandle
// The Admin ID will not be available for PASE and group sessions. So need
// to identify an approach that'll allow looking up the corresponding information for
// such sessions.
Transport::AdminId mAdmin;
};
} // namespace chip


This comment was generated by todo based on a TODO comment in 83a9ee9 in #5390. cc @project-chip.

@todo
Copy link

todo bot commented Mar 16, 2021

control message counter is not implemented yet

// TODO: control message counter is not implemented yet
}
else
{
// TODO: "initial Session Establishment bootstrap" is under specified, use message counter sync protocol for both group
// and unicast messages
if (!mMessageCounterManager->IsSyncCompleted(state))
{
// Queue and start message sync procedure
err = mMessageCounterManager->QueueReceivedMessageAndStartSync(
{ state->GetPeerNodeId(), state->GetPeerKeyID(), state->GetAdminId() }, state, packetHeader, peerAddress,


This comment was generated by todo based on a TODO comment in 83a9ee9 in #5390. cc @project-chip.

@todo
Copy link

todo bot commented Mar 16, 2021

"initial Session Establishment bootstrap" is under specified, use message counter sync protocol for both group

// TODO: "initial Session Establishment bootstrap" is under specified, use message counter sync protocol for both group
// and unicast messages
if (!mMessageCounterManager->IsSyncCompleted(state))
{
// Queue and start message sync procedure
err = mMessageCounterManager->QueueReceivedMessageAndStartSync(
{ state->GetPeerNodeId(), state->GetPeerKeyID(), state->GetAdminId() }, state, packetHeader, peerAddress,
std::move(msg));
if (err != CHIP_NO_ERROR)
{


This comment was generated by todo based on a TODO comment in 83a9ee9 in #5390. cc @project-chip.

@restyled-io restyled-io bot force-pushed the restyled/pull-5389 branch from 83a9ee9 to d810327 Compare March 16, 2021 05:08
@todo
Copy link

todo bot commented Mar 16, 2021

"initial Session Establishment bootstrap" is under specified, use message counter sync protocol for both group

// TODO: "initial Session Establishment bootstrap" is under specified, use message counter sync protocol for both group
// and unicast messages
if (!mMessageCounterManager->IsSyncCompleted(state))
{
// Queue and start message sync procedure
err = mMessageCounterManager->QueueReceivedMessageAndStartSync(
{ state->GetPeerNodeId(), state->GetPeerKeyID(), state->GetAdminId() }, state, packetHeader, peerAddress,
std::move(msg));
if (err != CHIP_NO_ERROR)
{


This comment was generated by todo based on a TODO comment in d810327 in #5390. cc @project-chip.

@restyled-io restyled-io bot closed this Mar 16, 2021
@restyled-io restyled-io bot deleted the restyled/pull-5389 branch March 16, 2021 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants