Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Darwin] MTRDeviceController_XPC _updateRegistrationInfo double lock fix #37664

Merged
merged 2 commits into from
Feb 19, 2025
Merged

[Darwin] MTRDeviceController_XPC _updateRegistrationInfo double lock fix #37664

merged 2 commits into from
Feb 19, 2025

Conversation

jtung-apple
Copy link
Contributor

Found that the PR #37662 introduced a potential double-lock bug.

Testing

Ran standard unit tests to verify no regressions.

@jtung-apple jtung-apple requested a review from a team as a code owner February 19, 2025 17:07
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2025 •
edited
Loading

PR #37664: Size comparison from 1bd8e40 to 4782a4f

Full report (20 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, tizen)
platform target config section 1bd8e40 4782a4f change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1095108 1095108 0 0.0
RAM 94802 94802 0 0.0
bl702 lighting-app bl702+eth FLASH 651554 651554 0 0.0
RAM 33509 33509 0 0.0
bl702+wifi FLASH 827718 827718 0 0.0
RAM 22233 22233 0 0.0
bl706+mfd+rpc+littlefs FLASH 1060880 1060880 0 0.0
RAM 32157 32157 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 892066 892066 0 0.0
RAM 26896 26896 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 974962 974962 0 0.0
RAM 24644 24644 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 815244 815244 0 0.0
RAM 120256 120256 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 824156 824156 0 0.0
RAM 125352 125352 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771024 771024 0 0.0
RAM 113724 113724 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755300 755300 0 0.0
RAM 113932 113932 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538730 538730 0 0.0
RAM 205112 205112 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572886 572886 0 0.0
RAM 205360 205360 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907328 907328 0 0.0
RAM 142315 142315 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901652 901652 0 0.0
RAM 124663 124663 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 845948 845948 0 0.0
RAM 141243 141243 0 0.0
qpg lighting-app qpg6105+debug FLASH 662132 662132 0 0.0
RAM 105116 105116 0 0.0
lock-app qpg6105+debug FLASH 620240 620240 0 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 459776 459776 0 0.0
RAM 141472 141472 0 0.0
tizen all-clusters-app arm unknown 5076 5076 0 0.0
FLASH 1750404 1750404 0 0.0
RAM 93260 93260 0 0.0
chip-tool-ubsan arm unknown 11476 11476 0 0.0
FLASH 18960254 18960254 0 0.0
RAM 8296776 8296776 0 0.0

@woody-apple woody-apple merged commit 0551d0a into project-chip:master Feb 19, 2025
61 of 67 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2025 •
edited
Loading

PR #37664: Size comparison from 1bd8e40 to 9d59496

Full report (64 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
platform target config section 1bd8e40 9d59496 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1095108 1095108 0 0.0
RAM 94802 94802 0 0.0
bl702 lighting-app bl702+eth FLASH 651554 651554 0 0.0
RAM 33509 33509 0 0.0
bl702+wifi FLASH 827718 827718 0 0.0
RAM 22233 22233 0 0.0
bl706+mfd+rpc+littlefs FLASH 1060880 1060880 0 0.0
RAM 32157 32157 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 892066 892066 0 0.0
RAM 26896 26896 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 974962 974962 0 0.0
RAM 24644 24644 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 815244 815244 0 0.0
RAM 120256 120256 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 824156 824156 0 0.0
RAM 125352 125352 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 771024 771024 0 0.0
RAM 113724 113724 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 755300 755300 0 0.0
RAM 113932 113932 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538730 538730 0 0.0
RAM 205112 205112 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572886 572886 0 0.0
RAM 205360 205360 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 656373 656373 0 0.0
RAM 75324 75324 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 676233 676233 0 0.0
RAM 77964 77964 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 676233 676233 0 0.0
RAM 77964 77964 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 633157 633157 0 0.0
RAM 70392 70392 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616237 616237 0 0.0
RAM 71532 71532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635873 635873 0 0.0
RAM 74076 74076 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635873 635873 0 0.0
RAM 74076 74076 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635733 635733 0 0.0
RAM 74540 74540 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 655449 655449 0 0.0
RAM 77084 77084 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 655449 655449 0 0.0
RAM 77084 77084 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 612081 612081 0 0.0
RAM 68628 68628 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631941 631941 0 0.0
RAM 71268 71268 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631941 631941 0 0.0
RAM 71268 71268 0 0.0
efr32 lock-app BRD4187C FLASH 937712 937712 0 0.0
RAM 159916 159916 0 0.0
BRD4338a FLASH 731712 731712 0 0.0
RAM 234772 234772 0 0.0
window-app BRD4187C FLASH 1030304 1030304 0 0.0
RAM 128020 128020 0 0.0
esp32 all-clusters-app c3devkit DRAM 97312 97312 0 0.0
FLASH 1581862 1581862 0 0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116100 116100 0 0.0
FLASH 1549830 1549830 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4720 4720 0 0.0
FLASH 2649187 2649187 0 0.0
RAM 111088 111088 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 5920532 5920532 0 0.0
RAM 513232 513232 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5265694 5265694 0 0.0
RAM 221112 221112 0 0.0
bridge-app debug unknown 5440 5440 0 0.0
FLASH 4624370 4624370 0 0.0
RAM 199816 199816 0 0.0
chip-tool debug unknown 6096 6096 0 0.0
FLASH 13288447 13288447 0 0.0
RAM 602464 602464 0 0.0
chip-tool-ipv6only arm64 unknown 21944 21944 0 0.0
FLASH 11312736 11312736 0 0.0
RAM 654248 654248 0 0.0
fabric-admin debug unknown 5784 5784 0 0.0
FLASH 11555661 11555661 0 0.0
RAM 602248 602248 0 0.0
fabric-bridge-app debug unknown 4688 4688 0 0.0
FLASH 4449692 4449692 0 0.0
RAM 187016 187016 0 0.0
fabric-sync debug unknown 4944 4944 0 0.0
FLASH 5568261 5568261 0 0.0
RAM 469920 469920 0 0.0
lighting-app debug+rpc+ui unknown 6152 6152 0 0.0
FLASH 5513777 5513777 0 0.0
RAM 203952 203952 0 0.0
lock-app debug unknown 5392 5392 0 0.0
FLASH 4687806 4687806 0 0.0
RAM 191144 191144 0 0.0
ota-provider-app debug unknown 4728 4728 0 0.0
FLASH 4309986 4309986 0 0.0
RAM 179832 179832 0 0.0
ota-requestor-app debug unknown 4680 4680 0 0.0
FLASH 4440144 4440144 0 0.0
RAM 184320 184320 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 2948188 2948188 0 0.0
RAM 143672 143672 0 0.0
thermostat-no-ble arm64 unknown 9448 9448 0 0.0
FLASH 4041576 4041576 0 0.0
RAM 228096 228096 0 0.0
tv-app debug unknown 5720 5720 0 0.0
FLASH 5907173 5907173 0 0.0
RAM 593352 593352 0 0.0
tv-casting-app debug unknown 5296 5296 0 0.0
FLASH 11458893 11458893 0 0.0
RAM 717632 717632 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 907328 907328 0 0.0
RAM 142315 142315 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901652 901652 0 0.0
RAM 124663 124663 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 845948 845948 0 0.0
RAM 141243 141243 0 0.0
nxp contact k32w0+release FLASH 585152 585152 0 0.0
RAM 70876 70876 0 0.0
mcxw71+release FLASH 600632 600632 0 0.0
RAM 63096 63096 0 0.0
light k32w0+release FLASH 611140 611140 0 0.0
RAM 70164 70164 0 0.0
k32w1+release FLASH 685624 685624 0 0.0
RAM 48584 48584 0 0.0
lock mcxw71+release FLASH 749456 749456 0 0.0
RAM 67500 67500 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646092 1646092 0 0.0
RAM 211472 211472 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552860 1552860 0 0.0
RAM 208288 208288 0 0.0
light cy8ckit_062s2_43012 FLASH 1438532 1438532 0 0.0
RAM 197040 197040 0 0.0
lock cy8ckit_062s2_43012 FLASH 1467436 1467436 0 0.0
RAM 224704 224704 0 0.0
qpg lighting-app qpg6105+debug FLASH 662132 662132 0 0.0
RAM 105116 105116 0 0.0
lock-app qpg6105+debug FLASH 620240 620240 0 0.0
RAM 99664 99664 0 0.0
stm32 light STM32WB5MM-DK FLASH 459776 459776 0 0.0
RAM 141472 141472 0 0.0
tizen all-clusters-app arm unknown 5076 5076 0 0.0
FLASH 1750404 1750404 0 0.0
RAM 93260 93260 0 0.0
chip-tool-ubsan arm unknown 11476 11476 0 0.0
FLASH 18960254 18960254 0 0.0
RAM 8296776 8296776 0 0.0

silabs-olivierb pushed a commit to silabs-olivierb/connectedhomeip that referenced this pull request Feb 19, 2025
@jtung-apple @silabs-olivierb
[Darwin] MTRDeviceController_XPC _updateRegistrationInfo double lock …
c6a6537 
…fix (project-chip#37664)

* [Darwin] MTRDeviceController_XPC _updateRegistrationInfo double lock fix

* Make sure device map is accessed safely with lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@anush-apple anush-apple anush-apple approved these changes

Assignees
No one assigned
Labels
darwin review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtung-apple @woody-apple @anush-apple