Back off extra python version of diagnostic test cases #37475
+0
−2,265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
|
PR #37475: Size comparison from 7a2733e to 7c9f9ce Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
approved these changes
Feb 10, 2025
Is there any way to check for duplication in CI? Because it looks like a lot of time has been wasted (creating such python tests). CI feedback that particular test is already there would be nice. |
Unfortunately, no. Initially, we opted for Python tests because Python can simulate FIFO to trigger events for those tests. However, YAML addressed this gap by using Test Event Trigger. Yes, it was a significant waste of time, and I take responsibility for that. The best way to prevent this moving forward is to always check whether an existing test already covers all cases before implementing a new one with a different tool. If the old test is sufficient, we should stop immediately. |
|
I think that part of the problem is the location of YAML and python tests. YAML tests and python tests are located in different places in the source code, where imho they should be placed alongside each other. In that case the technologi used to create the test is less important than the purpose of the test, which is test plan implementation... Also, running python tests and YAML tests, from the user point of view, should be indistinguishable. The top level command should be "run test case XY", without the knowledge of used backend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The YAML version for those cert tests already exists, back off the new added python version
Testing
Validated by CI