Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tizen] Add ifdef for version-dependent Thread API #37430

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

XToripuru
Copy link
Contributor

Problem

thread_get_version exists only for the Thread package version >=0.9.0.

Changes

Add ifdef to inspect the version of said package and return CHIP_ERROR_NOT_IMPLEMENTED when the the version is invalid. Currently TIZEN_NETWORK_THREAD_VERSION is not defined, but new release of Thread package will have it.

Testing

Examples dependent on Thread like lightning-app are building successfully.

@XToripuru XToripuru requested a review from arkq as a code owner February 6, 2025 15:54
Copy link

Review changes with  SemanticDiff

@github-actions github-actions bot added platform tizen For Tizen platform labels Feb 6, 2025
Copy link

github-actions bot commented Feb 6, 2025

PR #37430: Size comparison from d777dce to 53a4e38

Full report (1 build for stm32)
platform target config section d777dce 53a4e38 change % change
stm32 light STM32WB5MM-DK FLASH 482872 482872 0 0.0
RAM 144688 144688 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants