-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for TC_CC_2.1 #37328
Open
jtrejoespinoza-grid
wants to merge
8
commits into
project-chip:master
Choose a base branch
from
jtrejoespinoza-grid:TC-CC-2_1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Proposal for TC_CC_2.1 #37328
jtrejoespinoza-grid
wants to merge
8
commits into
project-chip:master
from
jtrejoespinoza-grid:TC-CC-2_1
+419
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S for users. Attributes template completed.
PR #37328: Size comparison from 3044eeb to 36b94e4 Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
PR #37328: Size comparison from f7226c1 to a835fd4 Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
juandediosg
reviewed
Feb 12, 2025
Changes approved |
juandediosg
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes has been made, PR approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
Removed pics
Verified attributes using
attribute_guard
Proposal for Test case for Color Control 2.2 ( TC_CC_2.1)
The following test evaluates the attributes to the conformance.
How to to run:
Run all clusters.
./out/linux-x64-all-clusters/chip-all-clusters-app
Run the test case:
python3 src/python_testing/TC_CC_2_1.py --commissioning-method on-network --qr-code MT:-24J0AFN00KA0648G00 --PICS src/app/tests/suites/certification/ci-pics-values
All attributes must be present.
There is a conversation right now about the attribute
NumberOfPrimaries
where the value should not be 0. Currently the change is not implemented. Until the change is implemented this test case will need to be updated.https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/9103