Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PW-RPC service to use DataModel::Provider for writes #37160

Merged
merged 9 commits into from
Jan 23, 2025
Merged

Update PW-RPC service to use DataModel::Provider for writes #37160

merged 9 commits into from
Jan 23, 2025

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Jan 22, 2025 •
edited
Loading

Several changes:

  • Fixed crashes if initial listen for RPC never happened
  • Added read support for bytes and strings (string support was not there at all before)
  • Moved write support to use datamodel::Provider

Testing

  • Tested read using On/Off cluster on all-clusters app:
>>> device.rpcs.chip.rpc.Attributes.Read(endpoint=1,cluster=6,attribute_id=0,type=0x10)
(Status.OK, chip.rpc.AttributeData(
    data_bool=False,
    tlv_data=b'\x15\x36\x01\x15\x35\x01\x26\x00\xD3\x61\xA4\x03\x37\x01\x24\x02\x01\x24\x03\x06\x24\x04\x00\x18\x28\x02\x18\x18\x18\x18',
))

>>> device.rpcs.chip.rpc.Attributes.Write(metadata=protos.chip.rpc.AttributeMetadata(endpoint=1,cluster=protos.chip.rpc.ZCL_ON_OFF_CLUSTER_ID,attribute_id=0), data=protos.chip.rpc.AttributeData(data_bool=True))
(Status.OK, pw.protobuf.Empty())

>>> device.rpcs.chip.rpc.Attributes.Read(endpoint=1,cluster=6,attribute_id=0,type=0x10)
(Status.OK, chip.rpc.AttributeData(
    data_bool=True,
    tlv_data=b'\x15\x36\x01\x15\x35\x01\x26\x00\xD4\x61\xA4\x03\x37\x01\x24\x02\x01\x24\x03\x06\x24\x04\x00\x18\x29\x02\x18\x18\x18\x18',
))
  • Tested read of strings using BasicInfo serial number:
>>> device.rpcs.chip.rpc.Attributes.Read(endpoint=0,cluster=40,attribute_id=15,type=0x44)
(Status.OK, chip.rpc.AttributeData(
    data_string='89051',
    tlv_data=b'\x15\x36\x01\x15\x35\x01\x26\x00\x1C\xBE\x8C\xE9\x37\x01\x24\x02\x00\x24\x03\x28\x24\x04\x0F\x18\x2C\x02\x05\x38\x39\x30\x35\x31\x18\x18\x18\x18',
))
  • tested that writing tlv_data for OnOff::onOff with the same data that was received from a Read works.

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

PR #37160: Size comparison from c530e45 to 0b7c13b

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section c530e45 0b7c13b change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1092312 1093696 1384 0.1
RAM 103282 103282 0 0.0
bl702 lighting-app bl702+eth FLASH 650236 650236 0 0.0
RAM 25265 25265 0 0.0
bl702+wifi FLASH 828400 828400 0 0.0
RAM 13981 13981 0 0.0
bl706+mfd+rpc+littlefs FLASH 1055136 1056776 1640 0.2
RAM 23845 23845 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888134 888134 0 0.0
RAM 18504 18504 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 971120 971120 0 0.0
RAM 16368 16368 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838000 838000 0 0.0
RAM 123464 123464 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823412 823412 0 0.0
RAM 125344 125344 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770636 770636 0 0.0
RAM 113804 113804 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754888 754888 0 0.0
RAM 114012 114012 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538433 538433 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572297 572297 0 0.0
RAM 205344 205344 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679401 679401 0 0.0
RAM 78532 78532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699253 699253 0 0.0
RAM 81172 81172 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699253 699253 0 0.0
RAM 81172 81172 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656181 656181 0 0.0
RAM 73600 73600 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615793 615793 0 0.0
RAM 71516 71516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635421 635421 0 0.0
RAM 74060 74060 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635421 635421 0 0.0
RAM 74060 74060 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635265 635265 0 0.0
RAM 74524 74524 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 654973 654973 0 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 654973 654973 0 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611701 611701 0 0.0
RAM 68612 68612 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631561 631561 0 0.0
RAM 71252 71252 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631561 631561 0 0.0
RAM 71252 71252 0 0.0
efr32 lock-app BRD4187C FLASH 934672 936152 1480 0.2
RAM 159904 159904 0 0.0
BRD4338a FLASH 729676 729668 -8 -0.0
RAM 234768 234768 0 0.0
window-app BRD4187C FLASH 1029352 1029344 -8 -0.0
RAM 128040 128040 0 0.0
esp32 all-clusters-app c3devkit DRAM 95104 95104 0 0.0
FLASH 1536860 1536860 0 0.0
IRAM 82552 82552 0 0.0
m5stack DRAM 116092 116092 0 0.0
FLASH 1544946 1544946 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2708845 2708845 0 0.0
RAM 132800 132800 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5974932 5974932 0 0.0
RAM 531616 531616 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5323618 5323618 0 0.0
RAM 242728 242728 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4681806 4681806 0 0.0
RAM 221464 221464 0 0.0
chip-tool debug unknown 5984 5984 0 0.0
FLASH 13046874 13046874 0 0.0
RAM 596178 596178 0 0.0
chip-tool-ipv6only arm64 unknown 21776 21776 0 0.0
FLASH 11124048 11124048 0 0.0
RAM 647920 647920 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11393881 11392987 -894 -0.0
RAM 596522 596522 0 0.0
fabric-bridge-app debug unknown 4728 4728 0 0.0
FLASH 4507202 4506340 -862 -0.0
RAM 208648 208648 0 0.0
fabric-sync debug unknown 4968 4968 0 0.0
FLASH 5612613 5612613 0 0.0
RAM 483520 483520 0 0.0
lighting-app debug+rpc+ui unknown 6136 6136 0 0.0
FLASH 5615921 5623617 7696 0.1
RAM 231744 231744 0 0.0
lock-app debug unknown 5408 5408 0 0.0
FLASH 4730856 4730856 0 0.0
RAM 207712 207712 0 0.0
ota-provider-app debug unknown 4768 4768 0 0.0
FLASH 4359432 4359432 0 0.0
RAM 201352 201352 0 0.0
ota-requestor-app debug unknown 4720 4720 0 0.0
FLASH 4496936 4496936 0 0.0
RAM 205936 205936 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3005021 3005021 0 0.0
RAM 160504 160504 0 0.0
thermostat-no-ble arm64 unknown 9536 9536 0 0.0
FLASH 4098896 4098896 0 0.0
RAM 246136 246136 0 0.0
tv-app debug unknown 5736 5736 0 0.0
FLASH 5952245 5952245 0 0.0
RAM 606920 606920 0 0.0
tv-casting-app debug unknown 5312 5312 0 0.0
FLASH 11272349 11272349 0 0.0
RAM 710864 710864 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913652 913652 0 0.0
RAM 143168 143168 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 888632 888632 0 0.0
RAM 141355 141355 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 848696 848696 0 0.0
RAM 142080 142080 0 0.0
nxp contact k32w0+release FLASH 584288 584288 0 0.0
RAM 70860 70860 0 0.0
mcxw71+release FLASH 599632 599632 0 0.0
RAM 63080 63080 0 0.0
light k32w0+release FLASH 610716 610716 0 0.0
RAM 70252 70252 0 0.0
k32w1+release FLASH 685184 685184 0 0.0
RAM 48664 48664 0 0.0
lock mcxw71+release FLASH 761264 761264 0 0.0
RAM 70708 70708 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646420 1646420 0 0.0
RAM 211560 211560 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553212 1553212 0 0.0
RAM 208376 208376 0 0.0
light cy8ckit_062s2_43012 FLASH 1468876 1468876 0 0.0
RAM 200352 200352 0 0.0
lock cy8ckit_062s2_43012 FLASH 1466908 1466908 0 0.0
RAM 224688 224688 0 0.0
qpg lighting-app qpg6105+debug FLASH 661992 661992 0 0.0
RAM 105204 105204 0 0.0
lock-app qpg6105+debug FLASH 619772 619772 0 0.0
RAM 99648 99648 0 0.0
stm32 light STM32WB5MM-DK FLASH 482608 482608 0 0.0
RAM 144672 144672 0 0.0
telink bridge-app tlsr9258a FLASH 681522 681522 0 0.0
RAM 91084 91084 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621556 621556 0 0.0
RAM 31484 31484 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 770426 770426 0 0.0
RAM 49344 49344 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 774822 774822 0 0.0
RAM 99648 99648 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 708724 708724 0 0.0
RAM 73376 73376 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625832 625832 0 0.0
RAM 142016 142016 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811882 813064 1182 0.1
RAM 99560 99560 0 0.0
tizen all-clusters-app arm unknown 5112 5112 0 0.0
FLASH 1751312 1751312 0 0.0
RAM 93524 93524 0 0.0
chip-tool-ubsan arm unknown 11024 11024 0 0.0
FLASH 18213990 18213990 0 0.0
RAM 7955248 7955248 0 0.0

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

PR #37160: Size comparison from 2d0f857 to 31673ef

Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 2d0f857 31673ef change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1092312 1093880 1568 0.1
RAM 103282 103298 16 0.0
bl702 lighting-app bl702+eth FLASH 650236 650236 0 0.0
RAM 25265 25265 0 0.0
bl702+wifi FLASH 828400 828400 0 0.0
RAM 13981 13981 0 0.0
bl706+mfd+rpc+littlefs FLASH 1055136 1056700 1564 0.1
RAM 23845 23861 16 0.1
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888134 888134 0 0.0
RAM 18504 18504 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 971120 971120 0 0.0
RAM 16368 16368 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838000 838000 0 0.0
RAM 123464 123464 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823412 823412 0 0.0
RAM 125344 125344 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770636 770636 0 0.0
RAM 113804 113804 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754888 754888 0 0.0
RAM 114012 114012 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538433 538433 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572297 572297 0 0.0
RAM 205344 205344 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679401 679401 0 0.0
RAM 78532 78532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699253 699253 0 0.0
RAM 81172 81172 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699253 699253 0 0.0
RAM 81172 81172 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656181 656181 0 0.0
RAM 73600 73600 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615793 615793 0 0.0
RAM 71516 71516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635421 635421 0 0.0
RAM 74060 74060 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635421 635421 0 0.0
RAM 74060 74060 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635265 635265 0 0.0
RAM 74524 74524 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 654973 654973 0 0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 654973 654973 0 0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611701 611701 0 0.0
RAM 68612 68612 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631561 631561 0 0.0
RAM 71252 71252 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631561 631561 0 0.0
RAM 71252 71252 0 0.0
efr32 lock-app BRD4187C FLASH 934672 936264 1592 0.2
RAM 159904 159904 0 0.0
BRD4338a FLASH 729676 729668 -8 -0.0
RAM 234768 234768 0 0.0
window-app BRD4187C FLASH 1029352 1029344 -8 -0.0
RAM 128040 128040 0 0.0
esp32 all-clusters-app c3devkit DRAM 95104 95104 0 0.0
FLASH 1536860 1536860 0 0.0
IRAM 82552 82552 0 0.0
m5stack DRAM 116092 116092 0 0.0
FLASH 1544946 1544946 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2708845 2708845 0 0.0
RAM 132800 132800 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 5974932 5974932 0 0.0
RAM 531616 531616 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5323618 5323618 0 0.0
RAM 242728 242728 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4681806 4681806 0 0.0
RAM 221464 221464 0 0.0
chip-tool debug unknown 5984 5984 0 0.0
FLASH 13046874 13046874 0 0.0
RAM 596178 596178 0 0.0
chip-tool-ipv6only arm64 unknown 21776 21776 0 0.0
FLASH 11124048 11124048 0 0.0
RAM 647920 647920 0 0.0
fabric-admin debug unknown 5808 5808 0 0.0
FLASH 11393881 11392987 -894 -0.0
RAM 596522 596522 0 0.0
fabric-bridge-app debug unknown 4728 4728 0 0.0
FLASH 4507202 4506340 -862 -0.0
RAM 208648 208648 0 0.0
fabric-sync debug unknown 4968 4968 0 0.0
FLASH 5612613 5612613 0 0.0
RAM 483520 483520 0 0.0
lighting-app debug+rpc+ui unknown 6136 6136 0 0.0
FLASH 5615921 5624561 8640 0.2
RAM 231744 231744 0 0.0
lock-app debug unknown 5408 5408 0 0.0
FLASH 4730856 4730856 0 0.0
RAM 207712 207712 0 0.0
ota-provider-app debug unknown 4768 4768 0 0.0
FLASH 4359432 4359432 0 0.0
RAM 201352 201352 0 0.0
ota-requestor-app debug unknown 4720 4720 0 0.0
FLASH 4496936 4496936 0 0.0
RAM 205936 205936 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3005021 3005021 0 0.0
RAM 160504 160504 0 0.0
thermostat-no-ble arm64 unknown 9536 9536 0 0.0
FLASH 4098896 4098896 0 0.0
RAM 246136 246136 0 0.0
tv-app debug unknown 5736 5736 0 0.0
FLASH 5952245 5952245 0 0.0
RAM 606920 606920 0 0.0
tv-casting-app debug unknown 5312 5312 0 0.0
FLASH 11272349 11272349 0 0.0
RAM 710864 710864 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913652 913652 0 0.0
RAM 143168 143168 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 888632 888632 0 0.0
RAM 141355 141355 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 848696 848696 0 0.0
RAM 142080 142080 0 0.0
nxp contact k32w0+release FLASH 584288 584288 0 0.0
RAM 70860 70860 0 0.0
mcxw71+release FLASH 599632 599632 0 0.0
RAM 63080 63080 0 0.0
light k32w0+release FLASH 610716 610716 0 0.0
RAM 70252 70252 0 0.0
k32w1+release FLASH 685184 685184 0 0.0
RAM 48664 48664 0 0.0
lock mcxw71+release FLASH 748648 748648 0 0.0
RAM 67476 67476 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646420 1646420 0 0.0
RAM 211560 211560 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553212 1553212 0 0.0
RAM 208376 208376 0 0.0
light cy8ckit_062s2_43012 FLASH 1468876 1468876 0 0.0
RAM 200352 200352 0 0.0
lock cy8ckit_062s2_43012 FLASH 1466908 1466908 0 0.0
RAM 224688 224688 0 0.0
qpg lighting-app qpg6105+debug FLASH 661992 661992 0 0.0
RAM 105204 105204 0 0.0
lock-app qpg6105+debug FLASH 619772 619772 0 0.0
RAM 99648 99648 0 0.0
stm32 light STM32WB5MM-DK FLASH 482608 482608 0 0.0
RAM 144672 144672 0 0.0
telink bridge-app tlsr9258a FLASH 681522 681522 0 0.0
RAM 91084 91084 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621556 621556 0 0.0
RAM 31484 31484 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 770426 770426 0 0.0
RAM 49344 49344 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 774822 774822 0 0.0
RAM 99648 99648 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 708724 708724 0 0.0
RAM 73376 73376 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625832 625832 0 0.0
RAM 142016 142016 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811882 813224 1342 0.2
RAM 99560 99560 0 0.0
tizen all-clusters-app arm unknown 5112 5112 0 0.0
FLASH 1751312 1751312 0 0.0
RAM 93524 93524 0 0.0
chip-tool-ubsan arm unknown 11024 11024 0 0.0
FLASH 18213990 18213990 0 0.0
RAM 7955248 7955248 0 0.0

@andy31415
Copy link
Contributor Author

fast-tracking test-only code (considering PW-rpc as test-only ... these fixes were made for chef issues to start with).

@mergify mergify bot merged commit 04f1688 into project-chip:master Jan 23, 2025
70 checks passed
@sxb427 sxb427 mentioned this pull request Jan 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

Assignees
No one assigned
Labels
examples fast track linux platform review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy31415 @tcarmelveilleux