Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all NetworkCommissioning cluster attributes in zcl.json and zcl-with-test-extensions.json #37037

Closed
wants to merge 2 commits into from
Closed

Add all NetworkCommissioning cluster attributes in zcl.json and zcl-with-test-extensions.json #37037

wants to merge 2 commits into from

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Jan 10, 2025 •
edited
Loading

Re-creation of #36516 that seems to be in a permanent restyle failure, trying to see if new PR for different user also has this.

Testing

This is a copy of the other PR

@jmartinez-silabs @andy31415
All attributes of the network commissioning cluster are external impl…
2e2282d 
…ementation. List in in the zcl json

Run convert/regen scripts
Don't fallthrough on ScanMaxTimeSeconds or ConnectMaxTimeSeconds reads. a WirelessDriver is needed
@andy31415 andy31415 requested review from a team as code owners January 10, 2025 21:18
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jan 10, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  CODEOWNERS Unsupported file format
  examples/air-purifier-app/air-purifier-common/air-purifier-app.matter Unsupported file format
  examples/air-purifier-app/air-purifier-common/air-purifier-app.zap Unsupported file format
  examples/air-quality-sensor-app/air-quality-sensor-common/air-quality-sensor-app.matter Unsupported file format
  examples/air-quality-sensor-app/air-quality-sensor-common/air-quality-sensor-app.zap Unsupported file format
  examples/all-clusters-app/all-clusters-common/all-clusters-app.matter Unsupported file format
  examples/all-clusters-app/all-clusters-common/all-clusters-app.zap Unsupported file format
  examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.matter Unsupported file format
  examples/all-clusters-minimal-app/all-clusters-common/all-clusters-minimal-app.zap Unsupported file format
  examples/bridge-app/bridge-common/bridge-app.matter Unsupported file format
  examples/bridge-app/bridge-common/bridge-app.zap Unsupported file format
  examples/chef/devices/noip_rootnode_dimmablelight_bCwGYSDpoe.zap Unsupported file format
  examples/chef/devices/rootnode_airpurifier_73a6fe2651.matter Unsupported file format
  examples/chef/devices/rootnode_airpurifier_73a6fe2651.zap Unsupported file format
  examples/chef/devices/rootnode_airpurifier_airqualitysensor_temperaturesensor_humiditysensor_thermostat_56de3d5f45.matter Unsupported file format
  examples/chef/devices/rootnode_airpurifier_airqualitysensor_temperaturesensor_humiditysensor_thermostat_56de3d5f45.zap Unsupported file format
  examples/chef/devices/rootnode_airqualitysensor_e63187f6c9.matter Unsupported file format
  examples/chef/devices/rootnode_airqualitysensor_e63187f6c9.zap Unsupported file format
  examples/chef/devices/rootnode_basicvideoplayer_0ff86e943b.matter Unsupported file format
  examples/chef/devices/rootnode_basicvideoplayer_0ff86e943b.zap Unsupported file format
  examples/chef/devices/rootnode_colortemperaturelight_hbUnzYVeyn.matter Unsupported file format
  examples/chef/devices/rootnode_colortemperaturelight_hbUnzYVeyn.zap Unsupported file format
  examples/chef/devices/rootnode_contactsensor_27f76aeaf5.matter Unsupported file format
  examples/chef/devices/rootnode_contactsensor_27f76aeaf5.zap Unsupported file format
  examples/chef/devices/rootnode_contactsensor_lFAGG1bfRO.matter Unsupported file format
  examples/chef/devices/rootnode_contactsensor_lFAGG1bfRO.zap Unsupported file format
  examples/chef/devices/rootnode_contactsensor_lightsensor_occupancysensor_temperaturesensor_pressuresensor_flowsensor_humiditysensor_airqualitysensor_powersource_367e7cea91.matter Unsupported file format
  examples/chef/devices/rootnode_contactsensor_lightsensor_occupancysensor_temperaturesensor_pressuresensor_flowsensor_humiditysensor_airqualitysensor_powersource_367e7cea91.zap Unsupported file format
  examples/chef/devices/rootnode_dimmablelight_bCwGYSDpoe.matter Unsupported file format
  examples/chef/devices/rootnode_dimmablelight_bCwGYSDpoe.zap Unsupported file format
  examples/chef/devices/rootnode_dimmablepluginunit_f8a9a0b9d4.matter Unsupported file format
  examples/chef/devices/rootnode_dimmablepluginunit_f8a9a0b9d4.zap Unsupported file format
  examples/chef/devices/rootnode_dishwasher_cc105034fe.matter Unsupported file format
  examples/chef/devices/rootnode_dishwasher_cc105034fe.zap Unsupported file format
  examples/chef/devices/rootnode_doorlock_aNKYAreMXE.matter Unsupported file format
  examples/chef/devices/rootnode_doorlock_aNKYAreMXE.zap Unsupported file format
  examples/chef/devices/rootnode_extendedcolorlight_8lcaaYJVAa.matter Unsupported file format
  examples/chef/devices/rootnode_extendedcolorlight_8lcaaYJVAa.zap Unsupported file format
  examples/chef/devices/rootnode_fan_7N2TobIlOX.matter Unsupported file format
  examples/chef/devices/rootnode_fan_7N2TobIlOX.zap Unsupported file format
  examples/chef/devices/rootnode_flowsensor_1zVxHedlaV.matter Unsupported file format
  examples/chef/devices/rootnode_flowsensor_1zVxHedlaV.zap Unsupported file format
  examples/chef/devices/rootnode_genericswitch_2dfff6e516.matter Unsupported file format
  examples/chef/devices/rootnode_genericswitch_2dfff6e516.zap Unsupported file format
  examples/chef/devices/rootnode_genericswitch_9866e35d0b.matter Unsupported file format
  examples/chef/devices/rootnode_genericswitch_9866e35d0b.zap Unsupported file format
  examples/chef/devices/rootnode_heatingcoolingunit_ncdGai1E5a.matter Unsupported file format
  examples/chef/devices/rootnode_heatingcoolingunit_ncdGai1E5a.zap Unsupported file format
  examples/chef/devices/rootnode_humiditysensor_Xyj4gda6Hb.matter Unsupported file format
  examples/chef/devices/rootnode_humiditysensor_Xyj4gda6Hb.zap Unsupported file format
  examples/chef/devices/rootnode_laundrydryer_01796fe396.matter Unsupported file format
  examples/chef/devices/rootnode_laundrydryer_01796fe396.zap Unsupported file format
  examples/chef/devices/rootnode_laundrywasher_fb10d238c8.matter Unsupported file format
  examples/chef/devices/rootnode_laundrywasher_fb10d238c8.zap Unsupported file format
  examples/chef/devices/rootnode_lightsensor_lZQycTFcJK.matter Unsupported file format
  examples/chef/devices/rootnode_lightsensor_lZQycTFcJK.zap Unsupported file format
  examples/chef/devices/rootnode_occupancysensor_iHyVgifZuo.matter Unsupported file format
  examples/chef/devices/rootnode_occupancysensor_iHyVgifZuo.zap Unsupported file format
  examples/chef/devices/rootnode_onofflight_bbs1b7IaOV.matter Unsupported file format
  examples/chef/devices/rootnode_onofflight_bbs1b7IaOV.zap Unsupported file format
  examples/chef/devices/rootnode_onofflight_samplemei.matter Unsupported file format
  examples/chef/devices/rootnode_onofflight_samplemei.zap Unsupported file format
  examples/chef/devices/rootnode_onofflightswitch_FsPlMr090Q.matter Unsupported file format
  examples/chef/devices/rootnode_onofflightswitch_FsPlMr090Q.zap Unsupported file format
  examples/chef/devices/rootnode_onoffpluginunit_Wtf8ss5EBY.matter Unsupported file format
  examples/chef/devices/rootnode_onoffpluginunit_Wtf8ss5EBY.zap Unsupported file format
  examples/chef/devices/rootnode_pressuresensor_s0qC9wLH4k.matter Unsupported file format
  examples/chef/devices/rootnode_pressuresensor_s0qC9wLH4k.zap Unsupported file format
  examples/chef/devices/rootnode_pump_5f904818cc.matter Unsupported file format
  examples/chef/devices/rootnode_pump_5f904818cc.zap Unsupported file format
  examples/chef/devices/rootnode_pump_a811bb33a0.matter Unsupported file format
  examples/chef/devices/rootnode_pump_a811bb33a0.zap Unsupported file format
  examples/chef/devices/rootnode_refrigerator_temperaturecontrolledcabinet_temperaturecontrolledcabinet_ffdb696680.matter Unsupported file format
  examples/chef/devices/rootnode_refrigerator_temperaturecontrolledcabinet_temperaturecontrolledcabinet_ffdb696680.zap Unsupported file format
  examples/chef/devices/rootnode_roboticvacuumcleaner_1807ff0c49.matter Unsupported file format
  examples/chef/devices/rootnode_roboticvacuumcleaner_1807ff0c49.zap Unsupported file format
  examples/chef/devices/rootnode_roomairconditioner_9cf3607804.matter Unsupported file format
  examples/chef/devices/rootnode_roomairconditioner_9cf3607804.zap Unsupported file format
  examples/chef/devices/rootnode_smokecoalarm_686fe0dcb8.matter Unsupported file format
  examples/chef/devices/rootnode_smokecoalarm_686fe0dcb8.zap Unsupported file format
  examples/chef/devices/rootnode_speaker_RpzeXdimqA.matter Unsupported file format
  examples/chef/devices/rootnode_speaker_RpzeXdimqA.zap Unsupported file format
  examples/chef/devices/rootnode_temperaturesensor_Qy1zkNW7c3.matter Unsupported file format
  examples/chef/devices/rootnode_temperaturesensor_Qy1zkNW7c3.zap Unsupported file format
  examples/chef/devices/rootnode_thermostat_bm3fb8dhYi.matter Unsupported file format
  examples/chef/devices/rootnode_thermostat_bm3fb8dhYi.zap Unsupported file format
  examples/chef/devices/rootnode_waterleakdetector_0b067acfa3.matter Unsupported file format
  examples/chef/devices/rootnode_waterleakdetector_0b067acfa3.zap Unsupported file format
  examples/chef/devices/rootnode_watervalve_6bb39f1f67.matter Unsupported file format
  examples/chef/devices/rootnode_watervalve_6bb39f1f67.zap Unsupported file format
  examples/chef/devices/rootnode_windowcovering_RLCxaGi9Yx.matter Unsupported file format
  examples/chef/devices/rootnode_windowcovering_RLCxaGi9Yx.zap Unsupported file format
  examples/chef/devices/template.zap Unsupported file format
  examples/contact-sensor-app/contact-sensor-common/contact-sensor-app.matter Unsupported file format
  examples/contact-sensor-app/contact-sensor-common/contact-sensor-app.zap Unsupported file format
  examples/contact-sensor-app/nxp/zap-lit/contact-sensor-app.matter Unsupported file format
  examples/contact-sensor-app/nxp/zap-lit/contact-sensor-app.zap Unsupported file format
  examples/contact-sensor-app/nxp/zap-sit/contact-sensor-app.matter Unsupported file format
  examples/contact-sensor-app/nxp/zap-sit/contact-sensor-app.zap Unsupported file format
  examples/dishwasher-app/dishwasher-common/dishwasher-app.matter Unsupported file format
  examples/dishwasher-app/dishwasher-common/dishwasher-app.zap Unsupported file format
  examples/dishwasher-app/silabs/data_model/dishwasher-thread-app.matter Unsupported file format
  examples/dishwasher-app/silabs/data_model/dishwasher-thread-app.zap Unsupported file format
  examples/dishwasher-app/silabs/data_model/dishwasher-wifi-app.matter Unsupported file format
  examples/dishwasher-app/silabs/data_model/dishwasher-wifi-app.zap Unsupported file format
  examples/energy-management-app/energy-management-common/energy-management-app.matter Unsupported file format
  examples/energy-management-app/energy-management-common/energy-management-app.zap Unsupported file format
  examples/fabric-bridge-app/fabric-bridge-common/fabric-bridge-app.matter Unsupported file format
  examples/fabric-bridge-app/fabric-bridge-common/fabric-bridge-app.zap Unsupported file format
  examples/fabric-sync/bridge/fabric-bridge.matter Unsupported file format
  examples/fabric-sync/bridge/fabric-bridge.zap Unsupported file format
  examples/laundry-washer-app/nxp/zap/laundry-washer-app.matter Unsupported file format
  examples/laundry-washer-app/nxp/zap/laundry-washer-app.zap Unsupported file format
  examples/light-switch-app/light-switch-common/icd-lit-light-switch-app.matter Unsupported file format
  examples/light-switch-app/light-switch-common/icd-lit-light-switch-app.zap Unsupported file format
  examples/light-switch-app/light-switch-common/light-switch-app.matter Unsupported file format
  examples/light-switch-app/light-switch-common/light-switch-app.zap Unsupported file format
  examples/light-switch-app/qpg/zap/switch.matter Unsupported file format
  examples/light-switch-app/qpg/zap/switch.zap Unsupported file format
  examples/lighting-app-data-mode-no-unique-id/lighting-common/lighting-app.matter Unsupported file format
  examples/lighting-app-data-mode-no-unique-id/lighting-common/lighting-app.zap Unsupported file format
  examples/lighting-app/bouffalolab/data_model/lighting-app-ethernet.matter Unsupported file format
  examples/lighting-app/bouffalolab/data_model/lighting-app-ethernet.zap Unsupported file format
  examples/lighting-app/bouffalolab/data_model/lighting-app-thread.matter Unsupported file format
  examples/lighting-app/bouffalolab/data_model/lighting-app-thread.zap Unsupported file format
  examples/lighting-app/bouffalolab/data_model/lighting-app-wifi.matter Unsupported file format
  examples/lighting-app/bouffalolab/data_model/lighting-app-wifi.zap Unsupported file format
  examples/lighting-app/lighting-common/lighting-app.matter Unsupported file format
  examples/lighting-app/lighting-common/lighting-app.zap Unsupported file format
  examples/lighting-app/nxp/zap/lighting-on-off.matter Unsupported file format
  examples/lighting-app/nxp/zap/lighting-on-off.zap Unsupported file format
  examples/lighting-app/qpg/zap/light.matter Unsupported file format
  examples/lighting-app/qpg/zap/light.zap Unsupported file format
  examples/lighting-app/silabs/data_model/lighting-thread-app.matter Unsupported file format
  examples/lighting-app/silabs/data_model/lighting-thread-app.zap Unsupported file format
  examples/lighting-app/silabs/data_model/lighting-wifi-app.matter Unsupported file format
  examples/lighting-app/silabs/data_model/lighting-wifi-app.zap Unsupported file format
  examples/lit-icd-app/lit-icd-common/lit-icd-server-app.matter Unsupported file format
  examples/lit-icd-app/lit-icd-common/lit-icd-server-app.zap Unsupported file format
  examples/lock-app/lock-common/lock-app.matter Unsupported file format
  examples/lock-app/lock-common/lock-app.zap Unsupported file format
  examples/lock-app/nxp/zap/lock-app.matter Unsupported file format
  examples/lock-app/nxp/zap/lock-app.zap Unsupported file format
  examples/lock-app/qpg/zap/lock.matter Unsupported file format
  examples/lock-app/qpg/zap/lock.zap Unsupported file format
  examples/lock-app/silabs/data_model/lock-app.matter Unsupported file format
  examples/lock-app/silabs/data_model/lock-app.zap Unsupported file format
  examples/log-source-app/log-source-common/log-source-app.matter Unsupported file format
  examples/log-source-app/log-source-common/log-source-app.zap Unsupported file format
  examples/microwave-oven-app/microwave-oven-common/microwave-oven-app.matter Unsupported file format
  examples/microwave-oven-app/microwave-oven-common/microwave-oven-app.zap Unsupported file format
  examples/network-manager-app/network-manager-common/network-manager-app.matter Unsupported file format
  examples/network-manager-app/network-manager-common/network-manager-app.zap Unsupported file format
  examples/ota-provider-app/ota-provider-common/ota-provider-app.matter Unsupported file format
  examples/ota-provider-app/ota-provider-common/ota-provider-app.zap Unsupported file format
  examples/ota-requestor-app/ota-requestor-common/ota-requestor-app.matter Unsupported file format
  examples/ota-requestor-app/ota-requestor-common/ota-requestor-app.zap Unsupported file format
  examples/placeholder/linux/apps/app1/config.matter Unsupported file format
  examples/placeholder/linux/apps/app1/config.zap Unsupported file format
  examples/placeholder/linux/apps/app2/config.matter Unsupported file format
  examples/placeholder/linux/apps/app2/config.zap Unsupported file format
  examples/pump-app/pump-common/pump-app.matter Unsupported file format
  examples/pump-app/pump-common/pump-app.zap Unsupported file format
  examples/pump-app/silabs/data_model/pump-thread-app.matter Unsupported file format
  examples/pump-app/silabs/data_model/pump-thread-app.zap Unsupported file format
  examples/pump-app/silabs/data_model/pump-wifi-app.matter Unsupported file format
  examples/pump-app/silabs/data_model/pump-wifi-app.zap Unsupported file format
  examples/pump-controller-app/pump-controller-common/pump-controller-app.matter Unsupported file format
  examples/pump-controller-app/pump-controller-common/pump-controller-app.zap Unsupported file format
  examples/refrigerator-app/refrigerator-common/refrigerator-app.matter Unsupported file format
  examples/refrigerator-app/refrigerator-common/refrigerator-app.zap Unsupported file format
  examples/refrigerator-app/silabs/data_model/refrigerator-thread-app.matter Unsupported file format
  examples/refrigerator-app/silabs/data_model/refrigerator-thread-app.zap Unsupported file format
  examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.matter Unsupported file format
  examples/refrigerator-app/silabs/data_model/refrigerator-wifi-app.zap Unsupported file format
  examples/rvc-app/rvc-common/rvc-app.matter Unsupported file format
  examples/rvc-app/rvc-common/rvc-app.zap Unsupported file format
  examples/smoke-co-alarm-app/smoke-co-alarm-common/smoke-co-alarm-app.matter Unsupported file format
  examples/smoke-co-alarm-app/smoke-co-alarm-common/smoke-co-alarm-app.zap Unsupported file format
  examples/temperature-measurement-app/temperature-measurement-common/temperature-measurement.matter Unsupported file format
  examples/temperature-measurement-app/temperature-measurement-common/temperature-measurement.zap Unsupported file format
  examples/thermostat/nxp/zap/thermostat_matter_br.matter Unsupported file format
  examples/thermostat/nxp/zap/thermostat_matter_br.zap Unsupported file format
  examples/thermostat/nxp/zap/thermostat_matter_thread.matter Unsupported file format
  examples/thermostat/nxp/zap/thermostat_matter_thread.zap Unsupported file format
  examples/thermostat/nxp/zap/thermostat_matter_wifi.matter Unsupported file format
  examples/thermostat/nxp/zap/thermostat_matter_wifi.zap Unsupported file format
  examples/thermostat/qpg/zap/thermostaticRadiatorValve.matter Unsupported file format
  examples/thermostat/qpg/zap/thermostaticRadiatorValve.zap Unsupported file format
  examples/thermostat/thermostat-common/thermostat.matter Unsupported file format
  examples/thermostat/thermostat-common/thermostat.zap Unsupported file format
  examples/thread-br-app/thread-br-common/thread-br-app.matter Unsupported file format
  examples/thread-br-app/thread-br-common/thread-br-app.zap Unsupported file format
  examples/tv-app/tv-common/tv-app.matter Unsupported file format
  examples/tv-app/tv-common/tv-app.zap Unsupported file format
  examples/tv-casting-app/tv-casting-common/tv-casting-app.matter Unsupported file format
  examples/tv-casting-app/tv-casting-common/tv-casting-app.zap Unsupported file format
  examples/virtual-device-app/virtual-device-common/virtual-device-app.matter Unsupported file format
  examples/virtual-device-app/virtual-device-common/virtual-device-app.zap Unsupported file format
  examples/water-leak-detector-app/water-leak-detector-common/water-leak-detector-app.matter Unsupported file format
  examples/water-leak-detector-app/water-leak-detector-common/water-leak-detector-app.zap Unsupported file format
  examples/window-app/common/window-app.matter Unsupported file format
  examples/window-app/common/window-app.zap Unsupported file format
  scripts/tools/zap/tests/inputs/all-clusters-app.zap Unsupported file format
  scripts/tools/zap/tests/inputs/lighting-app.zap Unsupported file format
  scripts/tools/zap/tests/outputs/all-clusters-app/app-templates/endpoint_config.h Unsupported file format
  scripts/tools/zap/tests/outputs/lighting-app/app-templates/endpoint_config.h Unsupported file format
  src/app/clusters/network-commissioning/network-commissioning.cpp Unsupported file format
  src/app/zap-templates/zcl/zcl-with-test-extensions.json  0% smaller
  src/app/zap-templates/zcl/zcl.json  0% smaller
  src/controller/data_model/controller-clusters.zap Unsupported file format
  zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.cpp Unsupported file format
  zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.h Unsupported file format

@andy31415
Copy link
Contributor Author

Closing: this still gets the perma-failure in restyleio. Will have to figure out how to handle these cases...

@andy31415 andy31415 closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
app controller examples review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy31415 @jmartinez-silabs