Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Silabs] Clean up WifiInterface public APIs #37035

Merged
merged 10 commits into from
Jan 15, 2025
Merged

[Silabs] Clean up WifiInterface public APIs #37035

merged 10 commits into from
Jan 15, 2025

Conversation

mkardous-silabs
Copy link
Contributor

Description

PR continues the Wifi interface refactor that has been on going for several PRs. The goal of the PR is to continue to clean up public APIs and not focused on refactoring the different implementations.

  • Clean up WifiInterface APIs
  • Transition wf200 bit operation to use the WifiState enum with the Bitflags class
  • Improve build directory in the build script
out
└── lighting-app
    ├── thread
    │   └── BRD4186C
    │   └── BRD4187C       
    └── wifi
        ├── BRD2605A
        ├── BRD4187C
        │   ├── SiWx917
        │   └── wf200
        └── BRD4338A

Testing

Validation of the changes are done manually.

  • Build and commission BRD4338A (Wifi SoC)
  • Build and commission BRD4187C + WF200 (Wifi RCP combo)

@mkardous-silabs mkardous-silabs requested a review from a team as a code owner January 10, 2025 20:35
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

PR #37035: Size comparison from 87f7c4c to ed76fa5

Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 87f7c4c ed76fa5 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1355062 1355062 0 0.0
RAM 104152 104152 0 0.0
bl702 lighting-app bl702+eth FLASH 726456 726456 0 0.0
RAM 25361 25361 0 0.0
bl702+wifi FLASH 913070 913070 0 0.0
RAM 14101 14101 0 0.0
bl706+mfd+rpc+littlefs FLASH 1173904 1173904 0 0.0
RAM 23941 23941 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 1082972 1082972 0 0.0
RAM 16612 16612 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 840328 840328 0 0.0
RAM 123712 123712 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825868 825868 0 0.0
RAM 125600 125600 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 772756 772756 0 0.0
RAM 114076 114076 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 756944 756944 0 0.0
RAM 114276 114276 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540181 540181 0 0.0
RAM 205816 205816 0 0.0
lock CC3235SF_LAUNCHXL FLASH 574349 574349 0 0.0
RAM 205960 205960 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 681721 681721 0 0.0
RAM 78756 78756 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 701565 701565 0 0.0
RAM 81396 81396 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 701565 701565 0 0.0
RAM 81396 81396 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 658501 658501 0 0.0
RAM 73824 73824 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618337 618337 0 0.0
RAM 71748 71748 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 637965 637965 0 0.0
RAM 74292 74292 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 637965 637965 0 0.0
RAM 74292 74292 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 637737 637737 0 0.0
RAM 74756 74756 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 657445 657445 0 0.0
RAM 77300 77300 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 657445 657445 0 0.0
RAM 77300 77300 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614357 614357 0 0.0
RAM 68844 68844 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634209 634209 0 0.0
RAM 71476 71476 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634209 634209 0 0.0
RAM 71476 71476 0 0.0
efr32 lock-app BRD4187C FLASH 932660 932660 0 0.0
RAM 160228 160228 0 0.0
BRD4338a FLASH 747184 747160 -24 -0.0
RAM 233356 233356 0 0.0
window-app BRD4187C FLASH 1025616 1025608 -8 -0.0
RAM 128332 128332 0 0.0
esp32 all-clusters-app c3devkit DRAM 95352 95352 0 0.0
FLASH 1541932 1541932 0 0.0
IRAM 82552 82552 0 0.0
m5stack DRAM 116332 116332 0 0.0
FLASH 1548274 1548274 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2732057 2732057 0 0.0
RAM 133160 133160 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 6021926 6021926 0 0.0
RAM 526072 526072 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5356774 5356774 0 0.0
RAM 243072 243072 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4705190 4705190 0 0.0
RAM 221824 221824 0 0.0
chip-tool debug unknown 5992 5992 0 0.0
FLASH 12938958 12938958 0 0.0
RAM 587002 587002 0 0.0
chip-tool-ipv6only arm64 unknown 21560 21560 0 0.0
FLASH 11054048 11054048 0 0.0
RAM 638064 638064 0 0.0
fabric-admin debug unknown 5816 5816 0 0.0
FLASH 11335083 11335083 0 0.0
RAM 587346 587346 0 0.0
fabric-bridge-app debug unknown 4728 4728 0 0.0
FLASH 4530342 4530342 0 0.0
RAM 208928 208928 0 0.0
fabric-sync debug unknown 4968 4968 0 0.0
FLASH 5641733 5641733 0 0.0
RAM 477880 477880 0 0.0
lighting-app debug+rpc+ui unknown 6136 6136 0 0.0
FLASH 5641329 5641329 0 0.0
RAM 232072 232072 0 0.0
lock-app debug unknown 5408 5408 0 0.0
FLASH 4753590 4753590 0 0.0
RAM 208072 208072 0 0.0
ota-provider-app debug unknown 4768 4768 0 0.0
FLASH 4380104 4380104 0 0.0
RAM 201744 201744 0 0.0
ota-requestor-app debug unknown 4720 4720 0 0.0
FLASH 4519012 4519012 0 0.0
RAM 206312 206312 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3038253 3038253 0 0.0
RAM 160792 160792 0 0.0
thermostat-no-ble arm64 unknown 9584 9584 0 0.0
FLASH 4120344 4120344 0 0.0
RAM 246384 246384 0 0.0
tv-app debug unknown 5736 5736 0 0.0
FLASH 5991045 5991045 0 0.0
RAM 601312 601312 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11167741 11167741 0 0.0
RAM 700496 700496 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 918092 918092 0 0.0
RAM 143332 143332 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 890648 890648 0 0.0
RAM 141519 141519 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 852160 852160 0 0.0
RAM 142244 142244 0 0.0
nxp contact k32w0+release FLASH 586128 586128 0 0.0
RAM 71112 71112 0 0.0
mcxw71+release FLASH 601640 601640 0 0.0
RAM 63328 63328 0 0.0
light k32w0+release FLASH 612732 612732 0 0.0
RAM 70504 70504 0 0.0
k32w1+release FLASH 687304 687304 0 0.0
RAM 48920 48920 0 0.0
lock mcxw71+release FLASH 763608 763608 0 0.0
RAM 70956 70956 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1647644 1647644 0 0.0
RAM 212144 212144 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1555276 1555276 0 0.0
RAM 208960 208960 0 0.0
light cy8ckit_062s2_43012 FLASH 1470380 1470380 0 0.0
RAM 200928 200928 0 0.0
lock cy8ckit_062s2_43012 FLASH 1468116 1468116 0 0.0
RAM 225280 225280 0 0.0
qpg lighting-app qpg6105+debug FLASH 664336 664336 0 0.0
RAM 105456 105456 0 0.0
lock-app qpg6105+debug FLASH 622140 622140 0 0.0
RAM 99908 99908 0 0.0
stm32 light STM32WB5MM-DK FLASH 485072 485072 0 0.0
RAM 144912 144912 0 0.0
telink bridge-app tlsr9258a FLASH 683684 683684 0 0.0
RAM 91248 91248 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 623926 623926 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 772758 772758 0 0.0
RAM 49348 49348 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 777374 777374 0 0.0
RAM 99812 99812 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 711368 711368 0 0.0
RAM 73544 73544 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 628370 628370 0 0.0
RAM 142180 142180 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 814384 814384 0 0.0
RAM 99724 99724 0 0.0
tizen all-clusters-app arm unknown 5160 5160 0 0.0
FLASH 1781736 1781736 0 0.0
RAM 93720 93720 0 0.0
chip-tool-ubsan arm unknown 10924 10924 0 0.0
FLASH 18121318 18121318 0 0.0
RAM 7909272 7909272 0 0.0

@github-actions GitHub Actions
Copy link

PR #37035: Size comparison from 87f7c4c to 88be355

Full report (3 builds for cc32xx, stm32)
platform target config section 87f7c4c 88be355 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540181 540041 -140 -0.0
RAM 205816 205304 -512 -0.2
lock CC3235SF_LAUNCHXL FLASH 574349 574209 -140 -0.0
RAM 205960 205448 -512 -0.2
stm32 light STM32WB5MM-DK FLASH 485072 484976 -96 -0.0
RAM 144912 144752 -160 -0.1

@yufengwangca yufengwangca merged commit 26a867c into project-chip:master Jan 15, 2025
69 checks passed
@mkardous-silabs mkardous-silabs deleted the feature/refactor_task_start branch January 15, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

Assignees
No one assigned
Labels
platform review - approved scripts silabs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkardous-silabs @yufengwangca @jmartinez-silabs @restyled-commits