Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return empty thread route table when thread network is not up #37032

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Return empty thread route table when thread network is not up #37032

merged 1 commit into from
Jan 13, 2025

Conversation

Martin-NXP
Copy link
Contributor

Fixes #36926
Command "./chip-tool threadnetworkdiagnostics read route-table" return an error if the thread network is not up (OTBR NXP thermostat app). Issue identify by the test lab during matter 1.4 certification.
Proposal: return empty route table instead of an error when there is no route.

Testing

Tested with the NXP thermostat OTBR example, with RW612 platform.
The chip-tool command is not failing any more with this fix and print 0 entrance for the route table when the thread network is not up.

@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@github-actions github-actions bot added the app label Jan 10, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 10, 2025 •
edited
Loading

PR #37032: Size comparison from e3bb3e3 to db43f5e

Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section e3bb3e3 db43f5e change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1354946 1354946 0 0.0
RAM 104152 104152 0 0.0
bl702 lighting-app bl702+eth FLASH 726512 726512 0 0.0
RAM 25361 25361 0 0.0
bl702+wifi FLASH 913126 913126 0 0.0
RAM 14101 14101 0 0.0
bl706+mfd+rpc+littlefs FLASH 1173960 1173960 0 0.0
RAM 23941 23941 0 0.0
bl702l lighting-app bl702l+mfd+littlefs FLASH 1083028 1083028 0 0.0
RAM 16612 16612 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 840400 840368 -32 -0.0
RAM 123712 123712 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 825932 825884 -48 -0.0
RAM 125600 125600 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 772836 772836 0 0.0
RAM 114076 114076 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 757016 757016 0 0.0
RAM 114276 114276 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 540285 540285 0 0.0
RAM 205816 205816 0 0.0
lock CC3235SF_LAUNCHXL FLASH 574453 574453 0 0.0
RAM 205960 205960 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 681809 681769 -40 -0.0
RAM 78756 78756 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 701653 701621 -32 -0.0
RAM 81396 81396 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 701653 701621 -32 -0.0
RAM 81396 81396 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 658589 658549 -40 -0.0
RAM 73824 73824 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 618425 618425 0 0.0
RAM 71748 71748 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 638053 638053 0 0.0
RAM 74292 74292 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 638053 638053 0 0.0
RAM 74292 74292 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 637825 637825 0 0.0
RAM 74756 74756 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 657533 657533 0 0.0
RAM 77300 77300 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 657533 657533 0 0.0
RAM 77300 77300 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614445 614445 0 0.0
RAM 68844 68844 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634297 634297 0 0.0
RAM 71476 71476 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634297 634297 0 0.0
RAM 71476 71476 0 0.0
efr32 lock-app BRD4187C FLASH 932740 932676 -64 -0.0
RAM 160228 160228 0 0.0
BRD4338a FLASH 747208 747200 -8 -0.0
RAM 233356 233356 0 0.0
window-app BRD4187C FLASH 1025656 1025624 -32 -0.0
RAM 128332 128332 0 0.0
esp32 all-clusters-app c3devkit DRAM 95352 95352 0 0.0
FLASH 1541996 1541996 0 0.0
IRAM 82552 82552 0 0.0
m5stack DRAM 116332 116332 0 0.0
FLASH 1548246 1548246 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4752 4752 0 0.0
FLASH 2731685 2731685 0 0.0
RAM 133160 133160 0 0.0
all-clusters-app debug unknown 5560 5560 0 0.0
FLASH 6020306 6020306 0 0.0
RAM 526008 526008 0 0.0
all-clusters-minimal-app debug unknown 5456 5456 0 0.0
FLASH 5356400 5356400 0 0.0
RAM 243072 243072 0 0.0
bridge-app debug unknown 5472 5472 0 0.0
FLASH 4704816 4704816 0 0.0
RAM 221824 221824 0 0.0
chip-tool debug unknown 5992 5992 0 0.0
FLASH 12938676 12938676 0 0.0
RAM 587002 587002 0 0.0
chip-tool-ipv6only arm64 unknown 21560 21560 0 0.0
FLASH 11053856 11053856 0 0.0
RAM 638064 638064 0 0.0
fabric-admin debug unknown 5816 5816 0 0.0
FLASH 11334801 11334801 0 0.0
RAM 587346 587346 0 0.0
fabric-bridge-app debug unknown 4728 4728 0 0.0
FLASH 4529968 4529968 0 0.0
RAM 208928 208928 0 0.0
fabric-sync debug unknown 4968 4968 0 0.0
FLASH 5641333 5641333 0 0.0
RAM 477880 477880 0 0.0
lighting-app debug+rpc+ui unknown 6136 6136 0 0.0
FLASH 5640945 5640945 0 0.0
RAM 232072 232072 0 0.0
lock-app debug unknown 5408 5408 0 0.0
FLASH 4753184 4753184 0 0.0
RAM 208072 208072 0 0.0
ota-provider-app debug unknown 4768 4768 0 0.0
FLASH 4379730 4379730 0 0.0
RAM 201744 201744 0 0.0
ota-requestor-app debug unknown 4720 4720 0 0.0
FLASH 4518638 4518638 0 0.0
RAM 206312 206312 0 0.0
shell debug unknown 4248 4248 0 0.0
FLASH 3037885 3037885 0 0.0
RAM 160792 160792 0 0.0
thermostat-no-ble arm64 unknown 9584 9584 0 0.0
FLASH 4120104 4120104 0 0.0
RAM 246384 246384 0 0.0
tv-app debug unknown 5736 5736 0 0.0
FLASH 5990677 5990677 0 0.0
RAM 601312 601312 0 0.0
tv-casting-app debug unknown 5320 5320 0 0.0
FLASH 11167325 11167325 0 0.0
RAM 700496 700496 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 918156 918156 0 0.0
RAM 143332 143332 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 890664 890664 0 0.0
RAM 141519 141519 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 852220 852220 0 0.0
RAM 142244 142244 0 0.0
nxp contact k32w0+release FLASH 586112 586112 0 0.0
RAM 71112 71112 0 0.0
mcxw71+release FLASH 601624 601624 0 0.0
RAM 63328 63328 0 0.0
light k32w0+release FLASH 612748 612748 0 0.0
RAM 70504 70504 0 0.0
k32w1+release FLASH 687384 687336 -48 -0.0
RAM 48920 48920 0 0.0
lock mcxw71+release FLASH 763704 763704 0 0.0
RAM 70956 70956 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1647684 1647684 0 0.0
RAM 212144 212144 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1555316 1555316 0 0.0
RAM 208960 208960 0 0.0
light cy8ckit_062s2_43012 FLASH 1470420 1470420 0 0.0
RAM 200928 200928 0 0.0
lock cy8ckit_062s2_43012 FLASH 1468156 1468156 0 0.0
RAM 225280 225280 0 0.0
qpg lighting-app qpg6105+debug FLASH 664392 664344 -48 -0.0
RAM 105456 105456 0 0.0
lock-app qpg6105+debug FLASH 622204 622204 0 0.0
RAM 99908 99908 0 0.0
stm32 light STM32WB5MM-DK FLASH 485136 485136 0 0.0
RAM 144912 144912 0 0.0
telink bridge-app tlsr9258a FLASH 683698 683686 -12 -0.0
RAM 91248 91248 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 623938 623938 0 0.0
RAM 31488 31488 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 772772 772760 -12 -0.0
RAM 49348 49348 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 777388 777376 -12 -0.0
RAM 99812 99812 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 711380 711380 0 0.0
RAM 73544 73544 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 628384 628384 0 0.0
RAM 142180 142180 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 814398 814386 -12 -0.0
RAM 99724 99724 0 0.0
tizen all-clusters-app arm unknown 5160 5160 0 0.0
FLASH 1781748 1781748 0 0.0
RAM 93720 93720 0 0.0
chip-tool-ubsan arm unknown 10924 10924 0 0.0
FLASH 18121646 18121646 0 0.0
RAM 7909212 7909212 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, but is there a spec issue tracking this?

@Martin-NXP
Copy link
Contributor Author

Seems OK, but is there a spec issue tracking this?

I created a dedicated issue: 10746

@mergify mergify bot merged commit 7558fe1 into project-chip:master Jan 13, 2025
69 checks passed
@bzbarsky-apple
Copy link
Contributor

I created a dedicated issue: https://github.com/CHIP-Specifications/connectedhomeip-spec/issues/10746

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

Assignees
No one assigned
Labels
app review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TC-ACE-2.1][TC-IDM-2.2] Issue when reading ThreadNetworkDiagnostics.Attributes.RouteTable on endpoint 2
4 participants
@Martin-NXP @bzbarsky-apple @andy31415 @jmartinez-silabs