[CASESession] Factoring Out Sigma2 and Sigma3 Parsing Functions for Improved Testability #36941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sionParameters as an outparam and does not touch PairingSession class member mRemoteSessionParameters - a utility SetRemoteSessionParameters to be able to set PairingSession class member mRemoteSessionParameters
|
Review changes with |
Alami-Amine
force-pushed
the
AA/CASERefactorSigma2
branch
from
9351204 to
403d4ee
Compare
|
PR #36941: Size comparison from 2249628 to 403d4ee Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36941: Size comparison from 2249628 to ea053d8 Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Alami-Amine
force-pushed
the
AA/CASERefactorSigma2
branch
from
ea053d8 to
cc77e8c
Compare
|
PR #36941: Size comparison from 2249628 to cc77e8c Increases above 0.2%:
Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Alami-Amine
force-pushed
the
AA/CASERefactorSigma2
branch
from
df9a3e8 to
5c9281b
Compare
Alami-Amine
force-pushed
the
AA/CASERefactorSigma2
branch
from
0fe56e3 to
1a6f27b
Compare
|
PR #36941: Size comparison from d5e9829 to 1a6f27b Full report (70 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Alami-Amine
force-pushed
the
AA/CASERefactorSigma2
branch
from
1a6f27b to
c4dfb95
Compare
github-actions
bot
added
documentation
Alami-Amine
force-pushed
the
AA/CASERefactorSigma2
branch
2 times, most recently
from
4c0fd48 to
a68f2c0
Compare
|
PR #36941: Size comparison from 8a0fc4d to a68f2c0 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Alami-Amine
force-pushed
the
AA/CASERefactorSigma2
branch
from
a68f2c0 to
386d4b9
Compare
Alami-Amine
force-pushed
the
AA/CASERefactorSigma2
branch
from
386d4b9 to
f7b8166
Compare
|
PR #36941: Size comparison from 958c1cb to f7b8166 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
approved these changes
Jan 20, 2025
|
PR #36941: Size comparison from 17ad72e to 1f9cd96 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #36941: Size comparison from 17ad72e to 291a38f Increases above 0.2%:
Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Jan 31, 2025
adigie
pushed a commit
to adigie/connectedhomeip
that referenced
this pull request
Feb 4, 2025
…mproved Testability (project-chip#36941) * - Creating an overload of DecodeMRPParametersIfPresent that takes SessionParameters as an outparam and does not touch PairingSession class member mRemoteSessionParameters - a utility SetRemoteSessionParameters to be able to set PairingSession class member mRemoteSessionParameters * Making ParseSigma1 static and not dependent on class state * factoring out ParseSigma2 * factor out Parser for decrypted Sigma2 * various cleanup * factor out ParseSigma2Resume * Adding Unit Tests * More Various Cleanup * Factor out ParseSigma3 and ParseSigma3TBEData * Unit Tests for ParseSigma3 and ParseSigma3TBEData * Code Cleanup * Integrating Comments and Adding comments * Increase Coverage of TestSigma1Parsing * Integrating Comments * Integrating comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This PR continues the CASESession refactoring efforts to improve testability and robustness, building on:
Key Changes:
1. Refactoring:
2. Hardening and Fixes:
TBSData2SignatureandTBSData3Signature.EndOfContainerTLV elements by ensuringExitContaineris called after TLV-Reading containers TLV Reading of Containers often missed a call to ExitContainer #36959.Testing