Initial implemention of a push av server #36004
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with Changed Files
|
|
|
github-actions
bot
added
tools
tests
matter-1.4-te2-script-change
|
PR #36004: Size comparison from a7bbd7b to 2bc6170 Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
gmarcosb
added
cameras
and removed
matter-1.4-te2-script-change
samadDotDev
reviewed
Oct 11, 2024
samadDotDev
reviewed
Oct 11, 2024
github-actions
bot
added
the
matter-1.4-te2-script-change
|
The test plan integration example is currently not up to date, but the CLI example should run just fine nonetheless. |
|
The test example should be relatively correct, although it doesn't run locally for me due to the I have added the ability to run multiple servers concurrently (and accessing their CA hierarchies, example in the test file). I have also added an example on how to sign a certificate using the HTTP API. |
andy31415
reviewed
Jan 28, 2025
src/python_testing/push_av_server.py
Outdated
There was a problem hiding this comment.
I am unsure if we should allow symlinks here as we have python_testing scripts generally be copied over.
There was a problem hiding this comment.
Oooh, that's very good to know. The idea was to have the server be able to run standalone but that is still doable if its code live in src/python_testing/push_av_server instead of src/tools/push_av_server.
andy31415
reviewed
Jan 28, 2025
|
PR #36004: Size comparison from e80451c to 819e9d4 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
The test failure is due to the push av server not being marked as not a test. Once we have resolved the question of where the tool should live, I'll update the exclusion rules as required. |
|
PR #36004: Size comparison from ecdf4eb to 490e54e Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push AV Server implementation for cameras. This PR is currently a draft to gather early feedback from the camera tiger team. It is not intended to be merged as part of the Matter 1.4 release.
This PR introduce a new tool (
src/tools/push_av_server/server.py) that offer a web server to test the PUSH AV Transport cluster. The tool also manage TLS certificates for both the server itself as well as the cameras uploading to it. The server can be interacted with via HTTP calls when used as a standalone tool (work on a UI is in progress) or via python functions when used as a module (mostly targeting the test harness).Note that test harness integration is mostly a work in progress at this point. The added test file in this PR is only intended as a guide (as well as to provide information onto how the tool can be used in that context) to help develop correct APIs and is not intended to be merged as part of this PR.
The web server provide few checks in term of validation for the ingested media. The idea is to have a server permissive enough that record as much information as possible, and then rely on the actual test to validate that the camera is working as it should.
Testing
This PR introduce a tool that will be used as part of the camera test harness. Until those tests have been written, the tool can be tested by following the example's instruction in the tool's
READMEfile.