Sync up MTRDeviceController and MTRDeviceController_Concrete and actually start using the latter. #35453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
carol-apple,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve,
harimau-qirex,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kiel-apple,
kkasperczyk-no and
kpschoedel
pullapprove
bot
requested review from
plauric,
rcasallas-silabs,
ReneJosefsen,
robszewczyk,
saurabhst,
selissia,
sharadb-amazon,
tcarmelveilleux,
tecimovic,
tehampson,
tima-q,
tobiasgraf,
turon,
vivien-apple,
wiba-nordic,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #35453: Size comparison from e96ddd9 to aa94c75 Full report (12 builds for nrfconnect, nxp, qpg, stm32, tizen)
|
woody-apple
approved these changes
Sep 6, 2024
…ally start using the latter. Specific changes: * Fix includes in MTRDeviceController_Concrete, since it uses std::optional and os_unfair_lock, and includes MTRDeviceController.h via MTRDeviceController_Concrete.h already (and has to, because of the inheritance). * Copy the assertion counter machinery into MTRDeviceController_Concrete for now. This includes the storage of the variables that machinery relies on. * Remove incorrect deviceMapLock @synthesize: this is just implemented by the superclass, no need to do anything with it in the subclass. * Switch the places that are starting a non-XPC controller to create instances of MTRDeviceController_Concrete, not MTRDeviceController.
bzbarsky-apple
force-pushed
the
enable-concrete-controller
branch
from
aa94c75 to
18466d0
Compare
|
PR #35453: Size comparison from 96e687b to 18466d0 Full report (63 builds for bl602, bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
Fast-tracking platform-specific fix with platform owner review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific changes:
@synthesize: this is just implemented by the superclass, no need to do anything with it in the subclass.