Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the dependency error and some changed requested by reviewer #34764

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Fix the dependency error and some changed requested by reviewer #34764

wants to merge 33 commits into from
+4,217 −359

Conversation

crlonxp
Copy link
Contributor

@crlonxp crlonxp commented Aug 3, 2024 •
edited
Loading

  • Change the default setting of WiFiPAF as enabled if running on Linux system
  • Change to use C++ casting
  • Move the paf cancel function from destructor to shutdown
  • Add PAFTP

Testing

  • Environment:
    AP: Asus RT-N66U, running at chnl#1
    ctrl: Rpi + NetGear, Inc. A6210
    dut#1: rpi + Linksys AE6000
    dut#2: imx93+iw612
  • dut:
    $ sudo ./chip-all-clusters-app --wifi --wifipaf freq_list=2412
  • ctrl: Connect with AP before running the test
    $ sudo ./chip-tool pairing code-wifi 1 n_m_2g nxp12345 MT:-24J0SGJ10KA0648G00 --freq 2412
    $ sudo ./chip-tool pairing wifipaf-wifi 1 n_m_2g nxp12345 20202021 3840 --freq 2412

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Aug 3, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  src/platform/Linux/dbus/wpa/DBusWpaInterface.xml  76% smaller
  examples/chip-tool/commands/pairing/PairingCommand.cpp Unsupported file format
  examples/chip-tool/commands/pairing/PairingCommand.h Unsupported file format
  examples/platform/linux/AppMain.cpp Unsupported file format
  examples/platform/linux/Options.h Unsupported file format
  scripts/tools/check_includes_config.py  0% smaller
  src/app/server/CommissioningWindowManager.cpp Unsupported file format
  src/app/server/Server.cpp Unsupported file format
  src/controller/CHIPDeviceController.cpp Unsupported file format
  src/controller/CHIPDeviceController.h Unsupported file format
  src/controller/CHIPDeviceControllerFactory.h Unsupported file format
  src/controller/CHIPDeviceControllerSystemState.h Unsupported file format
  src/controller/SetUpCodePairer.cpp Unsupported file format
  src/controller/SetUpCodePairer.h Unsupported file format
  src/include/platform/CHIPDeviceConfig.h Unsupported file format
  src/include/platform/CHIPDeviceEvent.h Unsupported file format
  src/include/platform/ConnectivityManager.h Unsupported file format
  src/include/platform/internal/GenericPlatformManagerImpl.ipp Unsupported file format
  src/lib/BUILD.gn Unsupported file format
  src/lib/support/logging/Constants.h Unsupported file format
  src/lib/support/logging/TextOnlyLogging.cpp Unsupported file format
  src/platform/Linux/BUILD.gn Unsupported file format
  src/platform/Linux/ConnectivityManagerImpl.cpp Unsupported file format
  src/platform/Linux/ConnectivityManagerImpl.h Unsupported file format
  src/platform/device.gni Unsupported file format
  src/transport/SecureSession.h Unsupported file format
  src/transport/UnauthenticatedSessionTable.h Unsupported file format
  src/transport/raw/PeerAddress.h Unsupported file format
  src/transport/raw/WiFiPAF.cpp Unsupported file format
  src/transport/raw/WiFiPAF.h Unsupported file format
  src/wifipaf/BUILD.gn Unsupported file format
  src/wifipaf/WiFiPAFConfig.h Unsupported file format
  src/wifipaf/WiFiPAFEndPoint.cpp Unsupported file format
  src/wifipaf/WiFiPAFEndPoint.h Unsupported file format
  src/wifipaf/WiFiPAFError.h Unsupported file format
  src/wifipaf/WiFiPAFLayer.cpp Unsupported file format
  src/wifipaf/WiFiPAFLayer.h Unsupported file format
  src/wifipaf/WiFiPAFLayerDelegate.h Unsupported file format
  src/wifipaf/WiFiPAFRole.h Unsupported file format
  src/wifipaf/WiFiPAFTP.cpp Unsupported file format
  src/wifipaf/WiFiPAFTP.h Unsupported file format

crlonxp and others added 24 commits February 3, 2025 16:02
@crlonxp
* Fix the error found by the building script
9de1714 
Signed-off-by: Lo,Chin-Ran <[email protected]>
@crlonxp
Change by followign the review's comment
c4aa2e9 
Signed-off-by: Lo,Chin-Ran <[email protected]>
@restyled-commits @crlonxp
Restyled by clang-format
1003419
@restyled-commits @crlonxp
Restyled by gn
705c448
@crlonxp
Disable WiFiPAF by default
30f4f6f 
Signed-off-by: Lo,Chin-Ran <[email protected]>
@crlonxp
Separate the dbus parameters to have their own type, instead of using…
31c012f 
… the string

Signed-off-by: Lo,Chin-Ran <[email protected]>
@restyled-commits @crlonxp
Restyled by clang-format
8dfb9ef
@crlonxp
Change the dbus calling method by following the new defined api of wp…
f9ee1e3 
…a_supplicant

Signed-off-by: Lo,Chin-Ran <[email protected]>
@crlonxp
Fix a coredump if chip_device_config_enable_wifipaf is set, but --wif…
efd4a90 
…ipaf is not selected

Signed-off-by: Lo,Chin-Ran <[email protected]>
@crlonxp
Restart DnssdServer on connectivity change, not only on ipv4, but als…
8945202 
…o on ipv6

Signed-off-by: Lo,Chin-Ran <[email protected]>
@crlonxp
Fix the compile error after rebasing to master branch
8ef0afe
@crlonxp
* Block the multiple indication of discovery-result
db71be3 
* Fix the problems in NANCancelPublish by using the incorrect type and id

Signed-off-by: Lo,Chin-Ran <[email protected]>
@crlonxp @andy31415
Update src/lib/BUILD.gn
3bb9610 
Co-authored-by: Andrei Litvin <[email protected]>
@crlonxp @andy31415
Update src/platform/Linux/BUILD.gn
298ea88 
Co-authored-by: Andrei Litvin <[email protected]>
@crlonxp
* Add the unit to the time-out const
02abd28 
* Refine the function to transfer the freq_list from user to internal structure

Signed-off-by: Lo,Chin-Ran <[email protected]>
@crlonxp
Add "freq" option of chip-tool to pass down the frequency of the conn…
b2f95e9 
…ected ap

Signed-off-by: Lo,Chin-Ran <[email protected]>
@crlonxp
Add a vector to management the PAF sessions
5a00867 
Miscellaneous bugs fixing

Signed-off-by: Lo,Chin-Ran <[email protected]>
@crlonxp
Fix the errors found from the ci/cv
907dc5e 
Signed-off-by: Lo,Chin-Ran <[email protected]>
@crlonxp
* Bug fix: Add the PAF session if using code-wifi
a0eea8d 
* Remove unused code

Signed-off-by: Lo,Chin-Ran <[email protected]>
@crlonxp
Add to cancel PAF subscribe-session if user inputs ctrl+C to stop chi…
5499395 
…p-tool manually

Signed-off-by: Lo,Chin-Ran <[email protected]>
@crlonxp
Add PAFTP implementation
77fbfcd 
Signed-off-by: Lo,Chin-Ran <[email protected]>
@crlonxp
Add the missing .h to BUILD.gn for code-lints
b94af01 
Signed-off-by: Lo,Chin-Ran <[email protected]>
@crlonxp
Fix the clang error
8dc69c7 
Signed-off-by: Lo,Chin-Ran <[email protected]>
@crlonxp
Add to close PAF session while closing EndPoint module
4b80e86
@mergify mergify bot removed the conflict label Feb 3, 2025
@crlonxp
Add the re-order processing right after receiving the PAF packets
c4abaac 
Cancel the publish if the previous fabric information has existed

Signed-off-by: Lo,Chin-Ran <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025 •
edited
Loading

PR #34764: Size comparison from dd0ce89 to c4abaac

Increases above 0.2%:

platform target config section dd0ce89 c4abaac change % change
linux air-purifier-app debug unknown 4760 4856 96 2.0
FLASH 2708945 2771967 63022 2.3
RAM 132816 133960 1144 0.9
all-clusters-app debug unknown 5568 5640 72 1.3
FLASH 5974968 6035972 61004 1.0
RAM 531632 532744 1112 0.2
all-clusters-minimal-app debug unknown 5464 5536 72 1.3
FLASH 5323654 5384690 61036 1.1
RAM 242744 243856 1112 0.5
bridge-app debug unknown 5480 5552 72 1.3
FLASH 4681842 4742012 60170 1.3
RAM 221480 222592 1112 0.5
chip-tool debug unknown 6120 6256 136 2.2
FLASH 13098730 13238848 140118 1.1
RAM 596770 618738 21968 3.7
chip-tool-ipv6only arm64 unknown 21848 22000 152 0.7
FLASH 11164208 11290408 126200 1.1
RAM 648496 667504 19008 2.9
fabric-admin debug unknown 5808 5944 136 2.3
FLASH 11388203 11526239 138036 1.2
RAM 596554 618130 21576 3.6
fabric-bridge-app debug unknown 4736 4816 80 1.7
FLASH 4506440 4567482 61042 1.4
RAM 208664 209776 1112 0.5
fabric-sync debug unknown 4976 5064 88 1.8
FLASH 5612821 5692693 79872 1.4
RAM 483536 485144 1608 0.3
lighting-app debug+rpc+ui unknown 6144 6216 72 1.2
FLASH 5624593 5685505 60912 1.1
RAM 231760 232904 1144 0.5
lock-app debug unknown 5416 5488 72 1.3
FLASH 4730956 4792022 61066 1.3
RAM 207728 208872 1144 0.6
ota-provider-app debug unknown 4776 4856 80 1.7
FLASH 4359500 4420482 60982 1.4
RAM 201368 202480 1112 0.6
ota-requestor-app debug unknown 4728 4808 80 1.7
FLASH 4496972 4557932 60960 1.4
RAM 205952 207048 1096 0.5
shell debug unknown 4256 4280 24 0.6
FLASH 3004877 3051917 47040 1.6
RAM 160504 161608 1104 0.7
thermostat-no-ble arm64 unknown 9536 9640 104 1.1
FLASH 4098768 4151500 52732 1.3
RAM 246144 247568 1424 0.6
tv-app debug unknown 5744 5832 88 1.5
FLASH 5952421 6031653 79232 1.3
RAM 606936 608624 1688 0.3
tv-casting-app debug unknown 5320 5416 96 1.8
FLASH 11272333 11386893 114560 1.0
RAM 710896 732064 21168 3.0
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section dd0ce89 c4abaac change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1093546 1093526 -20 -0.0
RAM 103298 103298 0 0.0
bl702 lighting-app bl702+eth FLASH 650158 650142 -16 -0.0
RAM 25265 25265 0 0.0
bl702+wifi FLASH 828066 828050 -16 -0.0
RAM 13981 13981 0 0.0
bl706+mfd+rpc+littlefs FLASH 1056626 1056610 -16 -0.0
RAM 23861 23861 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 888060 888044 -16 -0.0
RAM 18504 18504 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 971046 971030 -16 -0.0
RAM 16368 16368 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 838032 838032 0 0.0
RAM 123464 123464 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 823436 823428 -8 -0.0
RAM 125344 125344 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 770676 770668 -8 -0.0
RAM 113804 113804 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 754920 754920 0 0.0
RAM 114012 114012 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 538461 538461 0 0.0
RAM 205192 205192 0 0.0
lock CC3235SF_LAUNCHXL FLASH 572325 572317 -8 -0.0
RAM 205344 205344 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 679433 679425 -8 -0.0
RAM 78532 78532 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 699285 699277 -8 -0.0
RAM 81172 81172 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 699285 699277 -8 -0.0
RAM 81172 81172 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 656213 656213 0 0.0
RAM 73600 73600 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 615817 615809 -8 -0.0
RAM 71516 71516 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 635445 635445 0 0.0
RAM 74060 74060 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 635445 635445 0 0.0
RAM 74060 74060 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 635289 635281 -8 -0.0
RAM 74524 74524 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 654997 654989 -8 -0.0
RAM 77068 77068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 654997 654989 -8 -0.0
RAM 77068 77068 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 611725 611725 0 0.0
RAM 68612 68612 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 631585 631585 0 0.0
RAM 71252 71252 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 631585 631585 0 0.0
RAM 71252 71252 0 0.0
efr32 lock-app BRD4187C FLASH 936232 936232 0 0.0
RAM 159872 159872 0 0.0
BRD4338a FLASH 729884 729860 -24 -0.0
RAM 234700 234700 0 0.0
window-app BRD4187C FLASH 1029256 1029224 -32 -0.0
RAM 127976 127976 0 0.0
esp32 all-clusters-app c3devkit DRAM 97296 97296 0 0.0
FLASH 1577062 1577054 -8 -0.0
IRAM 83820 83820 0 0.0
m5stack DRAM 116092 116092 0 0.0
FLASH 1544978 1544978 0 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4760 4856 96 2.0
FLASH 2708945 2771967 63022 2.3
RAM 132816 133960 1144 0.9
all-clusters-app debug unknown 5568 5640 72 1.3
FLASH 5974968 6035972 61004 1.0
RAM 531632 532744 1112 0.2
all-clusters-minimal-app debug unknown 5464 5536 72 1.3
FLASH 5323654 5384690 61036 1.1
RAM 242744 243856 1112 0.5
bridge-app debug unknown 5480 5552 72 1.3
FLASH 4681842 4742012 60170 1.3
RAM 221480 222592 1112 0.5
chip-tool debug unknown 6120 6256 136 2.2
FLASH 13098730 13238848 140118 1.1
RAM 596770 618738 21968 3.7
chip-tool-ipv6only arm64 unknown 21848 22000 152 0.7
FLASH 11164208 11290408 126200 1.1
RAM 648496 667504 19008 2.9
fabric-admin debug unknown 5808 5944 136 2.3
FLASH 11388203 11526239 138036 1.2
RAM 596554 618130 21576 3.6
fabric-bridge-app debug unknown 4736 4816 80 1.7
FLASH 4506440 4567482 61042 1.4
RAM 208664 209776 1112 0.5
fabric-sync debug unknown 4976 5064 88 1.8
FLASH 5612821 5692693 79872 1.4
RAM 483536 485144 1608 0.3
lighting-app debug+rpc+ui unknown 6144 6216 72 1.2
FLASH 5624593 5685505 60912 1.1
RAM 231760 232904 1144 0.5
lock-app debug unknown 5416 5488 72 1.3
FLASH 4730956 4792022 61066 1.3
RAM 207728 208872 1144 0.6
ota-provider-app debug unknown 4776 4856 80 1.7
FLASH 4359500 4420482 60982 1.4
RAM 201368 202480 1112 0.6
ota-requestor-app debug unknown 4728 4808 80 1.7
FLASH 4496972 4557932 60960 1.4
RAM 205952 207048 1096 0.5
shell debug unknown 4256 4280 24 0.6
FLASH 3004877 3051917 47040 1.6
RAM 160504 161608 1104 0.7
thermostat-no-ble arm64 unknown 9536 9640 104 1.1
FLASH 4098768 4151500 52732 1.3
RAM 246144 247568 1424 0.6
tv-app debug unknown 5744 5832 88 1.5
FLASH 5952421 6031653 79232 1.3
RAM 606936 608624 1688 0.3
tv-casting-app debug unknown 5320 5416 96 1.8
FLASH 11272333 11386893 114560 1.0
RAM 710896 732064 21168 3.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 906992 906988 -4 -0.0
RAM 142395 142395 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 901532 901524 -8 -0.0
RAM 124739 124739 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 845716 845712 -4 -0.0
RAM 141323 141323 0 0.0
nxp contact k32w0+release FLASH 584304 584304 0 0.0
RAM 70860 70860 0 0.0
mcxw71+release FLASH 599664 599664 0 0.0
RAM 63080 63080 0 0.0
light k32w0+release FLASH 610748 610740 -8 -0.0
RAM 70252 70252 0 0.0
k32w1+release FLASH 685208 685208 0 0.0
RAM 48664 48664 0 0.0
lock mcxw71+release FLASH 748680 748680 0 0.0
RAM 67476 67476 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646356 1646340 -16 -0.0
RAM 211560 211560 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1553148 1553116 -32 -0.0
RAM 208376 208376 0 0.0
light cy8ckit_062s2_43012 FLASH 1468828 1468804 -24 -0.0
RAM 200352 200352 0 0.0
lock cy8ckit_062s2_43012 FLASH 1466860 1466836 -24 -0.0
RAM 224688 224688 0 0.0
qpg lighting-app qpg6105+debug FLASH 662016 662016 0 0.0
RAM 105204 105204 0 0.0
lock-app qpg6105+debug FLASH 619804 619804 0 0.0
RAM 99648 99648 0 0.0
stm32 light STM32WB5MM-DK FLASH 482624 482624 0 0.0
RAM 144672 144672 0 0.0
telink bridge-app tl7218x FLASH 664774 664754 -20 -0.0
RAM 90812 90812 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 621532 621512 -20 -0.0
RAM 31484 31484 0 0.0
light-app-ota-shell-factory-data tl3218x FLASH 770284 770264 -20 -0.0
RAM 43552 43552 0 0.0
tl7218x FLASH 778816 778796 -20 -0.0
RAM 98688 98688 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 680150 680130 -20 -0.0
RAM 52176 52176 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 708704 708684 -20 -0.0
RAM 73384 73384 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625618 625598 -20 -0.0
RAM 142016 142016 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 813000 812980 -20 -0.0
RAM 99560 99560 0 0.0
tizen all-clusters-app arm unknown 5116 5116 0 0.0
FLASH 1751916 1751884 -32 -0.0
RAM 93524 93524 0 0.0
chip-tool-ubsan arm unknown 11408 11408 0 0.0
FLASH 18698198 1869802 -176 -0.0
RAM 8183840 8183584 -256 -0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyg-apple andyg-apple Awaiting requested review from andyg-apple

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@axelnxp axelnxp Awaiting requested review from axelnxp

@bauerschwan bauerschwan Awaiting requested review from bauerschwan

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@cecille cecille Awaiting requested review from cecille

@chapongatien chapongatien Awaiting requested review from chapongatien

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@doru91 doru91 Awaiting requested review from doru91

@fessehaeve fessehaeve Awaiting requested review from fessehaeve

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@hicklin hicklin Awaiting requested review from hicklin

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kiel-apple kiel-apple Awaiting requested review from kiel-apple

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mhazley mhazley Awaiting requested review from mhazley

@mkardous-silabs mkardous-silabs Awaiting requested review from mkardous-silabs

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@p0fi p0fi Awaiting requested review from p0fi

@pidarped pidarped Awaiting requested review from pidarped

@plauric plauric Awaiting requested review from plauric

@rcasallas-silabs rcasallas-silabs Awaiting requested review from rcasallas-silabs

@ReneJosefsen ReneJosefsen Awaiting requested review from ReneJosefsen

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@tima-q tima-q Awaiting requested review from tima-q

@tobiasgraf tobiasgraf Awaiting requested review from tobiasgraf

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wiba-nordic wiba-nordic Awaiting requested review from wiba-nordic

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@woody-apple woody-apple Awaiting requested review from woody-apple

@jtov-sfy jtov-sfy Awaiting requested review from jtov-sfy

@andy31415 andy31415 Awaiting requested review from andy31415

Assignees
No one assigned
Labels
app controller examples lib linux platform review - pending scripts support tools transport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crlonxp @andy31415 @woody-apple @restyled-commits