[OVENOPSTATE] Add OvenOpState 2.6 test case from base #34735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. |
|
PR #34735: Size comparison from d139a42 to b6b8cbc Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34735: Size comparison from d139a42 to 500c024 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
tcarmelveilleux
added
the
matter-1.4-te2-script-change
| # | ||
| # === BEGIN CI TEST ARGUMENTS === | ||
| # test-runner-runs: run1 | ||
| # test-runner-run/run1/app: ${ALL_CLUSTERS_APP} |
There was a problem hiding this comment.
Does all cluster actually have oven?
Comment on lines
1287
to
1288
| logging.info('Test will now collect data for 30 seconds') | ||
| time.sleep(30) |
There was a problem hiding this comment.
In CI, this should be 10 seconds and 2 reports, or something like this, to reduce time.
Comment on lines
1300
to
1302
| attr_value = await self.read_expect_success( | ||
| endpoint=endpoint, | ||
| attribute=attributes.OperationalState) |
There was a problem hiding this comment.
Suggest pre-reading this to un-nest the if, so that you have:
if countdownTime is not NullValue and attr_value == cluster.Enums.OperationalStateEnum.kRunning: in one single if.
|
PR #34735: Size comparison from d139a42 to 5b61ea0 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, mbed, nrfconnect, nxp, qpg, stm32, telink, tizen)
|
|
PR #34735: Size comparison from 26c816a to ba8e1d6 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
|
rbultman
force-pushed
the
addOvenOpState2.6
branch
from
ac018f2 to
c53d771
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Note: This requires a modification to the base test plan.