Add water heater mode cluster test scripts #34347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #34347: Size comparison from 74768a8 to 883072d Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #34347: Size comparison from b88ac27 to 0e02488 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jul 18, 2024
pullapprove
bot
requested review from
andyg-apple,
anush-apple,
arkq,
axelnxp,
bauerschwan,
bzbarsky-apple,
carol-apple,
cecille,
chapongatien,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
doru91,
fessehaeve and
harimau-qirex
|
PR #34347: Size comparison from decd9e9 to fbb424f Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, linux, mbed, nrfconnect, nxp, qpg, stm32, tizen)
|
|
PR #34347: Size comparison from d9bcdd3 to 0673e3c Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jul 29, 2024
andy31415
reviewed
Jul 29, 2024
andy31415
reviewed
Jul 29, 2024
andy31415
reviewed
Jul 29, 2024
andy31415
reviewed
Jul 29, 2024
|
PR #34347: Size comparison from d9bcdd3 to 01dae06 Increases above 0.2%:
Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
reviewed
Jul 29, 2024
|
PR #34347: Size comparison from 29b055a to f1fe689 Full report (11 builds for cc32xx, mbed, nrfconnect, qpg, stm32, tizen)
|
|
PR #34347: Size comparison from 29b055a to 8bf5dca Full report (54 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, tizen)
|
|
PR #34347: Size comparison from 29b055a to 88178a3 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
reviewed
Jul 30, 2024
|
PR #34347: Size comparison from 29b055a to 9166de5 Full report (85 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
cecille
approved these changes
Jul 30, 2024
|
Fast track test scripts with a lot of review checkmark and online for a while. |
j-ororke
pushed a commit
to j-ororke/connectedhomeip
that referenced
this pull request
Jul 31, 2024
* Add water heater mode cluster test scripts * Add TC_EWATERHTRM_2_1.py * Fix lint errors * Restyled by isort * Renamed read_mod_attribute_expect_success to read_mode_attribute_expect_success * Changed test runner to run All-clusters-app where waterheater mode is implemented. * Added Test scripts to CI test.yaml (TC_EWATERHTRM_1_2.py & TC_EWATERHTRM_2_2.py) * Corrected checking of modes for WaterHeaterModes which must be included, and corrected the common modes. * Alignment (autowrapping) * Update tests.yaml - fixed test script name * Address review comments from Andrei * Address comments from Cecille * Restyled by autopep8 * Rename tests as PICS=WHM * Adding a TODO * Remove unnecessary blank line --------- Co-authored-by: Restyled.io <[email protected]> Co-authored-by: James Harrow <[email protected]> Co-authored-by: jamesharrow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add water heater mode cluster test scripts (issue Fixes #34255)
The water heater mode cluster test spec can be found here:
https://github.com/CHIP-Specifications/chip-test-plans/pull/4015/files
This PR follows is related to #34333 and #34339