Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix advertised device type for all-clusters-app to match data model. #33715

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Fix advertised device type for all-clusters-app to match data model. #33715

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3c0a59
Fix advertised device type for all-clusters-app to match data model.
bzbarsky-apple Jun 3, 2024
ff0292d
Address review comment.
bzbarsky-apple Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions examples/all-clusters-app/linux/include/CHIPProjectAppConfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,3 +47,7 @@
#define CHIP_CONFIG_MAX_PATHS_PER_INVOKE 5

#define CHIP_CONFIG_ENABLE_BDX_LOG_TRANSFER 1

// Claim a device type while advertising that matches the device type on our
// endpoint 1.
#define CHIP_DEVICE_CONFIG_DEVICE_TYPE 0x0101
4 changes: 4 additions & 0 deletions examples/all-clusters-app/tizen/include/CHIPProjectAppConfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,7 @@
// All clusters app has 3 group endpoints. This needs to defined here so that
// CHIP_CONFIG_MAX_GROUPS_PER_FABRIC is properly configured.
#define CHIP_CONFIG_MAX_GROUP_ENDPOINTS_PER_FABRIC 3

// Claim a device type while advertising that matches the device type on our
// endpoint 1.
#define CHIP_DEVICE_CONFIG_DEVICE_TYPE 0x0101
5 changes: 4 additions & 1 deletion src/app/tests/suites/TestDiscovery.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ name: Test Discovery
config:
nodeId: 0x12344321
endpoint: 0
# These defaults correspond to the behavior of all-clusters-app, and
# different values should be passed on the command line when testing
# against any other server.
discriminator:
type: int16u
defaultValue: 3840
Expand All @@ -31,7 +34,7 @@ config:
defaultValue: 32769
deviceType:
type: int16u
defaultValue: 65535
defaultValue: 0x0101

tests:
- label: "Stop target device"
Expand Down
Loading