Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MinMDNS - do not ask for IP addresses for every SRV record that is seen #33118

Merged
merged 7 commits into from
Apr 23, 2024
Merged

MinMDNS - do not ask for IP addresses for every SRV record that is seen #33118

merged 7 commits into from
Apr 23, 2024

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Apr 23, 2024 •
edited
Loading

Cherrypick of #33095 into the 1.2 branch
Also cherrypick #30987 to fix some compile errors due to prompt toolkit updates.
Also cherrypick #32474 to fix some compile errors for esp32 compilation
Also cherrypick #32687 to fix some compile errors due to module named proto conflict in python modules

@andy31415 @andreilitvin
MinMDNS - do not ask for IP addresses for every SRV record that is se…
959bbc4 
…en (project-chip#33095)

* Initial version of a test app - ability to just send a packet into the world

* Update constants to match a real advertisement

* Only resolve IP addresses if we are interested in this path

* Fix up logic: this is per peer id

* Remove unused include

* Undo debug code

* Undo extra header add

* Add header back, but with full path

* Fix up some more headers

* Remove unhelpful comment

* Move tester program out (will be part of another PR)

---------

Co-authored-by: Andrei Litvin <[email protected]>
@github-actions github-actions bot added the lib label Apr 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

PR #33118: Size comparison from 9897d2e to 50a0a56

Full report (12 builds for cc13x4_26x4, k32w, qpg)
platform target config section 9897d2e 50a0a56 change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 735843 735843 0 0.0
(read/write) 166436 166436 0 0.0
.bss 88852 88852 0 0.0
.data 3420 3420 0 0.0
.rodata 84351 84351 0 0.0
.text 651104 651104 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 757443 757443 0 0.0
(read/write) 176720 176720 0 0.0
.bss 99100 99100 0 0.0
.data 3440 3440 0 0.0
.rodata 79927 79927 0 0.0
.text 677124 677124 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 744779 744779 0 0.0
(read/write) 171176 171176 0 0.0
.bss 93556 93556 0 0.0
.data 3440 3440 0 0.0
.rodata 106015 106015 0 0.0
.text 638372 638372 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 695595 695595 0 0.0
(read/write) 165528 165528 0 0.0
.bss 87720 87720 0 0.0
.data 3408 3408 0 0.0
.rodata 80175 80175 0 0.0
.text 615032 615032 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 681267 681267 0 0.0
(read/write) 165668 165668 0 0.0
.bss 87864 87864 0 0.0
.data 3404 3404 0 0.0
.rodata 76007 76007 0 0.0
.text 604872 604872 0 0.0
k32w contact k32w0+release (read only) 589868 589868 0 0.0
(read/write) 87508 87508 0 0.0
.bss 70752 70752 0 0.0
.data 2132 2132 0 0.0
.text 589332 589332 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 684772 684772 0 0.0
.bss 66952 66952 0 0.0
.data 2716 2716 0 0.0
.text 571624 571624 0 0.0
light k32w0+release (read only) 589588 589588 0 0.0
(read/write) 87184 87184 0 0.0
.bss 70440 70440 0 0.0
.data 2120 2120 0 0.0
.text 589052 589052 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 776736 776736 0 0.0
.bss 76628 76628 0 0.0
.data 1928 1928 0 0.0
.text 654720 654720 0 0.0
lock k32w0+release (read only) 561348 561348 0 0.0
(read/write) 85012 85012 0 0.0
.bss 68328 68328 0 0.0
.data 2060 2060 0 0.0
.text 560812 560812 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1177092 1177092 0 0.0
.bss 100608 100608 0 0.0
.data 744 744 0 0.0
.text 623936 623936 0 0.0
lock-app qpg6105+debug (read/write) 1133580 1133580 0 0.0
.bss 95288 95288 0 0.0
.data 748 748 0 0.0
.text 580420 580420 0 0.0

andreilitvin and others added 3 commits April 23, 2024 14:58
@andreilitvin
Remove include that is not valid for 1.2
0aaf37c
@shubhamdp @andreilitvin
[ESP32] bump the component manager version (project-chip#32474)
612191e 
* [ESP32] bump the component manager version

* Update requirements.esp32.txt

* Update requirements.esp32.txt

* fix the version in constraints.txt
@andy31415 @andreilitvin
Fix google-api-core (project-chip#32687)
1e561a9
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

PR #33118: Size comparison from 9897d2e to 1e561a9

Increases (6 builds for cc32xx, psoc6)
platform target config section 9897d2e 1e561a9 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL (read only) 562098 562314 216 0.0
.debug_abbrev 903134 903135 1 0.0
.debug_aranges 104328 104344 16 0.0
.debug_frame 351292 351356 64 0.0
.debug_info 19452487 19453466 979 0.0
.debug_line 2592989 2593371 382 0.0
.debug_loclists 1578966 1579377 411 0.0
.debug_rnglists 107629 107665 36 0.0
.debug_str 3391562 3391844 282 0.0
.strtab 467751 467894 143 0.0
.symtab 279216 279280 64 0.0
.text 476304 476520 216 0.0
lock CC3235SF_LAUNCHXL (read only) 618266 618482 216 0.0
.debug_abbrev 943794 943795 1 0.0
.debug_aranges 108792 108808 16 0.0
.debug_frame 366572 366636 64 0.0
.debug_info 20629185 20630164 979 0.0
.debug_line 2663362 2663744 382 0.0
.debug_loclists 1634657 1635068 411 0.0
.debug_rnglists 112166 112202 36 0.0
.debug_str 3455748 3456030 282 0.0
.strtab 516987 517130 143 0.0
.symtab 298832 298896 64 0.0
.text 509916 510132 216 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read/write) 1723516 1723724 208 0.0
.debug_abbrev 1327158 1327159 1 0.0
.debug_aranges 141008 141024 16 0.0
.debug_frame 467156 467220 64 0.0
.debug_info 30280903 30281882 979 0.0
.debug_line 3898558 3898940 382 0.0
.debug_loclists 2245367 2245778 411 0.0
.debug_rnglists 151730 151766 36 0.0
.debug_str 4118416 4118698 282 0.0
.strtab 798235 798378 143 0.0
.symtab 494048 494112 64 0.0
.text 1519924 1520132 208 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read/write) 1682044 1682252 208 0.0
.debug_abbrev 1267368 1267369 1 0.0
.debug_aranges 137224 137240 16 0.0
.debug_frame 460544 460608 64 0.0
.debug_info 28552699 28553678 979 0.0
.debug_line 3803635 3804017 382 0.0
.debug_loclists 2189783 2190194 411 0.0
.debug_rnglists 147545 147581 36 0.0
.debug_str 4011153 4011435 282 0.0
.strtab 742590 742733 143 0.0
.symtab 475104 475168 64 0.0
.text 1480252 1480460 208 0.0
light cy8ckit_062s2_43012 (read/write) 1608212 1608436 224 0.0
.debug_abbrev 1109046 1109047 1 0.0
.debug_aranges 127296 127312 16 0.0
.debug_frame 423468 423532 64 0.0
.debug_info 23670432 23671411 979 0.0
.debug_line 3377965 3378347 382 0.0
.debug_loclists 2026268 2026679 411 0.0
.debug_rnglists 137091 137127 36 0.0
.debug_str 3817975 3818257 282 0.0
.strtab 655759 655902 143 0.0
.symtab 436608 436672 64 0.0
.text 1412972 1413196 224 0.0
lock cy8ckit_062s2_43012 (read/write) 1641028 1641236 208 0.0
.debug_abbrev 1101892 1101893 1 0.0
.debug_aranges 125976 125992 16 0.0
.debug_frame 418704 418768 64 0.0
.debug_info 23480111 23481090 979 0.0
.debug_line 3330301 3330683 382 0.0
.debug_loclists 2003000 2003411 411 0.0
.debug_rnglists 135114 135150 36 0.0
.debug_str 3780235 3780517 282 0.0
.strtab 629264 629407 143 0.0
.symtab 428144 428208 64 0.0
.text 1418524 1418732 208 0.0
Full report (22 builds for cc13x4_26x4, cc32xx, cyw30739, k32w, psoc6, qpg)
platform target config section 9897d2e 1e561a9 change % change
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 (read only) 735843 735843 0 0.0
(read/write) 166436 166436 0 0.0
.bss 88852 88852 0 0.0
.data 3420 3420 0 0.0
.rodata 84351 84351 0 0.0
.text 651104 651104 0 0.0
lock-ftd LP_EM_CC1354P10_6 (read only) 757443 757443 0 0.0
(read/write) 176720 176720 0 0.0
.bss 99100 99100 0 0.0
.data 3440 3440 0 0.0
.rodata 79927 79927 0 0.0
.text 677124 677124 0 0.0
lock-mtd LP_EM_CC1354P10_6 (read only) 744779 744779 0 0.0
(read/write) 171176 171176 0 0.0
.bss 93556 93556 0 0.0
.data 3440 3440 0 0.0
.rodata 106015 106015 0 0.0
.text 638372 638372 0 0.0
pump-app LP_EM_CC1354P10_6 (read only) 695595 695595 0 0.0
(read/write) 165528 165528 0 0.0
.bss 87720 87720 0 0.0
.data 3408 3408 0 0.0
.rodata 80175 80175 0 0.0
.text 615032 615032 0 0.0
pump-controller-app LP_EM_CC1354P10_6 (read only) 681267 681267 0 0.0
(read/write) 165668 165668 0 0.0
.bss 87864 87864 0 0.0
.data 3404 3404 0 0.0
.rodata 76007 76007 0 0.0
.text 604872 604872 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 562098 562314 216 0.0
(read/write) 206492 206492 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 199956 199956 0 0.0
.comment 206 206 0 0.0
.data 1412 1412 0 0.0
.debug_abbrev 903134 903135 1 0.0
.debug_aranges 104328 104344 16 0.0
.debug_frame 351292 351356 64 0.0
.debug_info 19452487 19453466 979 0.0
.debug_line 2592989 2593371 382 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1578966 1579377 411 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 107629 107665 36 0.0
.debug_str 3391562 3391844 282 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 83674 83674 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 467751 467894 143 0.0
.symtab 279216 279280 64 0.0
.text 476304 476520 216 0.0
lock CC3235SF_LAUNCHXL (read only) 618266 618482 216 0.0
(read/write) 206896 206896 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 200336 200336 0 0.0
.comment 206 206 0 0.0
.data 1440 1440 0 0.0
.debug_abbrev 943794 943795 1 0.0
.debug_aranges 108792 108808 16 0.0
.debug_frame 366572 366636 64 0.0
.debug_info 20629185 20630164 979 0.0
.debug_line 2663362 2663744 382 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1634657 1635068 411 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 112166 112202 36 0.0
.debug_str 3455748 3456030 282 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106226 106226 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 516987 517130 143 0.0
.symtab 298832 298896 64 0.0
.text 0 0 0 0.0
509916 510132 216 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 553015 553015 0 0.0
.app_xip_area 444233 444233 0 0.0
.bss 63752 63752 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 539127 539127 0 0.0
.app_xip_area 425545 425545 0 0.0
.bss 68520 68520 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 574583 574583 0 0.0
.app_xip_area 467129 467129 0 0.0
.bss 62496 62496 0 0.0
.data 588 588 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 550879 550879 0 0.0
.app_xip_area 440337 440337 0 0.0
.bss 65488 65488 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
k32w contact k32w0+release (read only) 589868 589868 0 0.0
(read/write) 87508 87508 0 0.0
.bss 70752 70752 0 0.0
.data 2132 2132 0 0.0
.text 589332 589332 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 684772 684772 0 0.0
.bss 66952 66952 0 0.0
.data 2716 2716 0 0.0
.text 571624 571624 0 0.0
light k32w0+release (read only) 589588 589588 0 0.0
(read/write) 87184 87184 0 0.0
.bss 70440 70440 0 0.0
.data 2120 2120 0 0.0
.text 589052 589052 0 0.0
k32w1+release (read only) 1024 1024 0 0.0
(read/write) 776736 776736 0 0.0
.bss 76628 76628 0 0.0
.data 1928 1928 0 0.0
.text 654720 654720 0 0.0
lock k32w0+release (read only) 561348 561348 0 0.0
(read/write) 85012 85012 0 0.0
.bss 68328 68328 0 0.0
.data 2060 2060 0 0.0
.text 560812 560812 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 838136 838136 0 0.0
(read/write) 1723516 1723724 208 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 192708 192708 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2496 2496 0 0.0
.debug_abbrev 1327158 1327159 1 0.0
.debug_aranges 141008 141024 16 0.0
.debug_frame 467156 467220 64 0.0
.debug_info 30280903 30281882 979 0.0
.debug_line 3898558 3898940 382 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2245367 2245778 411 0.0
.debug_rnglists 151730 151766 36 0.0
.debug_str 4118416 4118698 282 0.0
.heap 838136 838136 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 798235 798378 143 0.0
.symtab 494048 494112 64 0.0
.text 1519924 1520132 208 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 839936 839936 0 0.0
(read/write) 1682044 1682252 208 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 190932 190932 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1267368 1267369 1 0.0
.debug_aranges 137224 137240 16 0.0
.debug_frame 460544 460608 64 0.0
.debug_info 28552699 28553678 979 0.0
.debug_line 3803635 3804017 382 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2189783 2190194 411 0.0
.debug_rnglists 147545 147581 36 0.0
.debug_str 4011153 4011435 282 0.0
.heap 839936 839936 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 742590 742733 143 0.0
.symtab 475104 475168 64 0.0
.text 1480252 1480460 208 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 846488 846488 0 0.0
(read/write) 1608212 1608436 224 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184492 184492 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2360 2360 0 0.0
.debug_abbrev 1109046 1109047 1 0.0
.debug_aranges 127296 127312 16 0.0
.debug_frame 423468 423532 64 0.0
.debug_info 23670432 23671411 979 0.0
.debug_line 3377965 3378347 382 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 2026268 2026679 411 0.0
.debug_rnglists 137091 137127 36 0.0
.debug_str 3817975 3818257 282 0.0
.heap 846488 846488 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 655759 655902 143 0.0
.symtab 436608 436672 64 0.0
.text 1412972 1413196 224 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 819224 819224 0 0.0
(read/write) 1641028 1641236 208 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 211740 211740 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2376 2376 0 0.0
.debug_abbrev 1101892 1101893 1 0.0
.debug_aranges 125976 125992 16 0.0
.debug_frame 418704 418768 64 0.0
.debug_info 23480111 23481090 979 0.0
.debug_line 3330301 3330683 382 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 2003000 2003411 411 0.0
.debug_rnglists 135114 135150 36 0.0
.debug_str 3780235 3780517 282 0.0
.heap 819224 819224 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 629264 629407 143 0.0
.symtab 428144 428208 64 0.0
.text 1418524 1418732 208 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1177092 1177092 0 0.0
.bss 100608 100608 0 0.0
.data 744 744 0 0.0
.text 623936 623936 0 0.0
lock-app qpg6105+debug (read/write) 1133580 1133580 0 0.0
.bss 95288 95288 0 0.0
.data 748 748 0 0.0
.text 580420 580420 0 0.0

@andy31415 andy31415 merged commit b35ef93 into project-chip:v1.2-branch Apr 23, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mspang mspang mspang approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

Assignees
No one assigned
Labels
lib release note scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andy31415 @mspang @tcarmelveilleux @woody-apple @andreilitvin @shubhamdp