-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] remove lwipopts-thread.h. #32002
Merged
mergify
merged 2 commits into
project-chip:master
from
jmartinez-silabs:remove_lwipopts_thread
Mar 3, 2024
Merged
[Silabs] remove lwipopts-thread.h. #32002
mergify
merged 2 commits into
project-chip:master
from
jmartinez-silabs:remove_lwipopts_thread
Mar 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #32002: Size comparison from f658ea2 to cd0c62f Full report (29 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, k32w, mbed, nrfconnect, qpg, stm32)
|
cd0c62f
to
54c3957
Compare
PR #32002: Size comparison from f658ea2 to 54c3957 Full report (69 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
yunhanw-google
approved these changes
Feb 8, 2024
pidarped
approved these changes
Feb 8, 2024
bzbarsky-apple
approved these changes
Feb 8, 2024
…of lwip (so it uses the same config as our sample apps). Add to implement additional InetInterface method that were missing for the openthread inet endpoint interface. Make TestInetAddress.cpp work for CHIP_SYSTEM_CONFIG_USE_OPEN_THREAD_ENDPOINT
54c3957
to
6af00a3
Compare
PR #32002: Size comparison from d8f5bf1 to 6af00a3 Increases (6 builds for bl702, bl702l, efr32)
Decreases (3 builds for bl602, efr32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
Sarthak-Shaha
pushed a commit
to Sarthak-Shaha/connectedhomeip_silabs
that referenced
this pull request
Mar 5, 2024
* remove lwipopts-thread.h. LWIP is not using with our thread implementation * Fix to build efr32 test driver with openthread Inet endpoint instead of lwip (so it uses the same config as our sample apps). Add to implement additional InetInterface method that were missing for the openthread inet endpoint interface. Make TestInetAddress.cpp work for CHIP_SYSTEM_CONFIG_USE_OPEN_THREAD_ENDPOINT
erwinpan1
pushed a commit
to erwinpan1/connectedhomeip
that referenced
this pull request
Mar 7, 2024
* remove lwipopts-thread.h. LWIP is not using with our thread implementation * Fix to build efr32 test driver with openthread Inet endpoint instead of lwip (so it uses the same config as our sample apps). Add to implement additional InetInterface method that were missing for the openthread inet endpoint interface. Make TestInetAddress.cpp work for CHIP_SYSTEM_CONFIG_USE_OPEN_THREAD_ENDPOINT
huangxuyong
pushed a commit
to huangxuyong/connectedhomeip
that referenced
this pull request
Mar 19, 2024
* remove lwipopts-thread.h. LWIP is not using with our thread implementation * Fix to build efr32 test driver with openthread Inet endpoint instead of lwip (so it uses the same config as our sample apps). Add to implement additional InetInterface method that were missing for the openthread inet endpoint interface. Make TestInetAddress.cpp work for CHIP_SYSTEM_CONFIG_USE_OPEN_THREAD_ENDPOINT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LWIP is not used with our thread implementation. We don't need that file anymore
Edit : The efr32 test driver was actually built with lwip socket implementation. The latest commit changes that to use Openthread inet endpoint like all our sample apps:
InetInterface
methods were missing for that implementation, and therefore the efr32 test driver was not linking for the CHIP_SYSTEM_CONFIG_USE_OPEN_THREAD_ENDPOINT build. This last commit implements those.TestInetAddress
was failing forCHIP_SYSTEM_CONFIG_USE_OPEN_THREAD_ENDPOINT
implementation because the Openthread stack formats address string uncompressed which was not the expected outcome for some tests. Tweak those tests to compare uncompressed addresses string instead for theCHIP_SYSTEM_CONFIG_USE_OPEN_THREAD_ENDPOINT
build.