-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: configurable ble advertising autostart for esp32 #30482
Merged
mergify
merged 1 commit into
project-chip:master
from
hideakitai:feature/configurable-ble-advertising-autostart-for-esp32
Nov 15, 2023
Merged
feature: configurable ble advertising autostart for esp32 #30482
mergify
merged 1 commit into
project-chip:master
from
hideakitai:feature/configurable-ble-advertising-autostart-for-esp32
Nov 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #30482: Size comparison from 27328ae to 7421485 Decreases (1 build for esp32)
Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add configuration about
CHIP_DEVICE_CONFIG_CHIPOBLE_ENABLE_ADVERTISING_AUTOSTART
for ESP32 cc @dhrishiBackground
CHIP_DEVICE_CONFIG_CHIPOBLE_ENABLE_ADVERTISING_AUTOSTART
is set1
by default now by the source code here. But this configuration causes starting advertising too early (before opening commissioning window). Also,USE_BLE_ONLY_FOR_COMMISSIONIG
isy
by default, so unnecessary BLE Advertising starts if the user uses BLE only for commissioning.This default value also causes unstable behavior if the commissioner starts commissioning soon after power-up (like Amazon Matter Simple Setup) because the initialization may not be finished before opening the commissioning window.
So I have added the configuration about
CHIP_DEVICE_CONFIG_CHIPOBLE_ENABLE_ADVERTISING_AUTOSTART
. This enables the users to configure the BLE advertising autostart behavior without modifying the code.The default value is set to
0
because BLE advertising is used only for commissioning (USE_BLE_ONLY_FOR_COMMISSIONING
isy
by default).