-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[data-model] Add general diagnostics average wear count #29285
Merged
mergify
merged 10 commits into
project-chip:master
from
NXP:add-general-diagnostics-average-wear-count
Sep 21, 2023
Merged
[data-model] Add general diagnostics average wear count #29285
mergify
merged 10 commits into
project-chip:master
from
NXP:add-general-diagnostics-average-wear-count
Sep 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #29285: Size comparison from d104699 to 300fe46 Increases (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (65 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
requested changes
Sep 15, 2023
src/app/clusters/general-diagnostics-server/general-diagnostics-server.cpp
Show resolved
Hide resolved
PR #29285: Size comparison from d104699 to 7389439 Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
Signed-off-by: marius-alex-tache <[email protected]>
Signed-off-by: marius-alex-tache <[email protected]>
Signed-off-by: marius-alex-tache <[email protected]>
Signed-off-by: marius-alex-tache <[email protected]>
Signed-off-by: marius-alex-tache <[email protected]>
7389439
to
eba862f
Compare
PR #29285: Size comparison from 63397c3 to eba862f Increases (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Sep 18, 2023
@marius-alex-tache Note that you need to re-run codegen. |
Signed-off-by: marius-alex-tache <[email protected]>
Signed-off-by: marius-alex-tache <[email protected]>
PR #29285: Size comparison from 63397c3 to 14b61a5 Increases above 0.2%:
Increases (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, k32w, linux, psoc6, qpg)
Full report (66 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Sep 19, 2023
andy31415
reviewed
Sep 19, 2023
src/app/zap-templates/zcl/data-model/chip/general-diagnostics-cluster.xml
Outdated
Show resolved
Hide resolved
andy31415
approved these changes
Sep 19, 2023
Signed-off-by: marius-alex-tache <[email protected]>
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…#29285) * [clusters] Add AverageWearCount attribute support in GeneralDiagnostics Signed-off-by: marius-alex-tache <[email protected]> * [codegen] Regenerate generated code Signed-off-by: marius-alex-tache <[email protected]> * Add AverageWearCount to zcl data Signed-off-by: marius-alex-tache <[email protected]> * Remove AverageWearCount from Darwin availability Signed-off-by: marius-alex-tache <[email protected]> * Add API documentation for General Diagnostics interface Signed-off-by: marius-alex-tache <[email protected]> * Restyled by whitespace * Restyled by prettier-json * Remove redundant comments from General Diagnostics interface Signed-off-by: marius-alex-tache <[email protected]> * [codegen] Regenerate generated code Signed-off-by: marius-alex-tache <[email protected]> * Remove redundant min/max range for General Diagnostics attributes Signed-off-by: marius-alex-tache <[email protected]> --------- Signed-off-by: marius-alex-tache <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for AverageWearCount optional attribute in GeneralDiagnostics cluster.
Spec reference PR: https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/7535