-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Step 3a of TC_xxxCONC_1_1 #28840
Merged
mergify
merged 2 commits into
project-chip:master
from
dysonltd:hotfix/concentration-measurement-fix-tc-1-1-3a
Aug 24, 2023
Merged
Fix Step 3a of TC_xxxCONC_1_1 #28840
mergify
merged 2 commits into
project-chip:master
from
dysonltd:hotfix/concentration-measurement-fix-tc-1-1-3a
Aug 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #28840: Size comparison from bd8c01f to 54f0729 Decreases (1 build for efr32)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
@manjunath-grl it would be great if you could review, I think this is reverting your change! |
manjunath-grl
approved these changes
Aug 23, 2023
cecille
reviewed
Aug 24, 2023
cecille
approved these changes
Aug 24, 2023
saurabhst
approved these changes
Aug 24, 2023
jmartinez-silabs
approved these changes
Aug 24, 2023
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
* Modified Step 3a for all concentration tests * Regenned the test code
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
* Modified Step 3a for all concentration tests * Regenned the test code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes test step 3a in all Concentration Measurement 1.1 tests.
Before it was checking for a non-compliant state.
Now, it checks for the statement in the Test Plan:
Links
Fixes #28838