[Scenes]Added the level-control cluster handler for scenes EFS #28836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple,
lazarkov,
LuDuda and
mhazley
pullapprove
bot
requested review from
vivien-apple,
woody-apple,
younghak-hwang,
yufengwangca and
yunhanw-google
|
PR #28836: Size comparison from bd8c01f to fcc8ea7 Increases above 0.2%:
Increases (26 builds for bl702, bl702l, cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Decreases (12 builds for bl602, bl702, bl702l, cc32xx, psoc6, telink)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Aug 23, 2023
andy31415
reviewed
Aug 23, 2023
andy31415
reviewed
Aug 23, 2023
andy31415
reviewed
Aug 23, 2023
andy31415
reviewed
Aug 23, 2023
andy31415
reviewed
Aug 23, 2023
|
PR #28836: Size comparison from bd8c01f to 4b87d42 Increases above 0.2%:
Increases (15 builds for cyw30739, efr32, esp32, linux, nrfconnect, psoc6)
Decreases (13 builds for bl702, bl702l, cc32xx, esp32, linux, psoc6)
Full report (44 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
jmartinez-silabs
approved these changes
Aug 23, 2023
|
PR #28836: Size comparison from bd8c01f to 74ca620 Increases above 0.2%:
Increases (21 builds for cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Decreases (13 builds for bl702, bl702l, cc32xx, esp32, linux, psoc6)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Aug 24, 2023
andy31415
approved these changes
Aug 24, 2023
|
PR #28836: Size comparison from bd8c01f to 0c19af7 Increases above 0.2%:
Increases (24 builds for cyw30739, efr32, esp32, linux, nrfconnect, psoc6, telink)
Decreases (25 builds for bl702, bl702l, cc32xx, efr32, esp32, linux, psoc6, qpg, telink)
Full report (62 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
abpoth
pushed a commit
to abpoth/connectedhomeip
that referenced
this pull request
Aug 25, 2023
…ct-chip#28836) * Added the level-control cluster handler for scenes EFS * Updated the Null value handling and handling of absence of frequency feature * optimsed ifdef in on-on handler * Applied change to allow attribute count increase in the futur
| VerifyOrReturnError(EMBER_ZCL_STATUS_SUCCESS == Attributes::MaxLevel::Get(endpoint, &maxLevel), CHIP_ERROR_READ_FAILED); | ||
|
|
||
| pairs[0].attributeID = Attributes::CurrentLevel::Id; | ||
| pairs[0].attributeValue = (!level.IsNull()) ? level.Value() : maxLevel + 1; |
There was a problem hiding this comment.
This will be broken if the scene is then recalled with a different maxlevel for some reason.
Is there a reason this is not using the existing attribute-storage-null-handling.h facilities which would let us encode null in an integer?
| : Commands::MoveToLevel::Id; | ||
|
|
||
| status = moveToLevelHandler( | ||
| endpoint, command, level, app::DataModel::MakeNullable<uint16_t>(static_cast<uint16_t>(timeMs / 100)), |
There was a problem hiding this comment.
Why do you need both the cast and the explicit template argument? You shouldn't need both...
| : Commands::MoveToLevel::Id; | ||
|
|
||
| status = moveToLevelHandler( | ||
| endpoint, command, level, app::DataModel::MakeNullable<uint16_t>(static_cast<uint16_t>(timeMs / 100)), |
There was a problem hiding this comment.
But if the level was null when we stored the scene... won't this just ignore the moveToLevelHandler call, at least when MaxLevel is 254? This looks broken.
| @@ -289,7 +289,13 @@ class DefaultOnOffSceneHandler : public scenes::DefaultSceneHandlerImpl | |||
| return err; | |||
| } | |||
|
|
|||
| OnOffServer::Instance().scheduleTimerCallbackMs(sceneEventControl(endpoint), timeMs); | |||
| #ifdef EMBER_AF_PLUGIN_LEVEL_CONTROL | |||
| if (!(LevelControlWithOnOffFeaturePresent(endpoint) && | |||
There was a problem hiding this comment.
This needs some documentation explaining why this logic is here.
HunsupJung
pushed a commit
to HunsupJung/connectedhomeip
that referenced
this pull request
Oct 23, 2023
…ct-chip#28836) * Added the level-control cluster handler for scenes EFS * Updated the Null value handling and handling of absence of frequency feature * optimsed ifdef in on-on handler * Applied change to allow attribute count increase in the futur
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now scenes will be able to take action on level control clusters.