-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] Adds bugfix for building applications on SiWx917 SoC #28468
[Silabs] Adds bugfix for building applications on SiWx917 SoC #28468
Conversation
PR #28468: Size comparison from c4d95d0 to c750522 Increases (9 builds for bl602, cc32xx, efr32, esp32, psoc6, telink)
Decreases (17 builds for bl702, bl702l, cyw30739, efr32, nrfconnect, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28468: Size comparison from c4d95d0 to 4613d8f Increases above 0.2%:
Increases (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (39 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28468: Size comparison from c4d95d0 to 7f2cb6f Increases above 0.2%:
Increases (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (39 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A single fix to address. Otherwise good work
PR #28468: Size comparison from 07fa5bf to 3bb878a Decreases (3 builds for bl602, cc32xx, nrfconnect)
Full report (12 builds for bl602, bl702, bl702l, cc32xx, mbed, nrfconnect, qpg)
|
3bb878a
to
18288bb
Compare
PR #28468: Size comparison from 07fa5bf to 18288bb Increases (11 builds for bl602, bl702, efr32, k32w, psoc6, telink)
Decreases (11 builds for cc32xx, cyw30739, efr32, psoc6, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28468: Size comparison from 07fa5bf to 8806df8 Increases above 0.2%:
Increases (48 builds for bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
Decreases (53 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #28468: Size comparison from 07fa5bf to 809869d Increases above 0.2%:
Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #28468: Size comparison from 07fa5bf to 08a2da5 Increases above 0.2%:
Increases (47 builds for bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
Decreases (53 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve. Need to fix the hal later
…t-chip#28468) * Build Error fix for Window app on CSA for 917 SOC * Added Conditions for 917 SOC * Adds fix for 917SoC button and LED0 issue * Restyled by clang-format * Removed not required ifndef condition for 917 SOC * Removed OTA Requestor changes from scripts file * using release interrupt for button 1 * Restyled by clang-format --------- Co-authored-by: srningap <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Adds changes with respect to the clean up activity on #28160, adding missing conditions in order to compile applications for SiWx917SoC
Added fix for 917SoC LED0 and button fix for window app