-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented ExtractCDPExtensionCRLIssuerFromX509Cert() Helper Function #28345
Merged
mergify
merged 2 commits into
project-chip:master
from
emargolis:emargolis/feature/x509cert-extract-cdp-extension-crl-issuer
Jul 28, 2023
Merged
Implemented ExtractCDPExtensionCRLIssuerFromX509Cert() Helper Function #28345
mergify
merged 2 commits into
project-chip:master
from
emargolis:emargolis/feature/x509cert-extract-cdp-extension-crl-issuer
Jul 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extracts the cRLIssuer Name from the CDP extension pf the X509 ASN.1 Encoded Certificate - Only a single cRLIssuer DirectoryName is supported - The result is copied into buffer in a raw ASN.1 X.509 format - The result should be directly comparable with teh result of ExtractSubjectFromX509Cert() - Added OpenSSL, mbedTLS, TinyCrypt, and other implementations - Added CRLIssuer support to the CDP extension in the chip-cert tool - Generated new test vectors
PR #28345: Size comparison from 0085e7b to 4b1c2d5 Increases (15 builds for bl702, bl702l, cc32xx, esp32, nrfconnect, psoc6, telink)
Decreases (11 builds for bl702, cyw30739, efr32, linux, telink)
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26429