-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error messages on usage of command line #27559
Merged
mergify
merged 4 commits into
project-chip:master
from
andy31415:better_messages_for_py
Jun 30, 2023
Merged
Add error messages on usage of command line #27559
mergify
merged 4 commits into
project-chip:master
from
andy31415:better_messages_for_py
Jun 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Realistically we should have sane logic without overly verbose bits....
Such updates require more changes though. Updating now just for errors. |
PR #27559: Size comparison from a39e88a to 7ebf658 Increases (9 builds for bl702, cc32xx, psoc6, telink)
Decreases (13 builds for esp32, nrfconnect, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Jun 29, 2023
yufengwangca
approved these changes
Jun 29, 2023
tcarmelveilleux
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arguments for build_python are not intuitive, since normally when people what a clean env they expect just
-c
to work and not-c yes
.Added explicit checks so that we get: