-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32: Do not read the ap record if esp_wifi_scan_start() is not called by NetworkCommissioningDriver #27161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by NetworkCommissioningDriver
PR #27161: Size comparison from 530349a to a396f8b Increases (11 builds for bl702, cyw30739, esp32, k32w, telink)
Decreases (7 builds for bl602, psoc6, telink)
Full report (56 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
shubhamdp
approved these changes
Jun 9, 2023
bzbarsky-apple
approved these changes
Jun 9, 2023
PR #27161: Size comparison from 643f7aa to 6b0cbf3 Increases (9 builds for esp32, nrfconnect, psoc6, telink)
Decreases (11 builds for bl702, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jun 16, 2023
@wqx6 Can you please cherry-pick this to |
wqx6
added a commit
to wqx6/connectedhomeip
that referenced
this pull request
Jul 19, 2023
…ed by NetworkCommissioningDriver (project-chip#27161)
chshu
pushed a commit
to wqx6/connectedhomeip
that referenced
this pull request
Aug 22, 2023
…ed by NetworkCommissioningDriver (project-chip#27161)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If one calls esp_wifi_scan_start(), the NetworkCommissioningDriver will read the scanning results, then the results cannot be passed to the correct processing.
Changes
mpScanCallback
is NULL.