-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented ExtractCRLDistributionPointURIFromX509Cert() Helper Function #26913
Merged
mergify
merged 4 commits into
project-chip:master
from
emargolis:emargolis/feature/x509cert-extract-cdp-extension-dist-point
Jul 11, 2023
Merged
Implemented ExtractCRLDistributionPointURIFromX509Cert() Helper Function #26913
mergify
merged 4 commits into
project-chip:master
from
emargolis:emargolis/feature/x509cert-extract-cdp-extension-dist-point
Jul 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e0d5f02
to
305271a
Compare
PR #26913: Size comparison from 452d3b4 to 305271a Increases (15 builds for bl602, bl702, cc32xx, k32w, psoc6, telink)
Decreases (11 builds for bl702, nrfconnect, telink)
Full report (46 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
305271a
to
adfbd7f
Compare
PR #26913: Size comparison from fcf37c2 to adfbd7f Increases above 0.2%:
Increases (29 builds for bl602, bl702, bl702l, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Decreases (4 builds for bl702l, nrfconnect, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jul 7, 2023
- Extracts the CRL Distribution Point (CDP) extension from an X509 ASN.1 Encoded Certificate - The returned value only covers the URI of the CDP - Only a single URI distribution point GeneralName is supported - The valid URL should start with "http://" or "https://" - Added OpenSSL, mbedTLS, and TinyCrypt implementations - Added CDP extension support to the chip-cert tool - Added new test vectors
adfbd7f
to
24e4a6b
Compare
PR #26913: Size comparison from 488aabf to 24e4a6b Increases above 0.2%:
Increases (29 builds for bl602, bl702, bl702l, cc32xx, esp32, linux, psoc6, qpg, telink)
Decreases (11 builds for bl702, bl702l, efr32, nrfconnect, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Added documentation to clarify each step of the implementation.
24e4a6b
to
29919d9
Compare
PR #26913: Size comparison from 488aabf to 29919d9 Increases above 0.2%:
Increases (24 builds for bl702, bl702l, cc32xx, linux, psoc6, qpg, telink)
Decreases (7 builds for cyw30739, efr32, k32w, nrfconnect, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #26428