[python] update cached attributes incrementally #26774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple and
lazarkov
|
PR #26774: Size comparison from c24294a to 5240c21 Increases (8 builds for esp32, nrfconnect, psoc6, telink)
Decreases (12 builds for bl602, bl702, cc32xx, efr32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
The "REPL Tests - Linux" are good now, there is an issue with "Java Tests - Linux", but I don't think it is related to this PR. |
agners
force-pushed
the
make-python-attribute-cache-faster
branch
from
bbb59ed to
f194939
Compare
|
PR #26774: Size comparison from 41b1d61 to f194939 Increases (2 builds for esp32, psoc6)
Decreases (8 builds for bl602, bl702, cc32xx, cyw30739, efr32, psoc6)
Full report (42 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
marcelveldt
reviewed
May 24, 2023
marcelveldt
reviewed
May 24, 2023
|
PR #26774: Size comparison from 41b1d61 to bd20dcf Increases above 0.2%:
Increases (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for bl702, cc32xx, psoc6)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Instead of rebuilding the cache from scratch on every report, just update the Endpoint/Cluster/Attributes which actually changed. Obviously, this is significantly faster, especially for small updates.
Co-authored-by: Marcel van der Veldt <[email protected]>
agners
force-pushed
the
make-python-attribute-cache-faster
branch
from
bd20dcf to
6e6b201
Compare
|
PR #26774: Size comparison from 9f43988 to 6e6b201 Increases (10 builds for bl602, bl702, cyw30739, esp32, psoc6, telink)
Decreases (9 builds for cc32xx, cyw30739, efr32, esp32, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #26774: Size comparison from 5728039 to a1632ca Increases (12 builds for bl602, bl702, cc32xx, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (6 builds for efr32, esp32, telink)
Full report (58 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
Changes look good, but I think we don't really have any tests that actually validate data in the cache. Could you add a few? |
It seems that some of the test relies on it, at least an earlier version of this PR showed "REPL Tests - Linux" issues. But a specific test for the cache itself would probably helpful to test the cache more specifically. |
tcarmelveilleux
approved these changes
Jun 4, 2023
Ideally, a unit test for the cache itself would be good to add. That would require you to add a bunch of logic to inject in TLV for specific objects and prove that the cache is indeed behaving the way it should be. Alternatively, you could also add a test to |
I went down this road and implemented two test cases for this (for the Attribute-View and Cluster-View). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of rebuilding the cache from scratch on every report, just update the Endpoint/Cluster/Attributes which actually changed. Obviously, this is significantly faster, especially for small updates.