[devcontainer] Standalone build and update #26511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ATmobica
commented
May 11, 2023
ATmobica
commented
- Make the devcontainer image build a standalone script - add network host access for the building.
- Update dev container configuration.
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kcoppock,
kkasperczyk-no,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
nivi-apple,
saurabhst,
selissia,
sharadb-amazon,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
younghak-hwang,
yufengwangca and
yunhanw-google
andy31415
reviewed
May 11, 2023
ATmobica
force-pushed
the
upstream/vscode-dev-impr
branch
from
01f3e9c to
8658c8f
Compare
andy31415
approved these changes
May 12, 2023
ATmobica
force-pushed
the
upstream/vscode-dev-impr
branch
from
8658c8f to
7035ce3
Compare
This enable us to set --net=host for the image creation. This should avoid dns restrictions one may have on one's local network by giving the image the same network as the host. This is only for the image build, not for running the container. Signed-off-by: Yoan Picchi <[email protected]>
- Move deprecated configuration into correct section - Add mcu-debug.debug-tracker-vscode into extension list. This extension is required for cortex debug. Signed-off-by: Vincent Coubard <[email protected]>
ATmobica
force-pushed
the
upstream/vscode-dev-impr
branch
from
7035ce3 to
2b05540
Compare
tianfeng-yang
pushed a commit
to tianfeng-yang/connectedhomeip
that referenced
this pull request
May 17, 2023
* [vscode] Make the devcontainer image build a standalone script This enable us to set --net=host for the image creation. This should avoid dns restrictions one may have on one's local network by giving the image the same network as the host. This is only for the image build, not for running the container. Signed-off-by: Yoan Picchi <[email protected]> * [vscode] Update dev container configuration - Move deprecated configuration into correct section - Add mcu-debug.debug-tracker-vscode into extension list. This extension is required for cortex debug. Signed-off-by: Vincent Coubard <[email protected]> --------- Signed-off-by: Yoan Picchi <[email protected]> Signed-off-by: Vincent Coubard <[email protected]> Co-authored-by: Vincent Coubard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.