-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve session-management commands in chip-tool. #26404
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:better-session-commands
May 8, 2023
Merged
Improve session-management commands in chip-tool. #26404
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:better-session-commands
May 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bzbarsky-apple
commented
May 6, 2023
- Move them into a separate "sessionmanagement" bit, to make them more discoverable.
- Add a command to expire the local CASE sessions for a given node id.
- Rename close-session to send-close-session.
- Add an option to control whether send-close-session also expires the local session (defaulting to true).
PR #26404: Size comparison from c984f0b to 650e26b Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
* Move them into a separate "sessionmanagement" bit, to make them more discoverable. * Add a command to expire the local CASE sessions for a given node id. * Rename close-session to send-close-session. * Add an option to control whether send-close-session also expires the local session (defaulting to true).
650e26b
to
38ed5e0
Compare
PR #26404: Size comparison from c984f0b to 38ed5e0 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
ksperling-apple
approved these changes
May 7, 2023
examples/chip-tool/commands/session-management/CloseSessionCommand.h
Outdated
Show resolved
Hide resolved
andy31415
approved these changes
May 8, 2023
Co-authored-by: Karsten Sperling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.