-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove gn_bootstrap.sh #26335
Merged
Merged
Remove gn_bootstrap.sh #26335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #26335: Size comparison from 7be1954 to 06e23f4 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
06e23f4
to
c835514
Compare
PR #26335: Size comparison from 7be1954 to c835514 Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
May 2, 2023
arkq
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file was misleading because it actually runs
activate.sh
and it is generally a shell that just invokes another shell.Now we run actual bootstrap for CI rather than activate.sh, which should ensure an up to date environment and avoid warnings of 'bootstrap done on a different machine'
It looks like the penalty of running a full bootstrap instead of activate.sh is about 80 seconds. While this is better than the old 5+ minutes of bootstrap, it is still somewhat slower with the benefit of likely a more "correct" build environment.