Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the GetWiFiBssId signature safer. #26088

Merged
merged 3 commits into from
Apr 14, 2023
Merged

Make the GetWiFiBssId signature safer. #26088

merged 3 commits into from
Apr 14, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

The existing signature relied on the implementation keeping around a static-lifetime buffer holding the data. Some implementations did this right, some did not.

The fix is to just have the caller provide the buffer.

@bzbarsky-apple
Make the GetWiFiBssId signature safer.
8799e91 
The existing signature relied on the implementation keeping around a
static-lifetime buffer holding the data.  Some implementations did this right,
some did not.

The fix is to just have the caller provide the buffer.
@github-actions
Copy link

PR #26088: Size comparison from a235160 to 8799e91

Increases (1 build for cc32xx)
platform target config section a235160 8799e91 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20326060 20327052 992 0.0
.debug_line 2687403 2687476 73 0.0
.debug_loc 2838361 2838789 428 0.0
Decreases (1 build for cc32xx)
platform target config section a235160 8799e91 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_str 3042379 3042053 -326 -0.0
.strtab 377626 377625 -1 -0.0
Full report (1 build for cc32xx)
platform target config section a235160 8799e91 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643081 643081 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87760 87760 0 0.0
.debug_frame 302028 302028 0 0.0
.debug_info 20326060 20327052 992 0.0
.debug_line 2687403 2687476 73 0.0
.debug_loc 2838361 2838789 428 0.0
.debug_ranges 288040 288040 0 0.0
.debug_str 3042379 3042053 -326 -0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104393 104393 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377626 377625 -1 -0.0
.symtab 256832 256832 0 0.0
.text 536568 536568 0 0.0

@github-actions
Copy link

PR #26088: Size comparison from a235160 to b726ad1

Increases (1 build for cc32xx)
platform target config section a235160 b726ad1 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20326060 20327052 992 0.0
.debug_line 2687403 2687476 73 0.0
.debug_loc 2838361 2838789 428 0.0
Decreases (1 build for cc32xx)
platform target config section a235160 b726ad1 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_str 3042379 3042053 -326 -0.0
.strtab 377626 377625 -1 -0.0
Full report (1 build for cc32xx)
platform target config section a235160 b726ad1 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643081 643081 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87760 87760 0 0.0
.debug_frame 302028 302028 0 0.0
.debug_info 20326060 20327052 992 0.0
.debug_line 2687403 2687476 73 0.0
.debug_loc 2838361 2838789 428 0.0
.debug_ranges 288040 288040 0 0.0
.debug_str 3042379 3042053 -326 -0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104393 104393 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377626 377625 -1 -0.0
.symtab 256832 256832 0 0.0
.text 536568 536568 0 0.0

@github-actions
Copy link

PR #26088: Size comparison from a235160 to a83ac9d

Increases (1 build for cc32xx)
platform target config section a235160 a83ac9d change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20326060 20327052 992 0.0
.debug_line 2687403 2687476 73 0.0
.debug_loc 2838361 2838789 428 0.0
Decreases (1 build for cc32xx)
platform target config section a235160 a83ac9d change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_str 3042379 3042053 -326 -0.0
.strtab 377626 377625 -1 -0.0
Full report (2 builds for cc32xx, mbed)
platform target config section a235160 a83ac9d change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643081 643081 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 933224 933224 0 0.0
.debug_aranges 87760 87760 0 0.0
.debug_frame 302028 302028 0 0.0
.debug_info 20326060 20327052 992 0.0
.debug_line 2687403 2687476 73 0.0
.debug_loc 2838361 2838789 428 0.0
.debug_ranges 288040 288040 0 0.0
.debug_str 3042379 3042053 -326 -0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 104393 104393 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 377626 377625 -1 -0.0
.symtab 256832 256832 0 0.0
.text 536568 536568 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2466272 2466272 0 0.0
.bss 215960 215960 0 0.0
.data 5888 5888 0 0.0
.text 1428916 1428916 0 0.0

@andy31415 andy31415 merged commit fcb34b7 into project-chip:master Apr 14, 2023
@bzbarsky-apple bzbarsky-apple deleted the fix-bssid-getter branch April 14, 2023 18:50
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Apr 14, 2023
@bzbarsky-apple
Fix boufallolab build.
4c5ba21 
Merge conflict between
project-chip#26099 and
project-chip#26088 led to things not
building.
@bzbarsky-apple bzbarsky-apple mentioned this pull request Apr 14, 2023
Merged
andy31415 pushed a commit that referenced this pull request Apr 14, 2023
@bzbarsky-apple
Fix boufallolab build. (#26108)
beb75fc 
Merge conflict between
#26099 and
#26088 led to things not
building.
@bzbarsky-apple bzbarsky-apple mentioned this pull request Apr 19, 2023
Closed
@hyunuktak hyunuktak mentioned this pull request Apr 19, 2023
Merged
@Damian-Nordic Damian-Nordic mentioned this pull request Apr 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@cliffamzn cliffamzn Awaiting requested review from cliffamzn

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo joonhaengHeo is a code owner

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

Assignees
No one assigned
Labels
app esp32 linux nrf connect platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bzbarsky-apple @tcarmelveilleux @jmartinez-silabs @jtung-apple @andy31415