Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update simulated README and fix gn_build_test_example template path. #25661

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Update simulated README and fix gn_build_test_example template path. #25661

merged 1 commit into from
Mar 20, 2023

Conversation

krypton36
Copy link
Contributor

  • Update simulated README on updated instructions to build
  • Update simulated README on updated instruction in generating tests
  • Update correct path in gn_build_test_example script

@github-actions github-actions bot added documentation Improvements or additions to documentation scripts labels Mar 13, 2023
@github-actions
Copy link

PR #25661: Size comparison from 768b3dd to 83448be

Increases (1 build for cc32xx)
platform target config section 768b3dd 83448be change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20245938 20245939 1 0.0
Full report (1 build for cc32xx)
platform target config section 768b3dd 83448be change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645097 645097 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20245938 20245939 1 0.0
.debug_line 2660971 2660971 0 0.0
.debug_loc 2804896 2804896 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026947 3026947 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 379204 379204 0 0.0
.symtab 256912 256912 0 0.0
.text 536984 536984 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krypton36 Note the restyle failures.

docs/guides/simulated_device_linux.md Outdated Show resolved Hide resolved
cliffamzn
cliffamzn requested changes Mar 13, 2023
View reviewed changes
docs/guides/simulated_device_linux.md Outdated Show resolved Hide resolved
@github-actions
Copy link

PR #25661: Size comparison from 768b3dd to 21db375

Increases (1 build for cc32xx)
platform target config section 768b3dd 21db375 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20245938 20245940 2 0.0
Full report (1 build for cc32xx)
platform target config section 768b3dd 21db375 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645097 645097 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20245938 20245940 2 0.0
.debug_line 2660971 2660971 0 0.0
.debug_loc 2804896 2804896 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026947 3026947 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105993 105993 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 379204 379204 0 0.0
.symtab 256912 256912 0 0.0
.text 536984 536984 0 0.0

@krypton36 krypton36 force-pushed the UpdateSimulatedAppReadme branch from 21db375 to 8bad72c Compare March 15, 2023 17:39
@krypton36 krypton36 force-pushed the UpdateSimulatedAppReadme branch from 2934cd0 to 488451c Compare March 15, 2023 17:43
@github-actions
Copy link

PR #25661: Size comparison from 346a817 to 488451c

Increases (1 build for cc32xx)
platform target config section 346a817 488451c change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20245969 20245970 1 0.0
Full report (1 build for cc32xx)
platform target config section 346a817 488451c change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 645489 645489 0 0.0
(read/write) 203848 203848 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197248 197248 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930293 930293 0 0.0
.debug_aranges 87384 87384 0 0.0
.debug_frame 300248 300248 0 0.0
.debug_info 20245969 20245970 1 0.0
.debug_line 2660979 2660979 0 0.0
.debug_loc 2804909 2804909 0 0.0
.debug_ranges 283168 283168 0 0.0
.debug_str 3026947 3026947 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106009 106009 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 380271 380271 0 0.0
.symtab 257312 257312 0 0.0
.text 537360 537360 0 0.0

@krypton36 krypton36 mentioned this pull request Mar 20, 2023
Closed
@andy31415 andy31415 merged commit f50e117 into project-chip:master Mar 20, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@krypton36
Update simulated README and fix gn_build_test_example template path. (p…
0aa8446 
…roject-chip#25661)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yufengwangca yufengwangca yufengwangca approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@cliffamzn cliffamzn cliffamzn approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@arkq arkq Awaiting requested review from arkq

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@joonhaengHeo joonhaengHeo Awaiting requested review from joonhaengHeo

@kcoppock kcoppock Awaiting requested review from kcoppock

@kkasperczyk-no kkasperczyk-no Awaiting requested review from kkasperczyk-no

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@sharadb-amazon sharadb-amazon Awaiting requested review from sharadb-amazon

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@younghak-hwang younghak-hwang Awaiting requested review from younghak-hwang

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@krypton36 @yufengwangca @bzbarsky-apple @cliffamzn @andy31415