Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong error code returned in BindingManager::NotifyBoundClusterCh… #24209

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Fix wrong error code returned in BindingManager::NotifyBoundClusterCh… #24209

merged 3 commits into from
Jan 12, 2023

Conversation

milanr-q
Copy link
Contributor

Fix wrong error code returned in BindingManager::NotifyBoundClusterChanged

@github-actions github-actions bot added the app label Dec 26, 2022
@github-actions
Copy link

github-actions bot commented Dec 26, 2022 •
edited
Loading

PR #24209: Size comparison from 19c8ea4 to 9ac74f8

Increases (12 builds for bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
platform target config section 19c8ea4 9ac74f8 change % change
bl702 lighting-app bl702 (read/write) 1196335 1196351 16 0.0
.debug_info 39187933 39187934 1 0.0
.text 956880 956882 2 0.0
bl702+rpc .debug_info 43480352 43480353 1 0.0
.text 1030860 1030862 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 171564 171572 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644131 644139 8 0.0
.text 564672 564680 8 0.0
lock-ftd LP_CC2652R7 (read/write) 171592 171600 8 0.0
pump-app LP_CC2652R7 (read/write) 159304 159312 8 0.0
esp32 all-clusters-app m5stack (read/write) 564183 564187 4 0.0
.flash.rodata 314176 314180 4 0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 759970 759974 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27060315 27060316 1 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26797113 26797114 1 0.0
light cy8ckit_062s2_43012 .debug_info 22259723 22259724 1 0.0
telink all-clusters-minimal-app tlsr9518adk80d text 691406 691408 2 0.0
Decreases (7 builds for bl602, cc13x2_26x2, psoc6, telink)
platform target config section 19c8ea4 9ac74f8 change % change
bl602 lighting-app bl602+rpc .text 1070616 1070614 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679883 679875 -8 -0.0
.text 589576 589568 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 677415 677407 -8 -0.0
.text 599520 599512 -8 -0.0
pump-app LP_CC2652R7 (read only) 690439 690431 -8 -0.0
.text 598924 598916 -8 -0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22478114 22478113 -1 -0.0
telink light-switch-app tlsr9518adk80d text 638032 638028 -4 -0.0
lighting-app tlsr9518adk80d text 703808 703806 -2 -0.0
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 19c8ea4 9ac74f8 change % change
bl602 lighting-app bl602 (read/write) 1356434 1356434 0 0.0
.bss 86977 86977 0 0.0
.data 9984 9984 0 0.0
.text 1039192 1039192 0 0.0
bl602+rpc (read/write) 1402218 1402218 0 0.0
.bss 95017 95017 0 0.0
.data 10384 10384 0 0.0
.text 1070616 1070614 -2 -0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1196335 1196351 16 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67102 67102 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1529044 1529044 0 0.0
.debug_aranges 132568 132568 0 0.0
.debug_frame 486476 486476 0 0.0
.debug_info 39187933 39187934 1 0.0
.debug_line 5150433 5150433 0 0.0
.debug_loc 3381394 3381394 0 0.0
.debug_ranges 363816 363816 0 0.0
.debug_str 3483437 3483437 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116400 116400 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 569377 569377 0 0.0
.symtab 172160 172160 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956880 956882 2 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1284827 1284827 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75118 75118 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1676376 1676376 0 0.0
.debug_aranges 140688 140688 0 0.0
.debug_frame 513896 513896 0 0.0
.debug_info 43480352 43480353 1 0.0
.debug_line 5539882 5539882 0 0.0
.debug_loc 3576086 3576086 0 0.0
.debug_ranges 387352 387352 0 0.0
.debug_str 3885835 3885835 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130144 130144 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 629661 629661 0 0.0
.symtab 190336 190336 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030860 1030862 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679883 679875 -8 -0.0
(read/write) 171564 171572 8 0.0
.bss 81140 81140 0 0.0
.data 3380 3380 0 0.0
.rodata 89995 89995 0 0.0
.text 589576 589568 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644131 644139 8 0.0
(read/write) 157916 157916 0 0.0
.bss 80420 80420 0 0.0
.data 3380 3380 0 0.0
.rodata 79139 79139 0 0.0
.text 564672 564680 8 0.0
lock-ftd LP_CC2652R7 (read only) 677415 677407 -8 -0.0
(read/write) 171592 171600 8 0.0
.bss 78788 78788 0 0.0
.data 3304 3304 0 0.0
.rodata 77415 77415 0 0.0
.text 599520 599512 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 662203 662203 0 0.0
(read/write) 182068 182068 0 0.0
.bss 74052 74052 0 0.0
.data 3304 3304 0 0.0
.rodata 103507 103507 0 0.0
.text 558216 558216 0 0.0
pump-app LP_CC2652R7 (read only) 690439 690431 -8 -0.0
(read/write) 159304 159312 8 0.0
.bss 78756 78756 0 0.0
.data 3296 3296 0 0.0
.rodata 91031 91031 0 0.0
.text 598924 598916 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 674363 674363 0 0.0
(read/write) 175484 175484 0 0.0
.bss 78860 78860 0 0.0
.data 3292 3292 0 0.0
.rodata 86587 86587 0 0.0
.text 587296 587296 0 0.0
shell LP_CC2652R7 (read only) 671106 671106 0 0.0
(read/write) 182668 182668 0 0.0
.bss 83468 83468 0 0.0
.data 3376 3376 0 0.0
.rodata 86738 86738 0 0.0
.text 584052 584052 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588482 588482 0 0.0
.app_xip_area 464828 464828 0 0.0
.bss 66112 66112 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592310 592310 0 0.0
.app_xip_area 463360 463360 0 0.0
.bss 71400 71400 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 551862 551862 0 0.0
.app_xip_area 433704 433704 0 0.0
.bss 60656 60656 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 976468 976468 0 0.0
.bss 152172 152172 0 0.0
.data 2168 2168 0 0.0
.text 822108 822108 0 0.0
BRD4161A+rs911x (read/write) 1038920 1038920 0 0.0
.bss 186648 186648 0 0.0
.data 2012 2012 0 0.0
.text 850240 850240 0 0.0
BRD4187C (read/write) 1149948 1149948 0 0.0
.bss 138568 138568 0 0.0
.data 2516 2516 0 0.0
.text 984268 984268 0 0.0
lock-app BRD4161A+wf200 (read/write) 1069152 1069152 0 0.0
.bss 158184 158184 0 0.0
.data 2020 2020 0 0.0
.text 908924 908924 0 0.0
window-app BRD4187C (read/write) 1142592 1142592 0 0.0
.bss 139984 139984 0 0.0
.data 2540 2540 0 0.0
.text 975472 975472 0 0.0
esp32 all-clusters-app c3devkit (read only) 1219474 1219474 0 0.0
(read/write) 1790954 1790954 0 0.0
.dram0.bss 76912 76912 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 248392 248392 0 0.0
.flash.text 1219474 1219474 0 0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1233407 1233407 0 0.0
(read/write) 564183 564187 4 0.0
.dram0.bss 82064 82064 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 314176 314180 4 0.0
.flash.text 1228023 1228023 0 0.0
.iram0.text 124803 124803 0 0.0
k32w contact k32w0+release (read/write) 662716 662716 0 0.0
.bss 77032 77032 0 0.0
.data 2104 2104 0 0.0
.text 564468 564468 0 0.0
light k32w0+release (read/write) 673400 673400 0 0.0
.bss 74824 74824 0 0.0
.data 2060 2060 0 0.0
.text 593788 593788 0 0.0
lock k32w0+release (read/write) 634244 634244 0 0.0
.bss 75584 75584 0 0.0
.data 2080 2080 0 0.0
.text 553852 553852 0 0.0
linux all-clusters-app debug (read only) 3114537 3114537 0 0.0
(read/write) 158600 158600 0 0.0
.bss 62464 62464 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 87240 87240 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 281611 281611 0 0.0
.text 2648242 2648242 0 0.0
all-clusters-minimal-app debug (read only) 2938137 2938137 0 0.0
(read/write) 150000 150000 0 0.0
.bss 61664 61664 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 79608 79608 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 281035 281035 0 0.0
.text 2475458 2475458 0 0.0
bridge-app debug (read only) 2497209 2497209 0 0.0
(read/write) 133120 133120 0 0.0
.bss 52544 52544 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 70696 70696 0 0.0
.dynamic 608 608 0 0.0
.got 4600 4600 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 212320 212320 0 0.0
.text 2113106 2113106 0 0.0
chip-tool debug (read only) 11182713 11182713 0 0.0
(read/write) 646808 646808 0 0.0
.bss 25912 25912 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 611568 611568 0 0.0
.dynamic 608 608 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 605029 605029 0 0.0
.text 9078820 9078820 0 0.0
chip-tool-ipv6only arm64 (read only) 10595932 10595932 0 0.0
(read/write) 695928 695928 0 0.0
.bss 33912 33912 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 640376 640376 0 0.0
.dynamic 560 560 0 0.0
.got 13832 13832 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 535180 535180 0 0.0
.text 8412948 8412948 0 0.0
lighting-app debug+rpc (read only) 2664337 2664337 0 0.0
(read/write) 132488 132488 0 0.0
.bss 49984 49984 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 74024 74024 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 228224 228224 0 0.0
.text 2259362 2259362 0 0.0
lock-app debug (read only) 2623465 2623465 0 0.0
(read/write) 127472 127472 0 0.0
.bss 48416 48416 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70936 70936 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244488 244488 0 0.0
.text 2207074 2207074 0 0.0
ota-provider-app debug (read only) 2197337 2197337 0 0.0
(read/write) 105904 105904 0 0.0
.bss 46592 46592 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 52120 52120 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 195784 195784 0 0.0
.text 1861650 1861650 0 0.0
ota-requestor-app debug (read only) 2358841 2358841 0 0.0
(read/write) 113952 113952 0 0.0
.bss 49088 49088 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 57208 57208 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 202512 202512 0 0.0
.text 2007426 2007426 0 0.0
shell debug (read only) 2646993 2646993 0 0.0
(read/write) 143064 143064 0 0.0
.bss 57864 57864 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78136 78136 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 239858 239858 0 0.0
.text 2247426 2247426 0 0.0
thermostat-no-ble arm64 (read only) 2478044 2478044 0 0.0
(read/write) 145016 145016 0 0.0
.bss 55336 55336 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 78640 78640 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 149560 149560 0 0.0
.text 2067888 2067888 0 0.0
tv-app debug (read only) 3286737 3286737 0 0.0
(read/write) 262312 262312 0 0.0
.bss 170808 170808 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80544 80544 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 268856 268856 0 0.0
.text 2823554 2823554 0 0.0
tv-casting-app debug (read only) 5645937 5645937 0 0.0
(read/write) 162672 162672 0 0.0
.bss 52184 52184 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101960 101960 0 0.0
.dynamic 608 608 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 359321 359321 0 0.0
.text 5009026 5009026 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463832 2463832 0 0.0
.bss 214932 214932 0 0.0
.data 5872 5872 0 0.0
.text 1426476 1426476 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1191003 1191003 0 0.0
bss 145205 145205 0 0.0
rodata 144544 144544 0 0.0
text 820134 820134 0 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1361266 1361266 0 0.0
bss 105144 105144 0 0.0
rodata 211640 211640 0 0.0
text 759970 759974 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136647 1136647 0 0.0
bss 144440 144440 0 0.0
rodata 120860 120860 0 0.0
text 790290 790290 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842056 842056 0 0.0
(read/write) 1749660 1749660 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188624 188624 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1238156 1238156 0 0.0
.debug_aranges 110768 110768 0 0.0
.debug_frame 371956 371956 0 0.0
.debug_info 27060315 27060316 1 0.0
.debug_line 3709696 3709696 0 0.0
.debug_loc 3624770 3624770 0 0.0
.debug_ranges 346584 346584 0 0.0
.debug_str 3453864 3453864 0 0.0
.heap 842056 842056 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 572205 572205 0 0.0
.symtab 422128 422128 0 0.0
.text 1549984 1549984 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842784 842784 0 0.0
(read/write) 1692188 1692188 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187896 187896 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1230047 1230047 0 0.0
.debug_aranges 110240 110240 0 0.0
.debug_frame 375012 375012 0 0.0
.debug_info 26797113 26797114 1 0.0
.debug_line 3728601 3728601 0 0.0
.debug_loc 3612376 3612376 0 0.0
.debug_ranges 345200 345200 0 0.0
.debug_str 3442876 3442876 0 0.0
.heap 842784 842784 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536294 536294 0 0.0
.symtab 408560 408560 0 0.0
.text 1493240 1493240 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850976 850976 0 0.0
(read/write) 1610404 1610404 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179912 179912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1064846 1064846 0 0.0
.debug_aranges 102440 102440 0 0.0
.debug_frame 345344 345344 0 0.0
.debug_info 22259723 22259724 1 0.0
.debug_line 3295718 3295718 0 0.0
.debug_loc 3310296 3310296 0 0.0
.debug_ranges 309336 309336 0 0.0
.debug_str 3248462 3248462 0 0.0
.heap 850976 850976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472619 472619 0 0.0
.symtab 376928 376928 0 0.0
.text 1419648 1419648 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845984 845984 0 0.0
(read/write) 1644356 1644356 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184888 184888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1066756 1066756 0 0.0
.debug_aranges 102824 102824 0 0.0
.debug_frame 347144 347144 0 0.0
.debug_info 22478114 22478113 -1 -0.0
.debug_line 3295604 3295604 0 0.0
.debug_loc 3331730 3331730 0 0.0
.debug_ranges 311192 311192 0 0.0
.debug_str 3264300 3264300 0 0.0
.heap 845984 845984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 475336 475336 0 0.0
.symtab 378928 378928 0 0.0
.text 1448608 1448608 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151236 1151236 0 0.0
.bss 100348 100348 0 0.0
.data 840 840 0 0.0
.text 598336 598336 0 0.0
lock-app qpg6105+debug (read/write) 1117556 1117556 0 0.0
.bss 95828 95828 0 0.0
.data 836 836 0 0.0
.text 564652 564652 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1071532 1071532 0 0.0
bss 98856 98856 0 0.0
text 726250 726250 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1010824 1010824 0 0.0
bss 98080 98080 0 0.0
text 691406 691408 2 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 932280 932280 0 0.0
bss 90320 90320 0 0.0
text 638032 638028 -4 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1010248 1010248 0 0.0
bss 98380 98380 0 0.0
text 703808 703806 -2 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 945884 945884 0 0.0
bss 91276 91276 0 0.0
text 649288 649288 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 935428 935428 0 0.0
bss 91712 91712 0 0.0
text 638716 638716 0 0.0

@github-actions
Copy link

github-actions bot commented Jan 9, 2023 •
edited
Loading

PR #24209: Size comparison from b953c0b to 63ee172

Increases (9 builds for linux, nrfconnect, psoc6, telink)
platform target config section b953c0b 63ee172 change % change
linux chip-tool-ipv6only arm64 (read only) 10667180 10667220 40 0.0
.rodata 550172 550196 24 0.0
.text 8481812 8481828 16 0.0
thermostat-no-ble arm64 (read only) 2478452 2478508 56 0.0
.rodata 149712 149752 40 0.0
.text 2068144 2068160 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 801930 801934 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_loc 3637422 3637423 1 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_loc 3625028 3625029 1 0.0
light cy8ckit_062s2_43012 .debug_info 22280234 22280235 1 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1070336 1070344 8 0.0
text 725624 725626 2 0.0
light-switch-app tlsr9518adk80d (read/write) 931032 931040 8 0.0
text 637382 637386 4 0.0
ota-requestor-app tlsr9518adk80d text 648630 648632 2 0.0
Decreases (9 builds for bl602, bl702, esp32, psoc6, qpg, telink)
platform target config section b953c0b 63ee172 change % change
bl602 lighting-app bl602 .text 1016648 1016646 -2 -0.0
bl602+rpc .text 1047342 1047340 -2 -0.0
bl702 lighting-app bl702 .debug_info 39725272 39725270 -2 -0.0
.text 957008 957004 -4 -0.0
esp32 all-clusters-app m5stack (read/write) 564267 564263 -4 -0.0
.flash.rodata 314260 314256 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27081520 27081518 -2 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26817885 26817883 -2 -0.0
lock cy8ckit_062s2_43012 .debug_info 22498899 22498898 -1 -0.0
qpg lock-app qpg6105+debug (read/write) 1116044 1116036 -8 -0.0
.text 563140 563132 -8 -0.0
telink all-clusters-minimal-app tlsr9518adk80d (read/write) 1009624 1009616 -8 -0.0
text 690770 690766 -4 -0.0
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section b953c0b 63ee172 change % change
bl602 lighting-app bl602 (read/write) 1330486 1330486 0 0.0
.bss 86926 86926 0 0.0
.data 9576 9576 0 0.0
.text 1016648 1016646 -2 -0.0
bl602+rpc (read/write) 1375694 1375694 0 0.0
.bss 94966 94966 0 0.0
.data 9976 9976 0 0.0
.text 1047342 1047340 -2 -0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195951 1195951 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 66590 66590 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1534627 1534627 0 0.0
.debug_aranges 132552 132552 0 0.0
.debug_frame 486644 486644 0 0.0
.debug_info 39725272 39725270 -2 -0.0
.debug_line 5219470 5219470 0 0.0
.debug_loc 3392838 3392838 0 0.0
.debug_ranges 371904 371904 0 0.0
.debug_str 3503565 3503565 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116400 116400 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 569353 569353 0 0.0
.symtab 172000 172000 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957008 957004 -4 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1288003 1288003 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 74622 74622 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4600 4600 0 0.0
.debug_abbrev 1682752 1682752 0 0.0
.debug_aranges 140680 140680 0 0.0
.debug_frame 514176 514176 0 0.0
.debug_info 44092236 44092236 0 0.0
.debug_line 5616003 5616003 0 0.0
.debug_loc 3588130 3588130 0 0.0
.debug_ranges 395512 395512 0 0.0
.debug_str 3906100 3906100 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130848 130848 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 629942 629942 0 0.0
.symtab 190336 190336 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1033804 1033804 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 678283 678283 0 0.0
(read/write) 173164 173164 0 0.0
.bss 81140 81140 0 0.0
.data 3380 3380 0 0.0
.rodata 89995 89995 0 0.0
.text 587976 587976 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 642643 642643 0 0.0
(read/write) 157916 157916 0 0.0
.bss 80420 80420 0 0.0
.data 3380 3380 0 0.0
.rodata 79139 79139 0 0.0
.text 563184 563184 0 0.0
lock-ftd LP_CC2652R7 (read only) 675711 675711 0 0.0
(read/write) 173296 173296 0 0.0
.bss 78788 78788 0 0.0
.data 3304 3304 0 0.0
.rodata 77415 77415 0 0.0
.text 597816 597816 0 0.0
lock-mtd LP_CC2652R7 (read only) 660811 660811 0 0.0
(read/write) 183460 183460 0 0.0
.bss 74052 74052 0 0.0
.data 3304 3304 0 0.0
.rodata 103507 103507 0 0.0
.text 556824 556824 0 0.0
pump-app LP_CC2652R7 (read only) 689015 689015 0 0.0
(read/write) 160728 160728 0 0.0
.bss 78756 78756 0 0.0
.data 3268 3268 0 0.0
.rodata 91103 91103 0 0.0
.text 597428 597428 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672811 672811 0 0.0
(read/write) 177036 177036 0 0.0
.bss 78860 78860 0 0.0
.data 3292 3292 0 0.0
.rodata 86587 86587 0 0.0
.text 585744 585744 0 0.0
shell LP_CC2652R7 (read only) 669530 669530 0 0.0
(read/write) 184244 184244 0 0.0
.bss 83468 83468 0 0.0
.data 3376 3376 0 0.0
.rodata 86738 86738 0 0.0
.text 582476 582476 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586850 586850 0 0.0
.app_xip_area 463196 463196 0 0.0
.bss 66112 66112 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590550 590550 0 0.0
.app_xip_area 461600 461600 0 0.0
.bss 71400 71400 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550710 550710 0 0.0
.app_xip_area 432544 432544 0 0.0
.bss 60664 60664 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 975124 975124 0 0.0
.bss 152172 152172 0 0.0
.data 2168 2168 0 0.0
.text 820764 820764 0 0.0
BRD4161A+rs911x (read/write) 1038320 1038320 0 0.0
.bss 186648 186648 0 0.0
.data 2012 2012 0 0.0
.text 849640 849640 0 0.0
BRD4187C (read/write) 1149004 1149004 0 0.0
.bss 138568 138568 0 0.0
.data 2516 2516 0 0.0
.text 983324 983324 0 0.0
lock-app BRD4161A+wf200 (read/write) 1067840 1067840 0 0.0
.bss 158184 158184 0 0.0
.data 2020 2020 0 0.0
.text 907612 907612 0 0.0
window-app BRD4187C (read/write) 1141808 1141808 0 0.0
.bss 139984 139984 0 0.0
.data 2540 2540 0 0.0
.text 974688 974688 0 0.0
esp32 all-clusters-app c3devkit (read only) 1219574 1219574 0 0.0
(read/write) 1791050 1791050 0 0.0
.dram0.bss 76912 76912 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 248488 248488 0 0.0
.flash.text 1219574 1219574 0 0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1233447 1233447 0 0.0
(read/write) 564267 564263 -4 -0.0
.dram0.bss 82064 82064 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 314260 314256 -4 -0.0
.flash.text 1228063 1228063 0 0.0
.iram0.text 124803 124803 0 0.0
k32w contact k32w0+release (read/write) 661356 661356 0 0.0
.bss 77032 77032 0 0.0
.data 2104 2104 0 0.0
.text 563108 563108 0 0.0
light k32w0+release (read/write) 672216 672216 0 0.0
.bss 74824 74824 0 0.0
.data 2060 2060 0 0.0
.text 592604 592604 0 0.0
lock k32w0+release (read/write) 632884 632884 0 0.0
.bss 75584 75584 0 0.0
.data 2080 2080 0 0.0
.text 552492 552492 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10667180 10667220 40 0.0
(read/write) 690504 690504 0 0.0
.bss 33912 33912 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 634856 634856 0 0.0
.dynamic 560 560 0 0.0
.got 13920 13920 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 550172 550196 24 0.0
.text 8481812 8481828 16 0.0
thermostat-no-ble arm64 (read only) 2478452 2478508 56 0.0
(read/write) 145016 145016 0 0.0
.bss 55336 55336 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 78640 78640 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 149712 149752 40 0.0
.text 2068144 2068160 16 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2462848 2462848 0 0.0
.bss 214932 214932 0 0.0
.data 5872 5872 0 0.0
.text 1425492 1425492 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1161587 1161587 0 0.0
bss 143621 143621 0 0.0
rodata 136176 136176 0 0.0
text 801930 801934 4 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1341494 1341494 0 0.0
bss 105132 105132 0 0.0
rodata 204040 204040 0 0.0
text 747796 747796 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1108091 1108091 0 0.0
bss 142856 142856 0 0.0
rodata 112504 112504 0 0.0
text 772932 772932 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 842056 842056 0 0.0
(read/write) 1749268 1749268 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188624 188624 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1243463 1243463 0 0.0
.debug_aranges 110840 110840 0 0.0
.debug_frame 372300 372300 0 0.0
.debug_info 27081520 27081518 -2 -0.0
.debug_line 3735193 3735193 0 0.0
.debug_loc 3637422 3637423 1 0.0
.debug_ranges 355584 355584 0 0.0
.debug_str 3459152 3459152 0 0.0
.heap 842056 842056 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 572577 572577 0 0.0
.symtab 422416 422416 0 0.0
.text 1549592 1549592 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 842784 842784 0 0.0
(read/write) 1691908 1691908 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187896 187896 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1235244 1235244 0 0.0
.debug_aranges 110312 110312 0 0.0
.debug_frame 375356 375356 0 0.0
.debug_info 26817885 26817883 -2 -0.0
.debug_line 3754091 3754091 0 0.0
.debug_loc 3625028 3625029 1 0.0
.debug_ranges 354200 354200 0 0.0
.debug_str 3448164 3448164 0 0.0
.heap 842784 842784 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536666 536666 0 0.0
.symtab 408688 408688 0 0.0
.text 1492960 1492960 0 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 850976 850976 0 0.0
(read/write) 1609916 1609916 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179912 179912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1068633 1068633 0 0.0
.debug_aranges 102512 102512 0 0.0
.debug_frame 345688 345688 0 0.0
.debug_info 22280234 22280235 1 0.0
.debug_line 3320126 3320126 0 0.0
.debug_loc 3325256 3325256 0 0.0
.debug_ranges 318336 318336 0 0.0
.debug_str 3253750 3253750 0 0.0
.heap 850976 850976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472991 472991 0 0.0
.symtab 377184 377184 0 0.0
.text 1419160 1419160 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 845984 845984 0 0.0
(read/write) 1643932 1643932 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184888 184888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1070433 1070433 0 0.0
.debug_aranges 102896 102896 0 0.0
.debug_frame 347488 347488 0 0.0
.debug_info 22498899 22498898 -1 -0.0
.debug_line 3321289 3321289 0 0.0
.debug_loc 3346814 3346814 0 0.0
.debug_ranges 320192 320192 0 0.0
.debug_str 3269588 3269588 0 0.0
.heap 845984 845984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 475708 475708 0 0.0
.symtab 379008 379008 0 0.0
.text 1448184 1448184 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149556 1149556 0 0.0
.bss 100348 100348 0 0.0
.data 840 840 0 0.0
.text 596656 596656 0 0.0
lock-app qpg6105+debug (read/write) 1116044 1116036 -8 -0.0
.bss 95828 95828 0 0.0
.data 836 836 0 0.0
.text 563140 563132 -8 -0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1070336 1070344 8 0.0
bss 98268 98268 0 0.0
text 725624 725626 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1009624 1009616 -8 -0.0
bss 97488 97488 0 0.0
text 690770 690766 -4 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 914532 914532 0 0.0
bss 89644 89644 0 0.0
text 622844 622844 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 931032 931040 8 0.0
bss 89736 89736 0 0.0
text 637382 637386 4 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1009000 1009000 0 0.0
bss 97796 97796 0 0.0
text 703160 703160 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 944624 944624 0 0.0
bss 90688 90688 0 0.0
text 648630 648632 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 934192 934192 0 0.0
bss 91124 91124 0 0.0
text 638082 638082 0 0.0

bzbarsky-apple
bzbarsky-apple approved these changes Jan 9, 2023
View reviewed changes
src/lib/core/CHIPError.h Show resolved Hide resolved
src/lib/core/CHIPError.h Outdated Show resolved Hide resolved
@andy31415 andy31415 merged commit c982db7 into project-chip:master Jan 12, 2023
@milanr-q milanr-q deleted the SDP011-1280 branch January 17, 2023 10:43
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@milanr-q
Fix wrong error code returned in BindingManager::NotifyBoundClusterCh… (
d055f08 
project-chip#24209)

* Fix wrong error code returned in BindingManager::NotifyBoundClusterChanged

* Review remarks addressed

* Error description changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app core lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@milanr-q @andy31415 @bzbarsky-apple @Damian-Nordic