Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix code gen for Bitmap types #23707

Merged
merged 2 commits into from
Nov 22, 2022
Merged

fix code gen for Bitmap types #23707

merged 2 commits into from
Nov 22, 2022

Conversation

bndkk
Copy link
Contributor

@bndkk bndkk commented Nov 21, 2022 •
edited by andy31415
Loading

Fixes #23706

We expect ZCL_BITMAP8_ATTRIBUTE_TYPE to be used for attribute types instead of ZCL_LEVELCONTROLOPTIONS_ATTRIBUTE_TYPE (i.e. need to get the underlying type of the bitmap rather than assuming bitmap is its own type).

@CLAassistant
Copy link

CLAassistant commented Nov 21, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

github-actions bot commented Nov 21, 2022 •
edited
Loading

PR #23707: Size comparison from 669cd47 to 093453d

Increases (9 builds for bl602, cc13x2_26x2, cyw30739, esp32, psoc6, telink)
platform target config section 669cd47 093453d change % change
bl602 lighting-app bl602+rpc (read/write) 1423310 1423318 8 0.0
.text 1092654 1092658 4 0.0
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read only) 674027 674035 8 0.0
.text 587120 587128 8 0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544770 544778 8 0.0
.app_xip_area 426500 426508 8 0.0
esp32 all-clusters-app c3devkit (read only) 1214662 1214664 2 0.0
.flash.text 1214662 1214664 2 0.0
m5stack (read/write) 562636 562644 8 0.0
.flash.rodata 313608 313616 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27020981 27020982 1 0.0
lock cy8ckit_062s2_43012 .debug_info 22446758 22446759 1 0.0
telink all-clusters-minimal-app tlsr9518adk80d text 614238 614242 4 0.0
ota-requestor-app tlsr9518adk80d text 566670 566672 2 0.0
Decreases (4 builds for cc13x2_26x2, cyw30739, esp32, telink)
platform target config section 669cd47 093453d change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read/write) 175908 175900 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588334 588326 -8 -0.0
.app_xip_area 464544 464536 -8 -0.0
esp32 all-clusters-app c3devkit (read/write) 1786670 1786662 -8 -0.0
.flash.rodata 256496 256488 -8 -0.0
telink all-clusters-app tlsr9518adk80d (read/write) 939076 939068 -8 -0.0
text 650286 650284 -2 -0.0
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 669cd47 093453d change % change
bl602 lighting-app bl602 (read/write) 1377446 1377446 0 0.0
.bss 90041 90041 0 0.0
.data 9984 9984 0 0.0
.text 1061184 1061184 0 0.0
bl602+rpc (read/write) 1423310 1423318 8 0.0
.bss 98081 98081 0 0.0
.data 10376 10376 0 0.0
.text 1092654 1092658 4 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1196871 1196871 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67166 67166 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1524270 1524270 0 0.0
.debug_aranges 132424 132424 0 0.0
.debug_frame 485832 485832 0 0.0
.debug_info 39167890 39167890 0 0.0
.debug_line 5276251 5276251 0 0.0
.debug_loc 3373401 3373401 0 0.0
.debug_ranges 361248 361248 0 0.0
.debug_str 3474852 3474852 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116680 116680 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 568355 568355 0 0.0
.symtab 172048 172048 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957062 957062 0 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1285395 1285395 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75214 75214 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1668440 1668440 0 0.0
.debug_aranges 140520 140520 0 0.0
.debug_frame 513168 513168 0 0.0
.debug_info 43440662 43440662 0 0.0
.debug_line 5673645 5673645 0 0.0
.debug_loc 3568012 3568012 0 0.0
.debug_ranges 384768 384768 0 0.0
.debug_str 3872449 3872449 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130424 130424 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 628505 628505 0 0.0
.symtab 190192 190192 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1031040 1031040 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679571 679571 0 0.0
(read/write) 171964 171964 0 0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89923 89923 0 0.0
.text 589336 589336 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643827 643827 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 79059 79059 0 0.0
.text 564448 564448 0 0.0
lock-ftd LP_CC2652R7 (read only) 677183 677183 0 0.0
(read/write) 171920 171920 0 0.0
.bss 78884 78884 0 0.0
.data 3304 3304 0 0.0
.rodata 77351 77351 0 0.0
.text 599352 599352 0 0.0
lock-mtd LP_CC2652R7 (read only) 661963 661963 0 0.0
(read/write) 182396 182396 0 0.0
.bss 74140 74140 0 0.0
.data 3304 3304 0 0.0
.rodata 103435 103435 0 0.0
.text 558048 558048 0 0.0
pump-app LP_CC2652R7 (read only) 690055 690055 0 0.0
(read/write) 159784 159784 0 0.0
.bss 78852 78852 0 0.0
.data 3296 3296 0 0.0
.rodata 90871 90871 0 0.0
.text 598700 598700 0 0.0
pump-controller-app LP_CC2652R7 (read only) 674027 674035 8 0.0
(read/write) 175908 175900 -8 -0.0
.bss 78948 78948 0 0.0
.data 3292 3292 0 0.0
.rodata 86427 86427 0 0.0
.text 587120 587128 8 0.0
shell LP_CC2652R7 (read only) 670790 670790 0 0.0
(read/write) 183064 183064 0 0.0
.bss 83548 83548 0 0.0
.data 3376 3376 0 0.0
.rodata 86670 86670 0 0.0
.text 583804 583804 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588334 588326 -8 -0.0
.app_xip_area 464544 464536 -8 -0.0
.bss 66208 66208 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592098 592098 0 0.0
.app_xip_area 463012 463012 0 0.0
.bss 71496 71496 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544770 544778 8 0.0
.app_xip_area 426500 426508 8 0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 975820 975820 0 0.0
.bss 152260 152260 0 0.0
.data 2168 2168 0 0.0
.text 821372 821372 0 0.0
BRD4161A+rs911x (read/write) 1036720 1036720 0 0.0
.bss 186736 186736 0 0.0
.data 2012 2012 0 0.0
.text 847948 847948 0 0.0
BRD4187C (read/write) 1148544 1148544 0 0.0
.bss 138656 138656 0 0.0
.data 2516 2516 0 0.0
.text 982776 982776 0 0.0
lock-app BRD4161A+wf200 (read/write) 1161360 1161360 0 0.0
.bss 158264 158264 0 0.0
.data 2020 2020 0 0.0
.text 1001052 1001052 0 0.0
window-app BRD4187C (read/write) 1141268 1141268 0 0.0
.bss 140072 140072 0 0.0
.data 2540 2540 0 0.0
.text 974060 974060 0 0.0
esp32 all-clusters-app c3devkit (read only) 1214662 1214664 2 0.0
(read/write) 1786670 1786662 -8 -0.0
.dram0.bss 76688 76688 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 256496 256488 -8 -0.0
.flash.text 1214662 1214664 2 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1225427 1225427 0 0.0
(read/write) 562636 562644 8 0.0
.dram0.bss 82064 82064 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 313608 313616 8 0.0
.flash.text 1220043 1220043 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 662692 662692 0 0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 564364 564364 0 0.0
light k32w0+release (read/write) 673224 673224 0 0.0
.bss 74912 74912 0 0.0
.data 2060 2060 0 0.0
.text 593524 593524 0 0.0
lock k32w0+release (read/write) 634252 634252 0 0.0
.bss 75672 75672 0 0.0
.data 2080 2080 0 0.0
.text 553772 553772 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10448364 10448364 0 0.0
(read/write) 707697 707697 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 651984 651984 0 0.0
.dynamic 560 560 0 0.0
.got 13944 13944 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 519324 519324 0 0.0
.text 8270468 8270468 0 0.0
thermostat-no-ble arm64 (read only) 2387012 2387012 0 0.0
(read/write) 143665 143665 0 0.0
.bss 55329 55329 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 145068 145068 0 0.0
.text 1998048 1998048 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2453656 2453656 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1416300 1416300 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1189583 1189583 0 0.0
bss 145285 145285 0 0.0
rodata 144804 144804 0 0.0
text 818414 818414 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1168963 1168963 0 0.0
bss 144512 144512 0 0.0
rodata 136592 136592 0 0.0
text 806936 806936 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1748228 1748228 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1235661 1235661 0 0.0
.debug_aranges 110744 110744 0 0.0
.debug_frame 371588 371588 0 0.0
.debug_info 27020981 27020982 1 0.0
.debug_line 3691677 3691677 0 0.0
.debug_loc 3616499 3616499 0 0.0
.debug_ranges 341008 341008 0 0.0
.debug_str 3444213 3444213 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 571950 571950 0 0.0
.symtab 421904 421904 0 0.0
.text 1548464 1548464 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1690748 1690748 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1227552 1227552 0 0.0
.debug_aranges 110216 110216 0 0.0
.debug_frame 374668 374668 0 0.0
.debug_info 26758662 26758662 0 0.0
.debug_line 3712661 3712661 0 0.0
.debug_loc 3604105 3604105 0 0.0
.debug_ranges 339624 339624 0 0.0
.debug_str 3433225 3433225 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536039 536039 0 0.0
.symtab 408336 408336 0 0.0
.text 1491720 1491720 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850888 850888 0 0.0
(read/write) 1608924 1608924 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180000 180000 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1062079 1062079 0 0.0
.debug_aranges 102416 102416 0 0.0
.debug_frame 344980 344980 0 0.0
.debug_info 22227198 22227198 0 0.0
.debug_line 3281782 3281782 0 0.0
.debug_loc 3301540 3301540 0 0.0
.debug_ranges 304904 304904 0 0.0
.debug_str 3238811 3238811 0 0.0
.heap 850888 850888 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472364 472364 0 0.0
.symtab 376704 376704 0 0.0
.text 1418080 1418080 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1642436 1642436 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1064054 1064054 0 0.0
.debug_aranges 102816 102816 0 0.0
.debug_frame 346832 346832 0 0.0
.debug_info 22446758 22446759 1 0.0
.debug_line 3276610 3276610 0 0.0
.debug_loc 3323117 3323117 0 0.0
.debug_ranges 306288 306288 0 0.0
.debug_str 3255068 3255068 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474151 474151 0 0.0
.symtab 378368 378368 0 0.0
.text 1446600 1446600 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1152096 1152096 0 0.0
.bss 111116 111116 0 0.0
.data 848 848 0 0.0
.text 599196 599196 0 0.0
lock-app qpg6105+debug (read/write) 1117600 1117600 0 0.0
.bss 106564 106564 0 0.0
.data 836 836 0 0.0
.text 564696 564696 0 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 939076 939068 -8 -0.0
bss 81620 81620 0 0.0
noinit 43440 43440 0 0.0
text 650286 650284 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 877036 877036 0 0.0
bss 80844 80844 0 0.0
noinit 43440 43440 0 0.0
text 614238 614242 4 0.0
light-switch-app tlsr9518adk80d (read/write) 792000 792000 0 0.0
bss 72468 72468 0 0.0
noinit 43520 43520 0 0.0
text 555310 555310 0 0.0
lighting-app tlsr9518adk80d (read/write) 876576 876576 0 0.0
bss 82232 82232 0 0.0
noinit 43520 43520 0 0.0
text 625622 625622 0 0.0
ota-requestor-app tlsr9518adk80d (read/write) 806468 806468 0 0.0
bss 74040 74040 0 0.0
noinit 43520 43520 0 0.0
text 566670 566672 2 0.0

@andy31415 andy31415 merged commit a9caf9e into project-chip:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - pending scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Platform] Code generation bug for dynamic bridge example
3 participants
@bndkk @CLAassistant @andy31415