Fix race when trying to use Darwin callback bridge from action block. #23553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have some callback bridge action blocks that need access to the bridge itself. Since the action block was queued to run on a different thread from inside the bridge constructor, it could race with the bridge constructor finishing execution, leading to unexpected behavior (including possibly destruction of the bridge before its constructor finishes executing. Switch to running the action block after the bridge is constructed.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
rgoliver and
robszewczyk
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #23553: Size comparison from e6901ac to bd268f1 Increases (11 builds for bl602, bl702, esp32, psoc6, qpg, telink)
Decreases (4 builds for esp32, nrfconnect, psoc6)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Nov 9, 2022
vivien-apple
approved these changes
Nov 9, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…project-chip#23553) We have some callback bridge action blocks that need access to the bridge itself. Since the action block was queued to run on a different thread from inside the bridge constructor, it could race with the bridge constructor finishing execution, leading to unexpected behavior (including possibly destruction of the bridge before its constructor finishes executing. Switch to running the action block after the bridge is constructed.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…project-chip#23553) We have some callback bridge action blocks that need access to the bridge itself. Since the action block was queued to run on a different thread from inside the bridge constructor, it could race with the bridge constructor finishing execution, leading to unexpected behavior (including possibly destruction of the bridge before its constructor finishes executing. Switch to running the action block after the bridge is constructed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have some callback bridge action blocks that need access to the bridge itself. Since the action block was queued to run on a different thread from inside the bridge constructor, it could race with the bridge constructor finishing execution, leading to unexpected behavior (including possibly destruction of the bridge before its constructor finishes executing).
Switch to running the action block after the bridge is constructed.