Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various miscellaneous Darwin API issues. #23447

Merged
merged 3 commits into from
Nov 4, 2022
Merged

Fix various miscellaneous Darwin API issues. #23447

merged 3 commits into from
Nov 4, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

This is a re-landing of PR #22574.

  • Rename readAttributeWithEndpointID to readAttributePathWithEndpointID
  • Document readAttributePathWithEndpointID
  • Rename subscribeAttributeWithEndpointID to subscribeAttributePathWithEndpointID
  • Document subscribeAttributePathWithEndpointID
  • Switch various things from "strong" to "copy" for paths, reports, etc.
  • Remove redundant "nonnull" declarations on properties.
  • Create typedefs for the NSData representations of certificates, for readability
  • Replace "(nullable X *)" with "(X * _Nullable)" in various places.
  • Fix various documentation.
  • Rename "failSafeExpiryTimeoutSecs" to "failSafeExpiryTimeout".

The nullable to _Nullable change we might want to undo, but keeping it for now to make re-landing other PRs that were on top of #22574 easier.

The header changes not accompanied by backwards-compat shims are OK for the following reasons:

  • The changes to MTRBaseDevice.h are all to MTR_NEWLY_AVAILABLE APIs or fixing obvious API bugs (replacing "strong" with "copy").
  • MTRBaseDevice_Internal.h is not public API.
  • The changes to MTRCertificates.h are all to MTR_NEWLY_AVAILABLE APIs or are source+binary compatible.
  • The changes to MTRCluster.h are source+binary compatible.
  • MTRCluster_internal.h is not public API.
  • The changes to MTRDeviceController.h are source+binary compatible.
  • The changes to MTRDeviceControllerStartupParams.h are source+binary compatible.
  • MTRDeviceControllerStartupParams_Internal.h is not public API.
  • The changes to MTRDevicePairingDelegate.h are source+binary compatible.
  • The changes to MTRError.h are source+binary compatible.
  • MTRError_Internal.h is not public API.
  • The changes to MTRManualSetupPayloadParser.h are source+binary compatible.
  • The changes to MTROnboardingPayloadParser.h are source+binary compatible.
  • The changes to MTRPersistentStorageDelegate.h are source+binary compatible.
  • The changes to MTRQRCodeSetupPayloadParser.h are source+binary compatible.
  • The changes to MTRSetupPayload.h are source+binary compatible.
  • The changes to MTRThreadOperationalDataset.h are source+binary compatible.
  • The changes to MTRBaseClusters.h are source+binary compatible.
  • The changes to MTRClusters.h are source+binary compatible.
  • The changes to MTRCommandPayloadsObjc.h are source+binary compatible.
  • The changes to MTRStructsObjc.h are source+binary compatible.

@github-actions
Copy link

github-actions bot commented Nov 2, 2022 •
edited
Loading

PR #23447: Size comparison from 3518760 to e5dc97a

Increases (6 builds for bl602, cc13x2_26x2, esp32, psoc6)
platform target config section 3518760 e5dc97a change % change
bl602 lighting-app bl602 .text 1069810 1069812 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677863 677871 8 0.0
.text 587664 587672 8 0.0
esp32 all-clusters-app c3devkit (read/write) 1788470 1788478 8 0.0
.flash.rodata 258024 258032 8 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27004566 27004567 1 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26741196 26741197 1 0.0
lock cy8ckit_062s2_43012 .debug_info 22435925 22435926 1 0.0
Decreases (6 builds for bl602, bl702, cc13x2_26x2, cyw30739, telink)
platform target config section 3518760 e5dc97a change % change
bl602 lighting-app bl602+rpc (read/write) 1435982 1435974 -8 -0.0
.text 1101418 1101416 -2 -0.0
bl702 lighting-app bl702 .debug_info 38069052 38069051 -1 -0.0
.text 957782 957780 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 173696 173688 -8 -0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544482 544474 -8 -0.0
.app_xip_area 426148 426140 -8 -0.0
telink all-clusters-app tlsr9518adk80d text 648770 648768 -2 -0.0
lighting-app tlsr9518adk80d text 624256 624254 -2 -0.0
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 3518760 e5dc97a change % change
bl602 lighting-app bl602 (read/write) 1390518 1390518 0 0.0
.bss 90745 90745 0 0.0
.data 9936 9936 0 0.0
.text 1069810 1069812 2 0.0
bl602+rpc (read/write) 1435982 1435974 -8 -0.0
.bss 98177 98177 0 0.0
.data 10320 10320 0 0.0
.text 1101418 1101416 -2 -0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1189323 1189323 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67134 67134 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4280 4280 0 0.0
.debug_abbrev 1513290 1513290 0 0.0
.debug_aranges 132064 132064 0 0.0
.debug_frame 484444 484444 0 0.0
.debug_info 38069052 38069051 -1 -0.0
.debug_line 5262950 5262950 0 0.0
.debug_loc 3366388 3366388 0 0.0
.debug_ranges 358072 358072 0 0.0
.debug_str 3451656 3451656 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116616 116616 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565981 565981 0 0.0
.symtab 171984 171984 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957782 957780 -2 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1285251 1285251 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75166 75166 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4816 4816 0 0.0
.debug_abbrev 1650704 1650704 0 0.0
.debug_aranges 139568 139568 0 0.0
.debug_frame 509816 509816 0 0.0
.debug_info 41985158 41985158 0 0.0
.debug_line 5638684 5638684 0 0.0
.debug_loc 3559215 3559215 0 0.0
.debug_ranges 380872 380872 0 0.0
.debug_str 3847784 3847784 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130024 130024 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 625154 625154 0 0.0
.symtab 189792 189792 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1031486 1031486 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677863 677871 8 0.0
(read/write) 173696 173688 -8 -0.0
.bss 81252 81252 0 0.0
.data 3380 3380 0 0.0
.rodata 89887 89887 0 0.0
.text 587664 587672 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 642119 642119 0 0.0
(read/write) 158020 158020 0 0.0
.bss 80524 80524 0 0.0
.data 3380 3380 0 0.0
.rodata 79023 79023 0 0.0
.text 562776 562776 0 0.0
lock-ftd LP_CC2652R7 (read only) 676379 676379 0 0.0
(read/write) 172316 172316 0 0.0
.bss 78476 78476 0 0.0
.data 3304 3304 0 0.0
.rodata 77411 77411 0 0.0
.text 598488 598488 0 0.0
lock-mtd LP_CC2652R7 (read only) 660167 660167 0 0.0
(read/write) 184216 184216 0 0.0
.bss 74164 74164 0 0.0
.data 3304 3304 0 0.0
.rodata 103263 103263 0 0.0
.text 556424 556424 0 0.0
pump-app LP_CC2652R7 (read only) 688635 688635 0 0.0
(read/write) 160796 160796 0 0.0
.bss 78444 78444 0 0.0
.data 3296 3296 0 0.0
.rodata 90859 90859 0 0.0
.text 597292 597292 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672911 672911 0 0.0
(read/write) 176616 176616 0 0.0
.bss 78540 78540 0 0.0
.data 3292 3292 0 0.0
.rodata 86407 86407 0 0.0
.text 586024 586024 0 0.0
shell LP_CC2652R7 (read only) 668906 668906 0 0.0
(read/write) 184972 184972 0 0.0
.bss 83572 83572 0 0.0
.data 3376 3376 0 0.0
.rodata 86594 86594 0 0.0
.text 581996 581996 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588542 588542 0 0.0
.app_xip_area 465128 465128 0 0.0
.bss 65832 65832 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592590 592590 0 0.0
.app_xip_area 463880 463880 0 0.0
.bss 71120 71120 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544482 544474 -8 -0.0
.app_xip_area 426148 426140 -8 -0.0
.bss 60800 60800 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974732 974732 0 0.0
.bss 152276 152276 0 0.0
.data 2248 2248 0 0.0
.text 820188 820188 0 0.0
BRD4161A+rs911x (read/write) 1034672 1034672 0 0.0
.bss 186744 186744 0 0.0
.data 2092 2092 0 0.0
.text 845812 845812 0 0.0
BRD4187C (read/write) 1146720 1146720 0 0.0
.bss 138664 138664 0 0.0
.data 2596 2596 0 0.0
.text 980864 980864 0 0.0
lock-app BRD4161A+wf200 (read/write) 1160424 1160424 0 0.0
.bss 158272 158272 0 0.0
.data 2100 2100 0 0.0
.text 1000032 1000032 0 0.0
window-app BRD4187C (read/write) 1139940 1139940 0 0.0
.bss 140080 140080 0 0.0
.data 2620 2620 0 0.0
.text 972644 972644 0 0.0
esp32 all-clusters-app c3devkit (read only) 1223970 1223970 0 0.0
(read/write) 1788470 1788478 8 0.0
.dram0.bss 76960 76960 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 258024 258032 8 0.0
.flash.text 1223970 1223970 0 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1234039 1234039 0 0.0
(read/write) 564396 564396 0 0.0
.dram0.bss 82336 82336 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 315096 315096 0 0.0
.flash.text 1228655 1228655 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 661676 661676 0 0.0
.bss 77040 77040 0 0.0
.data 2104 2104 0 0.0
.text 563420 563420 0 0.0
light k32w0+release (read/write) 672008 672008 0 0.0
.bss 74840 74840 0 0.0
.data 2060 2060 0 0.0
.text 592380 592380 0 0.0
lock k32w0+release (read/write) 633484 633484 0 0.0
.bss 75600 75600 0 0.0
.data 2080 2080 0 0.0
.text 553076 553076 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10436348 10436348 0 0.0
(read/write) 706465 706465 0 0.0
.bss 33953 33953 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650720 650720 0 0.0
.dynamic 560 560 0 0.0
.got 13928 13928 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518220 518220 0 0.0
.text 8262292 8262292 0 0.0
thermostat-no-ble arm64 (read only) 2392844 2392844 0 0.0
(read/write) 143665 143665 0 0.0
.bss 55377 55377 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77280 77280 0 0.0
.dynamic 560 560 0 0.0
.got 5184 5184 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144548 144548 0 0.0
.text 2005296 2005296 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452768 2452768 0 0.0
.bss 215028 215028 0 0.0
.data 5872 5872 0 0.0
.text 1415412 1415412 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1188191 1188191 0 0.0
bss 145301 145301 0 0.0
rodata 144836 144836 0 0.0
text 816996 816996 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1167475 1167475 0 0.0
bss 144528 144528 0 0.0
rodata 136576 136576 0 0.0
text 805334 805334 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841952 841952 0 0.0
(read/write) 1745940 1745940 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188728 188728 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1234891 1234891 0 0.0
.debug_aranges 110736 110736 0 0.0
.debug_frame 371220 371220 0 0.0
.debug_info 27004566 27004567 1 0.0
.debug_line 3679399 3679399 0 0.0
.debug_loc 3588816 3588816 0 0.0
.debug_ranges 337968 337968 0 0.0
.debug_str 3435414 3435414 0 0.0
.heap 841952 841952 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570487 570487 0 0.0
.symtab 421760 421760 0 0.0
.text 0 0 0 0.0
1546160 1546160 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842688 842688 0 0.0
(read/write) 1688548 1688548 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187992 187992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1226734 1226734 0 0.0
.debug_aranges 110208 110208 0 0.0
.debug_frame 374300 374300 0 0.0
.debug_info 26741196 26741197 1 0.0
.debug_line 3700375 3700375 0 0.0
.debug_loc 3576453 3576453 0 0.0
.debug_ranges 336584 336584 0 0.0
.debug_str 3424443 3424443 0 0.0
.heap 842688 842688 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 534576 534576 0 0.0
.symtab 408192 408192 0 0.0
.text 1489504 1489504 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850872 850872 0 0.0
(read/write) 1607004 1607004 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180016 180016 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1061195 1061195 0 0.0
.debug_aranges 102408 102408 0 0.0
.debug_frame 344616 344616 0 0.0
.debug_info 22202548 22202548 0 0.0
.debug_line 3269633 3269633 0 0.0
.debug_loc 3274179 3274179 0 0.0
.debug_ranges 301880 301880 0 0.0
.debug_str 3229870 3229870 0 0.0
.heap 850872 850872 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 470901 470901 0 0.0
.symtab 376576 376576 0 0.0
.text 1416144 1416144 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845880 845880 0 0.0
(read/write) 1640780 1640780 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184992 184992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1063170 1063170 0 0.0
.debug_aranges 102808 102808 0 0.0
.debug_frame 346488 346488 0 0.0
.debug_info 22435925 22435926 1 0.0
.debug_line 3266531 3266531 0 0.0
.debug_loc 3301773 3301773 0 0.0
.debug_ranges 303824 303824 0 0.0
.debug_str 3249341 3249341 0 0.0
.heap 845880 845880 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473304 473304 0 0.0
.symtab 378256 378256 0 0.0
.text 1444928 1444928 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149968 1149968 0 0.0
.bss 110612 110612 0 0.0
.data 848 848 0 0.0
.text 597068 597068 0 0.0
lock-app qpg6105+debug (read/write) 1114760 1114760 0 0.0
.bss 106388 106388 0 0.0
.data 836 836 0 0.0
.text 561856 561856 0 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 937348 937348 0 0.0
bss 81632 81632 0 0.0
noinit 43440 43440 0 0.0
text 648770 648768 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 875156 875156 0 0.0
bss 80856 80856 0 0.0
noinit 43440 43440 0 0.0
text 612606 612606 0 0.0
light-switch-app tlsr9518adk80d (read/write) 790820 790820 0 0.0
bss 72480 72480 0 0.0
noinit 43520 43520 0 0.0
text 554266 554266 0 0.0
lighting-app tlsr9518adk80d (read/write) 875052 875052 0 0.0
bss 82248 82248 0 0.0
noinit 43520 43520 0 0.0
text 624256 624254 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 804952 804952 0 0.0
bss 74052 74052 0 0.0
noinit 43520 43520 0 0.0
text 565286 565286 0 0.0

ksperling-apple
ksperling-apple reviewed Nov 3, 2022
View reviewed changes
@bzbarsky-apple bzbarsky-apple mentioned this pull request Nov 3, 2022
Open
@bzbarsky-apple
Fix various miscellaneous Darwin API issues.
a817c67 
This is a re-landing of PR project-chip#22574.

* Rename readAttributeWithEndpointID to readAttributePathWithEndpointID
* Document readAttributePathWithEndpointID
* Rename subscribeAttributeWithEndpointID to subscribeAttributePathWithEndpointID
* Document subscribeAttributePathWithEndpointID
* Switch various things from "strong" to "copy" for paths, reports, etc.
* Remove redundant "nonnull" declarations on properties.
* Create typedefs for the NSData representations of certificates, for readability
* Replace "(nullable X *)" with "(X * _Nullable)" in various places.
* Fix various documentation.
* Rename "failSafeExpiryTimeoutSecs" to "failSafeExpiryTimeout".

The nullable to _Nullable change we might want to undo, but keeping it for now
to make re-landing other PRs that were on top of project-chip#22574 easier.

The header changes not accompanied by backwards-compat shims are OK for the
following reasons:

* The changes to MTRBaseDevice.h are all to MTR_NEWLY_AVAILABLE APIs or fixing
  obvious API bugs (replacing "strong" with "copy").
* MTRBaseDevice_Internal.h is not public API.
* The changes to MTRCertificates.h are all to MTR_NEWLY_AVAILABLE APIs or are
  source+binary compatible.
* The changes to MTRCluster.h are source+binary compatible.
* MTRCluster_internal.h is not public API.
* The changes to MTRDeviceController.h are source+binary compatible.
* The changes to MTRDeviceControllerStartupParams.h are source+binary
  compatible.
* MTRDeviceControllerStartupParams_Internal.h is not public API.
* The changes to MTRDevicePairingDelegate.h are source+binary compatible.
* The changes to MTRError.h are source+binary compatible.
* MTRError_Internal.h is not public API.
* The changes to MTRManualSetupPayloadParser.h are source+binary compatible.
* The changes to MTROnboardingPayloadParser.h are source+binary compatible.
* The changes to MTRPersistentStorageDelegate.h are source+binary compatible.
* The changes to MTRQRCodeSetupPayloadParser.h are source+binary compatible.
* The changes to MTRSetupPayload.h are source+binary compatible.
* The changes to MTRThreadOperationalDataset.h are source+binary compatible.
* The changes to MTRBaseClusters.h are source+binary compatible.
* The changes to MTRClusters.h are source+binary compatible.
* The changes to MTRCommandPayloadsObjc.h are source+binary compatible.
* The changes to MTRStructsObjc.h are source+binary compatible.
@bzbarsky-apple
Fix review comment.
c261789
@bzbarsky-apple
Address review comments.
f20b0cc
@github-actions
Copy link

github-actions bot commented Nov 4, 2022 •
edited
Loading

PR #23447: Size comparison from 42b4438 to f20b0cc

Increases (9 builds for bl602, bl702, cyw30739, esp32, nrfconnect, psoc6, telink)
platform target config section 42b4438 f20b0cc change % change
bl602 lighting-app bl602 .text 1068758 1068760 2 0.0
bl702 lighting-app bl702 (read/write) 1188147 1188163 16 0.0
.debug_info 38087204 38087205 1 0.0
.text 957072 957074 2 0.0
bl702+rpc .debug_info 42004558 42004560 2 0.0
.text 1030778 1030782 4 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 592310 592318 8 0.0
.app_xip_area 463616 463624 8 0.0
esp32 all-clusters-app m5stack (read/write) 564332 564340 8 0.0
.flash.rodata 315048 315056 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 816964 816968 4 0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22461401 22461403 2 0.0
telink all-clusters-app tlsr9518adk80d text 648606 648608 2 0.0
all-clusters-minimal-app tlsr9518adk80d text 612578 612580 2 0.0
Decreases (3 builds for bl602, psoc6, telink)
platform target config section 42b4438 f20b0cc change % change
bl602 lighting-app bl602+rpc (read/write) 1434454 1434446 -8 -0.0
.text 1100362 1100360 -2 -0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22228026 22228025 -1 -0.0
telink lighting-app tlsr9518adk80d text 624084 624082 -2 -0.0
Full report (44 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 42b4438 f20b0cc change % change
bl602 lighting-app bl602 (read/write) 1388990 1388990 0 0.0
.bss 90729 90729 0 0.0
.data 9936 9936 0 0.0
.text 1068758 1068760 2 0.0
bl602+rpc (read/write) 1434454 1434446 -8 -0.0
.bss 98161 98161 0 0.0
.data 10320 10320 0 0.0
.text 1100362 1100360 -2 -0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1188147 1188163 16 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67126 67126 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4280 4280 0 0.0
.debug_abbrev 1514492 1514492 0 0.0
.debug_aranges 132064 132064 0 0.0
.debug_frame 484664 484664 0 0.0
.debug_info 38087204 38087205 1 0.0
.debug_line 5271085 5271085 0 0.0
.debug_loc 3373269 3373269 0 0.0
.debug_ranges 359744 359744 0 0.0
.debug_str 3451959 3451959 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116168 116168 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 565774 565774 0 0.0
.symtab 171984 171984 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957072 957074 2 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1284075 1284075 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75158 75158 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4816 4816 0 0.0
.debug_abbrev 1651926 1651926 0 0.0
.debug_aranges 139568 139568 0 0.0
.debug_frame 510036 510036 0 0.0
.debug_info 42004558 42004560 2 0.0
.debug_line 5647232 5647232 0 0.0
.debug_loc 3566096 3566096 0 0.0
.debug_ranges 382544 382544 0 0.0
.debug_str 3848087 3848087 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129560 129560 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624947 624947 0 0.0
.symtab 189792 189792 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030778 1030782 4 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588270 588270 0 0.0
.app_xip_area 464872 464872 0 0.0
.bss 65816 65816 0 0.0
.data 760 760 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592310 592318 8 0.0
.app_xip_area 463616 463624 8 0.0
.bss 71104 71104 0 0.0
.data 768 768 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 544402 544402 0 0.0
.app_xip_area 426084 426084 0 0.0
.bss 60784 60784 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974252 974252 0 0.0
.bss 152260 152260 0 0.0
.data 2248 2248 0 0.0
.text 819724 819724 0 0.0
BRD4161A+rs911x (read/write) 1034792 1034792 0 0.0
.bss 186728 186728 0 0.0
.data 2092 2092 0 0.0
.text 845948 845948 0 0.0
BRD4187C (read/write) 1146656 1146656 0 0.0
.bss 138648 138648 0 0.0
.data 2596 2596 0 0.0
.text 980816 980816 0 0.0
lock-app BRD4161A+wf200 (read/write) 1160072 1160072 0 0.0
.bss 158256 158256 0 0.0
.data 2100 2100 0 0.0
.text 999692 999692 0 0.0
window-app BRD4187C (read/write) 1139876 1139876 0 0.0
.bss 140064 140064 0 0.0
.data 2620 2620 0 0.0
.text 972596 972596 0 0.0
esp32 all-clusters-app c3devkit (read only) 1224290 1224290 0 0.0
(read/write) 1788526 1788526 0 0.0
.dram0.bss 76944 76944 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 258096 258096 0 0.0
.flash.text 1224290 1224290 0 0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1234091 1234091 0 0.0
(read/write) 564332 564340 8 0.0
.dram0.bss 82320 82320 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 315048 315056 8 0.0
.flash.text 1228707 1228707 0 0.0
.iram0.text 123939 123939 0 0.0
k32w contact k32w0+release (read/write) 661212 661212 0 0.0
.bss 77024 77024 0 0.0
.data 2104 2104 0 0.0
.text 562972 562972 0 0.0
light k32w0+release (read/write) 671256 671256 0 0.0
.bss 74824 74824 0 0.0
.data 2060 2060 0 0.0
.text 591644 591644 0 0.0
lock k32w0+release (read/write) 632732 632732 0 0.0
.bss 75584 75584 0 0.0
.data 2080 2080 0 0.0
.text 552340 552340 0 0.0
linux all-clusters-app debug (read only) 3088105 3088105 0 0.0
(read/write) 158352 158352 0 0.0
.bss 62464 62464 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 87016 87016 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 281291 281291 0 0.0
.text 2622450 2622450 0 0.0
all-clusters-minimal-app debug (read only) 2913913 2913913 0 0.0
(read/write) 149784 149784 0 0.0
.bss 61664 61664 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 79384 79384 0 0.0
.dynamic 608 608 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 1168 1168 0 0.0
.rodata 280811 280811 0 0.0
.text 2451682 2451682 0 0.0
bridge-app debug+rpc (read only) 2413737 2413737 0 0.0
(read/write) 129552 129552 0 0.0
.bss 51008 51008 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 68680 68680 0 0.0
.dynamic 608 608 0 0.0
.got 4600 4600 0 0.0
.init 27 27 0 0.0
.init_array 840 840 0 0.0
.rodata 211104 211104 0 0.0
.text 2035106 2035106 0 0.0
chip-tool debug (read only) 11082657 11082657 0 0.0
(read/write) 658408 658408 0 0.0
.bss 25912 25912 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 623080 623080 0 0.0
.dynamic 608 608 0 0.0
.got 5216 5216 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 592253 592253 0 0.0
.text 8966484 8966484 0 0.0
chip-tool-ipv6only arm64 (read only) 10438300 10438300 0 0.0
(read/write) 706417 706417 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 650720 650720 0 0.0
.dynamic 560 560 0 0.0
.got 13928 13928 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 518364 518364 0 0.0
.text 8264100 8264100 0 0.0
lighting-app debug+rpc (read only) 2641089 2641089 0 0.0
(read/write) 132240 132240 0 0.0
.bss 49984 49984 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 73800 73800 0 0.0
.dynamic 608 608 0 0.0
.got 4600 4600 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 227968 227968 0 0.0
.text 2237170 2237170 0 0.0
lock-app debug (read only) 2603209 2603209 0 0.0
(read/write) 127288 127288 0 0.0
.bss 48416 48416 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70728 70728 0 0.0
.dynamic 608 608 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 912 912 0 0.0
.rodata 244200 244200 0 0.0
.text 2187426 2187426 0 0.0
ota-provider-app debug (read only) 2399729 2399729 0 0.0
(read/write) 120816 120816 0 0.0
.bss 47936 47936 0 0.0
.data 2128 2128 0 0.0
.data.rel.ro 64648 64648 0 0.0
.dynamic 608 608 0 0.0
.got 4696 4696 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 216776 216776 0 0.0
.text 2014434 2014434 0 0.0
ota-requestor-app debug (read only) 2564865 2564865 0 0.0
(read/write) 129128 129128 0 0.0
.bss 50464 50464 0 0.0
.data 2496 2496 0 0.0
.data.rel.ro 69992 69992 0 0.0
.dynamic 608 608 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 223856 223856 0 0.0
.text 2163394 2163394 0 0.0
shell debug (read only) 2624377 2624377 0 0.0
(read/write) 142880 142880 0 0.0
.bss 57864 57864 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 77936 77936 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 239602 239602 0 0.0
.text 2225394 2225394 0 0.0
thermostat-no-ble arm64 (read only) 2394748 2394748 0 0.0
(read/write) 143649 143649 0 0.0
.bss 55361 55361 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77280 77280 0 0.0
.dynamic 560 560 0 0.0
.got 5176 5176 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 144548 144548 0 0.0
.text 2007216 2007216 0 0.0
tv-app debug (read only) 3234673 3234673 0 0.0
(read/write) 261616 261616 0 0.0
.bss 170552 170552 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80144 80144 0 0.0
.dynamic 608 608 0 0.0
.got 4976 4976 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 267640 267640 0 0.0
.text 2773954 2773954 0 0.0
tv-casting-app debug (read only) 5582745 5582745 0 0.0
(read/write) 161728 161728 0 0.0
.bss 52120 52120 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101096 101096 0 0.0
.dynamic 608 608 0 0.0
.got 4888 4888 0 0.0
.init 27 27 0 0.0
.init_array 1056 1056 0 0.0
.rodata 355481 355481 0 0.0
.text 4952162 4952162 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2452224 2452224 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1414868 1414868 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1187759 1187759 0 0.0
bss 145285 145285 0 0.0
rodata 144436 144436 0 0.0
text 816964 816968 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1167123 1167123 0 0.0
bss 144512 144512 0 0.0
rodata 136224 136224 0 0.0
text 805458 805458 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841968 841968 0 0.0
(read/write) 1746036 1746036 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1235810 1235810 0 0.0
.debug_aranges 110736 110736 0 0.0
.debug_frame 371344 371344 0 0.0
.debug_info 2702594 2702594 0 0.0
.debug_line 3685828 3685828 0 0.0
.debug_loc 3603682 3603682 0 0.0
.debug_ranges 339560 339560 0 0.0
.debug_str 3435682 3435682 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 570280 570280 0 0.0
.symtab 421424 421424 0 0.0
.text 1546272 1546272 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1688644 1688644 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1227653 1227653 0 0.0
.debug_aranges 110208 110208 0 0.0
.debug_frame 374424 374424 0 0.0
.debug_info 26762577 26762577 0 0.0
.debug_line 3706812 3706812 0 0.0
.debug_loc 3591319 3591319 0 0.0
.debug_ranges 338176 338176 0 0.0
.debug_str 3424711 3424711 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 534369 534369 0 0.0
.symtab 407856 407856 0 0.0
.text 1489616 1489616 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850888 850888 0 0.0
(read/write) 1606972 1606972 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180000 180000 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1062114 1062114 0 0.0
.debug_aranges 102408 102408 0 0.0
.debug_frame 344740 344740 0 0.0
.debug_info 22228026 22228025 -1 -0.0
.debug_line 3276154 3276154 0 0.0
.debug_loc 3289030 3289030 0 0.0
.debug_ranges 303472 303472 0 0.0
.debug_str 3230138 3230138 0 0.0
.heap 850888 850888 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 470694 470694 0 0.0
.symtab 376240 376240 0 0.0
.text 1416128 1416128 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845896 845896 0 0.0
(read/write) 1640764 1640764 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184976 184976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1064089 1064089 0 0.0
.debug_aranges 102808 102808 0 0.0
.debug_frame 346612 346612 0 0.0
.debug_info 22461401 22461403 2 0.0
.debug_line 3273048 3273048 0 0.0
.debug_loc 3316624 3316624 0 0.0
.debug_ranges 305416 305416 0 0.0
.debug_str 3249609 3249609 0 0.0
.heap 845896 845896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473097 473097 0 0.0
.symtab 377920 377920 0 0.0
.text 1444928 1444928 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149520 1149520 0 0.0
.bss 110596 110596 0 0.0
.data 848 848 0 0.0
.text 596620 596620 0 0.0
lock-app qpg6105+debug (read/write) 1114312 1114312 0 0.0
.bss 106372 106372 0 0.0
.data 836 836 0 0.0
.text 561408 561408 0 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 936772 936772 0 0.0
bss 81616 81616 0 0.0
noinit 43440 43440 0 0.0
text 648606 648608 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 874748 874748 0 0.0
bss 80840 80840 0 0.0
noinit 43440 43440 0 0.0
text 612578 612580 2 0.0
light-switch-app tlsr9518adk80d (read/write) 790244 790244 0 0.0
bss 72464 72464 0 0.0
noinit 43520 43520 0 0.0
text 554106 554106 0 0.0
lighting-app tlsr9518adk80d (read/write) 874460 874460 0 0.0
bss 82232 82232 0 0.0
noinit 43520 43520 0 0.0
text 624084 624082 -2 -0.0
ota-requestor-app tlsr9518adk80d (read/write) 804736 804736 0 0.0
bss 74036 74036 0 0.0
noinit 43520 43520 0 0.0
text 565486 565486 0 0.0

@bzbarsky-apple
Copy link
Contributor Author

Fast-tracking platform change with platform owner review.

@bzbarsky-apple bzbarsky-apple enabled auto-merge (squash) November 4, 2022 05:36
@bzbarsky-apple bzbarsky-apple merged commit d066463 into project-chip:master Nov 4, 2022
@bzbarsky-apple bzbarsky-apple deleted the darwin-reland-PR-22574 branch November 4, 2022 06:18
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@bzbarsky-apple @adbridge
Fix various miscellaneous Darwin API issues. (project-chip#23447)
d974dd7 
* Fix various miscellaneous Darwin API issues.

This is a re-landing of PR project-chip#22574.

* Rename readAttributeWithEndpointID to readAttributePathWithEndpointID
* Document readAttributePathWithEndpointID
* Rename subscribeAttributeWithEndpointID to subscribeAttributePathWithEndpointID
* Document subscribeAttributePathWithEndpointID
* Switch various things from "strong" to "copy" for paths, reports, etc.
* Remove redundant "nonnull" declarations on properties.
* Create typedefs for the NSData representations of certificates, for readability
* Replace "(nullable X *)" with "(X * _Nullable)" in various places.
* Fix various documentation.
* Rename "failSafeExpiryTimeoutSecs" to "failSafeExpiryTimeout".

The nullable to _Nullable change we might want to undo, but keeping it for now
to make re-landing other PRs that were on top of project-chip#22574 easier.

The header changes not accompanied by backwards-compat shims are OK for the
following reasons:

* The changes to MTRBaseDevice.h are all to MTR_NEWLY_AVAILABLE APIs or fixing
  obvious API bugs (replacing "strong" with "copy").
* MTRBaseDevice_Internal.h is not public API.
* The changes to MTRCertificates.h are all to MTR_NEWLY_AVAILABLE APIs or are
  source+binary compatible.
* The changes to MTRCluster.h are source+binary compatible.
* MTRCluster_internal.h is not public API.
* The changes to MTRDeviceController.h are source+binary compatible.
* The changes to MTRDeviceControllerStartupParams.h are source+binary
  compatible.
* MTRDeviceControllerStartupParams_Internal.h is not public API.
* The changes to MTRDevicePairingDelegate.h are source+binary compatible.
* The changes to MTRError.h are source+binary compatible.
* MTRError_Internal.h is not public API.
* The changes to MTRManualSetupPayloadParser.h are source+binary compatible.
* The changes to MTROnboardingPayloadParser.h are source+binary compatible.
* The changes to MTRPersistentStorageDelegate.h are source+binary compatible.
* The changes to MTRQRCodeSetupPayloadParser.h are source+binary compatible.
* The changes to MTRSetupPayload.h are source+binary compatible.
* The changes to MTRThreadOperationalDataset.h are source+binary compatible.
* The changes to MTRBaseClusters.h are source+binary compatible.
* The changes to MTRClusters.h are source+binary compatible.
* The changes to MTRCommandPayloadsObjc.h are source+binary compatible.
* The changes to MTRStructsObjc.h are source+binary compatible.

* Fix review comment.

* Address review comments.
adbridge pushed a commit to ARM-software/connectedhomeip that referenced this pull request Nov 18, 2022
@bzbarsky-apple @adbridge
Fix various miscellaneous Darwin API issues. (project-chip#23447)
e947cec 
* Fix various miscellaneous Darwin API issues.

This is a re-landing of PR project-chip#22574.

* Rename readAttributeWithEndpointID to readAttributePathWithEndpointID
* Document readAttributePathWithEndpointID
* Rename subscribeAttributeWithEndpointID to subscribeAttributePathWithEndpointID
* Document subscribeAttributePathWithEndpointID
* Switch various things from "strong" to "copy" for paths, reports, etc.
* Remove redundant "nonnull" declarations on properties.
* Create typedefs for the NSData representations of certificates, for readability
* Replace "(nullable X *)" with "(X * _Nullable)" in various places.
* Fix various documentation.
* Rename "failSafeExpiryTimeoutSecs" to "failSafeExpiryTimeout".

The nullable to _Nullable change we might want to undo, but keeping it for now
to make re-landing other PRs that were on top of project-chip#22574 easier.

The header changes not accompanied by backwards-compat shims are OK for the
following reasons:

* The changes to MTRBaseDevice.h are all to MTR_NEWLY_AVAILABLE APIs or fixing
  obvious API bugs (replacing "strong" with "copy").
* MTRBaseDevice_Internal.h is not public API.
* The changes to MTRCertificates.h are all to MTR_NEWLY_AVAILABLE APIs or are
  source+binary compatible.
* The changes to MTRCluster.h are source+binary compatible.
* MTRCluster_internal.h is not public API.
* The changes to MTRDeviceController.h are source+binary compatible.
* The changes to MTRDeviceControllerStartupParams.h are source+binary
  compatible.
* MTRDeviceControllerStartupParams_Internal.h is not public API.
* The changes to MTRDevicePairingDelegate.h are source+binary compatible.
* The changes to MTRError.h are source+binary compatible.
* MTRError_Internal.h is not public API.
* The changes to MTRManualSetupPayloadParser.h are source+binary compatible.
* The changes to MTROnboardingPayloadParser.h are source+binary compatible.
* The changes to MTRPersistentStorageDelegate.h are source+binary compatible.
* The changes to MTRQRCodeSetupPayloadParser.h are source+binary compatible.
* The changes to MTRSetupPayload.h are source+binary compatible.
* The changes to MTRThreadOperationalDataset.h are source+binary compatible.
* The changes to MTRBaseClusters.h are source+binary compatible.
* The changes to MTRClusters.h are source+binary compatible.
* The changes to MTRCommandPayloadsObjc.h are source+binary compatible.
* The changes to MTRStructsObjc.h are source+binary compatible.

* Fix review comment.

* Address review comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@jtung-apple jtung-apple jtung-apple approved these changes

@ksperling-apple ksperling-apple ksperling-apple approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
darwin examples fast track review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @andy31415 @jtung-apple @ksperling-apple