-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fabric-scoped and fabric-sensitive updates for IDL #22955
Merged
andy31415
merged 23 commits into
project-chip:master
from
andy31415:fabric_sensitive_in_idl
Oct 4, 2022
Merged
Fabric-scoped and fabric-sensitive updates for IDL #22955
andy31415
merged 23 commits into
project-chip:master
from
andy31415:fabric_sensitive_in_idl
Oct 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sitive (if applicable)
PR #22955: Size comparison from baff1a7 to 4889d92 Increases (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (12 builds for bl702, cc13x2_26x2, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #22955: Size comparison from b60caa4 to 576175e Increases (6 builds for bl602, cc13x2_26x2, efr32, esp32, nrfconnect, psoc6)
Decreases (5 builds for bl702, cc13x2_26x2, nrfconnect, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
576175e
to
e3c01e3
Compare
PR #22955: Size comparison from 2a1f9ef to e3c01e3 Increases (4 builds for bl702, cc13x2_26x2, esp32, nrfconnect)
Decreases (3 builds for bl602, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #22955: Size comparison from 92504fc to e02cae0 Increases (14 builds for bl602, bl702, cc13x2_26x2, linux, nrfconnect, psoc6, qpg, telink)
Decreases (10 builds for bl702, cc13x2_26x2, esp32, psoc6, qpg)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Oct 3, 2022
mrjerryjohns
approved these changes
Oct 3, 2022
PR #22955: Size comparison from 92504fc to 5694333 Increases (16 builds for bl602, bl702, cc13x2_26x2, linux, nrfconnect, psoc6, qpg, telink)
Decreases (7 builds for bl702, cc13x2_26x2, psoc6)
Full report (33 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #22938
Rules for fabric-sensitive structures did not match spec. IDL used to have fabric tags on commands and attributes.
However spec defines fabric-scoped to be a quality of structures and also has fabric-sensitive attributes on fields inside a fabric-scoped structure.
Changes in the PR:
fabric
tag on attributesfabric_scoped