Fix joining fabric print in ChipDeviceController
#21297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c ID by moving it to the right location
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
msandstedt and
mspang
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
bzbarsky-apple
requested changes
Aug 4, 2022
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
bzbarsky-apple
approved these changes
Aug 25, 2022
|
PR #21297: Size comparison from 40d5dab to d3dd931 Increases (10 builds for cyw30739, esp32, linux, psoc6, telink)
Decreases (4 builds for bl602, cyw30739, efr32, psoc6)
Full report (32 builds for bl602, cyw30739, efr32, esp32, linux, mbed, psoc6, telink)
|
|
PR #21297: Size comparison from 40d5dab to d4ea0f4 Increases (4 builds for cyw30739, esp32, linux, psoc6)
Decreases (6 builds for bl602, efr32, linux, psoc6, telink)
Full report (41 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, telink)
|
|
By the new criteria for inclusion to 1.0, this PR will not be justifiable. Closing it out and will re-open once we branch for 1.0. |
|
PR #21297: Size comparison from 51a5082 to f9a4a1d Increases (11 builds for bl602, bl702, esp32, linux, psoc6, telink)
Decreases (7 builds for cyw30739, efr32, esp32, psoc6)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #21297: Size comparison from 5030df4 to bfe8d73 Increases (11 builds for bl602, bl702, linux, psoc6, telink)
Decreases (2 builds for esp32, psoc6)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
* Fix joining fabric print to actually emit a sensible compressed fabric ID by moving it to the right location * Review fixes * Added FabricID to the print Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
* Fix joining fabric print to actually emit a sensible compressed fabric ID by moving it to the right location * Review fixes * Added FabricID to the print Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The print
Joining the fabric at index 1. Compressed fabric ID is: 0x00000000would always emit a value of 0 for the compressed fabric ID. This is becauseGetCompressedFabricIdeventually callsGetFabricInfo, which checks ifmStateisState::Initializedto return a valid value.The print is being called from within
InitControllerNOCChain, which is well before the state gets set to initialized.Fix
Just move the print.