-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TC-SWTCH]: Add capability to adjust the state of the the switch position #21144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #21144: Size comparison from 2557f51 to 8eef386 Increases (3 builds for cc13x2_26x2, telink)
Decreases (1 build for nrfconnect)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Jul 25, 2022
woody-apple
added a commit
that referenced
this pull request
Jul 26, 2022
#21184) Co-authored-by: Yufeng Wang <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
To verify the latching and Momentary switch state as explained in the test case TC-SWTCH-3.2, we need a way to modify the state of the switch will be helpful to verify this simulated functionality.
currently test case expects to change the state of the switch from 0 to 1 and vice versa and expects to read the attribute. As of now there is no provision to change the change the state of the switch. Hence requesting for a way to verify this functionality.
For test case TC-SWTCH-2.2 - Also needs a method change the switch position and returns to the existing position.
For ex: The test steps needs to operate the switch and release the switch by the operator.
Test plan link:
https://github.com/CHIP-Specifications/chip-test-plans/blob/master/src/cluster/switch.adoc
Change overview
Add capability to adjust the state of the the switch position
Testing
How was this tested? (at least one bullet point required)
On Server Side:
./chip-lighting-app
On Client Side:
$ echo '{"Name":"MultiPressComplete","PreviousPosition":3,"TotalNumberOfPressesCounted":2}' > /tmp/chip_all_clusters_fifo_300736
On Server Side: