Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up optional arguments properly in chip-tool. #20190

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Clean up optional arguments properly in chip-tool. #20190

merged 1 commit into from
Jul 1, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Otherwise in interactive mode we can end up with noise left over from
a previous command invocation.

Fixes #20151

Problem

See issue above, but also we can get perfectly valid values getting carried over in interactive mode from a command that set an optional arg to one that is trying not to.

Change overview

Make sure to reset optional args during command shutdown.

Testing

Used test in #20151.

@bzbarsky-apple
Clean up optional arguments properly in chip-tool.
f9ccb64 
Otherwise in interactive mode we can end up with noise left over from
a previous command invocation.

Fixes project-chip#20151
@github-actions
Copy link

github-actions bot commented Jun 30, 2022 •
edited
Loading

PR #20190: Size comparison from 76a08ac to f9ccb64

Increases (7 builds for cc13x2_26x2, linux, telink)
platform target config section 76a08ac f9ccb64 change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 653939 653947 8 0.0
.text 562052 562060 8 0.0
pump-app LP_CC2652R7 (read/write) 165008 165016 8 0.0
linux chip-tool debug (read only) 10168325 10172165 3840 0.0
.rodata 508069 508165 96 0.0
.text 8249269 8253013 3744 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9901380 9905684 4304 0.0
.rodata 471476 471572 96 0.0
.text 7888052 7892260 4208 0.1
tv-casting-app debug (read only) 5555481 5559321 3840 0.1
.rodata 343113 343209 96 0.0
.text 4935490 4939234 3744 0.1
telink light-switch-app tlsr9518adk80d text 564814 564816 2 0.0
lighting-app tlsr9518adk80d text 581170 581174 4 0.0
Decreases (3 builds for cc13x2_26x2, esp32)
platform target config section 76a08ac f9ccb64 change % change
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read/write) 196580 196572 -8 -0.0
pump-app LP_CC2652R7 (read only) 677207 677199 -8 -0.0
.text 588300 588292 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1018490 1018488 -2 -0.0
.flash.text 1018490 1018488 -2 -0.0
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 76a08ac f9ccb64 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 665171 665171 0 0.0
(read/write) 186052 186052 0 0.0
.bss 74116 74116 0 0.0
.data 3356 3356 0 0.0
.rodata 88091 88091 0 0.0
.text 576764 576764 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 653939 653947 8 0.0
(read/write) 196580 196572 -8 -0.0
.bss 73412 73412 0 0.0
.data 3356 3356 0 0.0
.rodata 91571 91571 0 0.0
.text 562052 562060 8 0.0
lock-ftd LP_CC2652R7 (read only) 667759 667759 0 0.0
(read/write) 173608 173608 0 0.0
.bss 71148 71148 0 0.0
.data 3280 3280 0 0.0
.rodata 76191 76191 0 0.0
.text 591088 591088 0 0.0
lock-mtd LP_CC2652R7 (read only) 617175 617175 0 0.0
(read/write) 144264 144264 0 0.0
.bss 66868 66868 0 0.0
.data 3280 3280 0 0.0
.rodata 76071 76071 0 0.0
.text 540616 540616 0 0.0
pump-app LP_CC2652R7 (read only) 677207 677199 -8 -0.0
(read/write) 165008 165016 8 0.0
.bss 71228 71228 0 0.0
.data 3280 3280 0 0.0
.rodata 88423 88423 0 0.0
.text 588300 588292 -8 -0.0
pump-controller-app LP_CC2652R7 (read only) 663047 663047 0 0.0
(read/write) 179288 179288 0 0.0
.bss 71348 71348 0 0.0
.data 3276 3276 0 0.0
.rodata 84271 84271 0 0.0
.text 578296 578296 0 0.0
shell LP_CC2652R7 (read only) 657630 657630 0 0.0
(read/write) 189096 189096 0 0.0
.bss 76420 76420 0 0.0
.data 3360 3360 0 0.0
.rodata 84838 84838 0 0.0
.text 572476 572476 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 578662 578662 0 0.0
.app_xip_area 457440 457440 0 0.0
.bss 64184 64184 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 580238 580238 0 0.0
.app_xip_area 458824 458824 0 0.0
.bss 64376 64376 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 581734 581734 0 0.0
.app_xip_area 461360 461360 0 0.0
.bss 63392 63392 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1080092 1080092 0 0.0
.bss 132996 132996 0 0.0
.data 2048 2048 0 0.0
.text 945028 945028 0 0.0
BRD4161A+rpc (read/write) 1134420 1134420 0 0.0
.bss 149676 149676 0 0.0
.data 2260 2260 0 0.0
.text 982464 982464 0 0.0
BRD4161A+rs911x (read/write) 942556 942556 0 0.0
.bss 138712 138712 0 0.0
.data 2048 2048 0 0.0
.text 801776 801776 0 0.0
lock-app BRD4161A+wf200 (read/write) 1123992 1123992 0 0.0
.bss 142128 142128 0 0.0
.data 2060 2060 0 0.0
.text 979784 979784 0 0.0
window-app BRD4161A (read/write) 1065324 1065324 0 0.0
.bss 133076 133076 0 0.0
.data 2076 2076 0 0.0
.text 930148 930148 0 0.0
esp32 all-clusters-app c3devkit (read only) 1018490 1018488 -2 -0.0
(read/write) 1484882 1484882 0 0.0
.dram0.bss 70080 70080 0 0.0
.dram0.data 14592 14592 0 0.0
.flash.rodata 214784 214784 0 0.0
.flash.text 1018490 1018488 -2 -0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1072583 1072583 0 0.0
(read/write) 486984 486984 0 0.0
.dram0.bss 75600 75600 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 245244 245244 0 0.0
.flash.text 1067199 1067199 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 658040 658040 0 0.0
.bss 69516 69516 0 0.0
.data 1992 1992 0 0.0
.text 580732 580732 0 0.0
lock k32w061+release (read/write) 684524 684524 0 0.0
.bss 69980 69980 0 0.0
.data 2004 2004 0 0.0
.text 606740 606740 0 0.0
linux all-clusters-app debug (read only) 2954289 2954289 0 0.0
(read/write) 154744 154744 0 0.0
.bss 61536 61536 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84952 84952 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 263133 263133 0 0.0
.text 2514018 2514018 0 0.0
all-clusters-minimal-app debug (read only) 2808401 2808401 0 0.0
(read/write) 146648 146648 0 0.0
.bss 60864 60864 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77592 77592 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 264797 264797 0 0.0
.text 2368642 2368642 0 0.0
bridge-app debug+rpc (read only) 2311801 2311801 0 0.0
(read/write) 125472 125472 0 0.0
.bss 48928 48928 0 0.0
.data 3824 3824 0 0.0
.data.rel.ro 66968 66968 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 197696 197696 0 0.0
.text 1952418 1952418 0 0.0
chip-tool debug (read only) 10168325 10172165 3840 0.0
(read/write) 611784 611784 0 0.0
.bss 24384 24384 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 580016 580016 0 0.0
.dynamic 624 624 0 0.0
.got 5016 5016 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 508069 508165 96 0.0
.text 8249269 8253013 3744 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9901380 9905684 4304 0.0
(read/write) 676593 676593 0 0.0
.bss 42609 42609 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 615576 615576 0 0.0
.dynamic 528 528 0 0.0
.got 13448 13448 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 471476 471572 96 0.0
.text 7888052 7892260 4208 0.1
lighting-app debug+rpc (read only) 2547705 2547705 0 0.0
(read/write) 129496 129496 0 0.0
.bss 49440 49440 0 0.0
.data 2096 2096 0 0.0
.data.rel.ro 72104 72104 0 0.0
.dynamic 608 608 0 0.0
.got 4392 4392 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 213512 213512 0 0.0
.text 2164274 2164274 0 0.0
lock-app debug (read only) 2509537 2509537 0 0.0
(read/write) 124472 124472 0 0.0
.bss 47840 47840 0 0.0
.data 1712 1712 0 0.0
.data.rel.ro 69080 69080 0 0.0
.dynamic 608 608 0 0.0
.got 4424 4424 0 0.0
.init 27 27 0 0.0
.init_array 784 784 0 0.0
.rodata 228200 228200 0 0.0
.text 2116242 2116242 0 0.0
ota-provider-app debug (read only) 2318625 2318625 0 0.0
(read/write) 118312 118312 0 0.0
.bss 47488 47488 0 0.0
.data 1944 1944 0 0.0
.data.rel.ro 63080 63080 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 203288 203288 0 0.0
.text 1952610 1952610 0 0.0
ota-requestor-app debug (read only) 2435809 2435809 0 0.0
(read/write) 125216 125216 0 0.0
.bss 49856 49856 0 0.0
.data 2232 2232 0 0.0
.data.rel.ro 67272 67272 0 0.0
.dynamic 608 608 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 207328 207328 0 0.0
.text 2057378 2057378 0 0.0
shell debug (read only) 2543921 2543921 0 0.0
(read/write) 141032 141032 0 0.0
.bss 57448 57448 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 76672 76672 0 0.0
.dynamic 608 608 0 0.0
.got 4096 4096 0 0.0
.init 27 27 0 0.0
.init_array 920 920 0 0.0
.rodata 227218 227218 0 0.0
.text 2160386 2160386 0 0.0
thermostat-no-ble arm64 (read only) 2591604 2591604 0 0.0
(read/write) 158273 158273 0 0.0
.bss 65249 65249 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 83232 83232 0 0.0
.dynamic 528 528 0 0.0
.got 5072 5072 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 165236 165236 0 0.0
.text 2186624 2186624 0 0.0
tv-app debug (read only) 3098121 3098121 0 0.0
(read/write) 257672 257672 0 0.0
.bss 167016 167016 0 0.0
.data 4848 4848 0 0.0
.data.rel.ro 79360 79360 0 0.0
.dynamic 608 608 0 0.0
.got 4848 4848 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 249024 249024 0 0.0
.text 2661266 2661266 0 0.0
tv-casting-app debug (read only) 5555481 5559321 3840 0.1
(read/write) 161680 161680 0 0.0
.bss 50248 50248 0 0.0
.data 2416 2416 0 0.0
.data.rel.ro 102792 102792 0 0.0
.dynamic 608 608 0 0.0
.got 4720 4720 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 343113 343209 96 0.0
.text 4935490 4939234 3744 0.1
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2447088 2447088 0 0.0
.bss 213940 213940 0 0.0
.data 5872 5872 0 0.0
.text 1409732 1409732 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1172931 1172931 0 0.0
bss 142884 142884 0 0.0
rodata 141348 141348 0 0.0
text 809780 809780 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1153783 1153783 0 0.0
bss 142120 142120 0 0.0
rodata 133280 133280 0 0.0
text 799488 799488 0 0.0
p6 all-clusters-app default (read/write) 2562688 2562688 0 0.0
.bss 149120 149120 0 0.0
.data 2776 2776 0 0.0
.text 1520952 1520952 0 0.0
all-clusters-minimal-app default (read/write) 2508552 2508552 0 0.0
.bss 148400 148400 0 0.0
.data 2776 2776 0 0.0
.text 1466816 1466816 0 0.0
light-app default (read/write) 2439048 2439048 0 0.0
.bss 140456 140456 0 0.0
.data 2592 2592 0 0.0
.text 1397312 1397312 0 0.0
lock-app default (read/write) 2465328 2465328 0 0.0
.bss 140304 140304 0 0.0
.data 2600 2600 0 0.0
.text 1423592 1423592 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 796292 796292 0 0.0
bss 70560 70560 0 0.0
noinit 40416 40416 0 0.0
text 564814 564816 2 0.0
lighting-app tlsr9518adk80d (read/write) 816160 816160 0 0.0
bss 71404 71404 0 0.0
noinit 40416 40416 0 0.0
text 581170 581174 4 0.0

@bzbarsky-apple
Copy link
Contributor Author

fast-tracking test tool change.

@bzbarsky-apple bzbarsky-apple merged commit e491f85 into project-chip:master Jul 1, 2022
@bzbarsky-apple bzbarsky-apple deleted the chip-tool-more-arg-cleanup branch July 1, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple approved these changes

@vivien-apple vivien-apple vivien-apple approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

Assignees
No one assigned
Labels
examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Pre-SVE] --commissioner-name in chip-tool interactive mode
3 participants
@bzbarsky-apple @woody-apple @vivien-apple