-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3/3] Spec-compliant CASE eviction policy algorithm #19903
Merged
mrjerryjohns
merged 5 commits into
project-chip:master
from
mrjerryjohns:case-eviction-final-policy
Jun 25, 2022
Merged
[3/3] Spec-compliant CASE eviction policy algorithm #19903
mrjerryjohns
merged 5 commits into
project-chip:master
from
mrjerryjohns:case-eviction-final-policy
Jun 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a reasonably complete session eviction policy algorithm that meets the spec minima requirements for sessions / fabric and ensures that can be up-held at all times on a given fabric regardless of activity on other fabrics. It also adds a more nuanced selection algorithm to correctly balance the multiple factors that go into selecting a session for eviction.
being allocated out of the heap.
andy31415
reviewed
Jun 23, 2022
andy31415
reviewed
Jun 23, 2022
andy31415
reviewed
Jun 23, 2022
andy31415
reviewed
Jun 23, 2022
andy31415
reviewed
Jun 23, 2022
andy31415
reviewed
Jun 23, 2022
andy31415
reviewed
Jun 23, 2022
andy31415
reviewed
Jun 23, 2022
woody-apple
approved these changes
Jun 23, 2022
PR #19903: Size comparison from 1381c8e to 279b206 Increases (37 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, p6, telink)
Decreases (10 builds for cc13x2_26x2, linux)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, p6, telink)
|
msandstedt
reviewed
Jun 23, 2022
msandstedt
reviewed
Jun 23, 2022
msandstedt
reviewed
Jun 23, 2022
tehampson
reviewed
Jun 24, 2022
5658d33
to
eff137a
Compare
PR #19903: Size comparison from eaafe61 to eff137a Increases (10 builds for cyw30739, k32w, linux, mbed, telink)
Full report (10 builds for cyw30739, k32w, linux, mbed, telink)
|
eff137a
to
ce387e9
Compare
PR #19903: Size comparison from eaafe61 to ce387e9 Increases (39 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
Decreases (10 builds for cc13x2_26x2, linux)
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, p6, telink)
|
ce387e9
to
491c810
Compare
bzbarsky-apple
approved these changes
Jun 24, 2022
PR #19903: Size comparison from e5e09f5 to 491c810 Increases (23 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (6 builds for cc13x2_26x2)
Full report (23 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jun 24, 2022
Co-authored-by: Boris Zbarsky <[email protected]>
PR #19903: Size comparison from e5e09f5 to 1abcf48 Increases (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
Decreases (11 builds for cc13x2_26x2, linux)
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
msandstedt
approved these changes
Jun 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #17568
This implements a spec-compliant CASE eviction policy algorithm that attempts to achieve the following sort key order:
with lesser sessions.
Key1 and Key2 are what guarantee spec-defined minima / fabric regardless of session establishment activity on other fabrics.
More detailed rationale can be found in the comments for
SecureSessionTable::DefaultEvictionPolicy
Other fixes:
SortableSession
list to a stack-allocated one based on discussions previously.Testing
TestSecureSessionTable
test that validates the various different eviction scenarios that require the different sorting criteria above.