Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ZAP. #19812

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Update ZAP. #19812

merged 2 commits into from
Jun 22, 2022

Conversation

bzbarsky-apple
Copy link
Contributor

Fixes type sizes for external attributes for which a size is known.

Fixes #19647

The darwin-framework-tool change for bitmaps was needed because
presumably something changed on the ZAP side in terms of weak bitmaps
suddenly testing true for if_is_bitmap, which I thought they had
already been doing...

Problem

See above.

Change overview

Update ZAP.

Testing

Checked that the generated code changes are just the size bits we were expecting.

@github-actions
Copy link

github-actions bot commented Jun 21, 2022 •
edited
Loading

PR #19812: Size comparison from 39073b3 to e6e1e78

Increases (3 builds for cc13x2_26x2, esp32)
platform target config section 39073b3 e6e1e78 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660127 660135 8 0.0
.text 572576 572584 8 0.0
lock-mtd LP_CC2652R7 (read only) 640919 640927 8 0.0
.text 541020 541028 8 0.0
esp32 all-clusters-app c3devkit (read only) 1013698 1013700 2 0.0
.flash.text 1013698 1013700 2 0.0
Decreases (1 build for cc13x2_26x2)
platform target config section 39073b3 e6e1e78 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 190744 190736 -8 -0.0
Full report (36 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 39073b3 e6e1e78 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660127 660135 8 0.0
(read/write) 190744 190736 -8 -0.0
.bss 73764 73764 0 0.0
.data 3356 3356 0 0.0
.rodata 87239 87239 0 0.0
.text 572576 572584 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 648947 648947 0 0.0
(read/write) 157324 157324 0 0.0
.bss 73052 73052 0 0.0
.data 3356 3356 0 0.0
.rodata 90771 90771 0 0.0
.text 557856 557856 0 0.0
lock-ftd LP_CC2652R7 (read only) 691511 691511 0 0.0
(read/write) 149472 149472 0 0.0
.bss 70764 70764 0 0.0
.data 3280 3280 0 0.0
.rodata 99527 99527 0 0.0
.text 591500 591500 0 0.0
lock-mtd LP_CC2652R7 (read only) 640919 640927 8 0.0
(read/write) 143896 143896 0 0.0
.bss 66500 66500 0 0.0
.data 3280 3280 0 0.0
.rodata 99407 99407 0 0.0
.text 541020 541028 8 0.0
pump-app LP_CC2652R7 (read only) 672799 672799 0 0.0
(read/write) 169072 169072 0 0.0
.bss 70884 70884 0 0.0
.data 3280 3280 0 0.0
.rodata 87903 87903 0 0.0
.text 584412 584412 0 0.0
pump-controller-app LP_CC2652R7 (read only) 658675 658675 0 0.0
(read/write) 183308 183308 0 0.0
.bss 70996 70996 0 0.0
.data 3276 3276 0 0.0
.rodata 83747 83747 0 0.0
.text 574448 574448 0 0.0
shell LP_CC2652R7 (read only) 689870 689870 0 0.0
(read/write) 156496 156496 0 0.0
.bss 76060 76060 0 0.0
.data 3360 3360 0 0.0
.rodata 110022 110022 0 0.0
.text 579536 579536 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 613246 613246 0 0.0
.app_xip_area 469896 469896 0 0.0
.bss 86304 86304 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 610602 610602 0 0.0
.app_xip_area 467076 467076 0 0.0
.bss 86480 86480 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 617134 617134 0 0.0
.app_xip_area 474672 474672 0 0.0
.bss 85472 85472 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1013698 1013700 2 0.0
(read/write) 1483554 1483554 0 0.0
.dram0.bss 69400 69400 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 214080 214080 0 0.0
.flash.text 1013698 1013700 2 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068163 1068163 0 0.0
(read/write) 485640 485640 0 0.0
.dram0.bss 74920 74920 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244580 244580 0 0.0
.flash.text 1062779 1062779 0 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 659604 659604 0 0.0
.bss 68764 68764 0 0.0
.data 1992 1992 0 0.0
.text 583048 583048 0 0.0
lock k32w061+release (read/write) 722132 722132 0 0.0
.bss 69204 69204 0 0.0
.data 2000 2000 0 0.0
.text 645128 645128 0 0.0
linux all-clusters-app debug (read only) 2936105 2936105 0 0.0
(read/write) 177072 177072 0 0.0
.bss 84160 84160 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84664 84664 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 261149 261149 0 0.0
.text 2498514 2498514 0 0.0
all-clusters-minimal-app debug (read only) 2789817 2789817 0 0.0
(read/write) 168976 168976 0 0.0
.bss 83488 83488 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77304 77304 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 262685 262685 0 0.0
.text 2352866 2352866 0 0.0
bridge-app debug+rpc (read only) 2292513 2292513 0 0.0
(read/write) 147840 147840 0 0.0
.bss 71552 71552 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66728 66728 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 195936 195936 0 0.0
.text 1935394 1935394 0 0.0
chip-tool debug (read only) 10147117 10147117 0 0.0
(read/write) 609544 609544 0 0.0
.bss 24352 24352 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 577808 577808 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 510389 510389 0 0.0
.text 8230997 8230997 0 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9886988 9886988 0 0.0
(read/write) 674225 674225 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 613208 613208 0 0.0
.dynamic 528 528 0 0.0
.got 13416 13416 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473180 473180 0 0.0
.text 7877380 7877380 0 0.0
lighting-app debug+rpc (read only) 2525209 2525209 0 0.0
(read/write) 151896 151896 0 0.0
.bss 72032 72032 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71896 71896 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 211688 211688 0 0.0
.text 2143730 2143730 0 0.0
lock-app debug (read only) 2463905 2463905 0 0.0
(read/write) 146544 146544 0 0.0
.bss 70432 70432 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68568 68568 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 225384 225384 0 0.0
.text 2074130 2074130 0 0.0
ota-provider-app debug (read only) 2301857 2301857 0 0.0
(read/write) 140680 140680 0 0.0
.bss 70112 70112 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 201624 201624 0 0.0
.text 1937986 1937986 0 0.0
ota-requestor-app debug (read only) 2417665 2417665 0 0.0
(read/write) 147392 147392 0 0.0
.bss 72416 72416 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 66936 66936 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 205280 205280 0 0.0
.text 2041906 2041906 0 0.0
shell debug (read only) 2609921 2609921 0 0.0
(read/write) 196088 196088 0 0.0
.bss 111304 111304 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77808 77808 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 231378 231378 0 0.0
.text 2218786 2218786 0 0.0
thermostat-no-ble arm64 (read only) 2575988 2575988 0 0.0
(read/write) 180577 180577 0 0.0
.bss 87889 87889 0 0.0
.data 1688 1688 0 0.0
.data.rel.ro 82928 82928 0 0.0
.dynamic 528 528 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164196 164196 0 0.0
.text 2172720 2172720 0 0.0
tv-app debug (read only) 3073777 3073777 0 0.0
(read/write) 277768 277768 0 0.0
.bss 187656 187656 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 79016 79016 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 247296 247296 0 0.0
.text 2639618 2639618 0 0.0
tv-casting-app debug (read only) 5539297 5539297 0 0.0
(read/write) 184080 184080 0 0.0
.bss 72840 72840 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 102576 102576 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 341257 341257 0 0.0
.text 4921810 4921810 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439048 2439048 0 0.0
.bss 208212 208212 0 0.0
.data 5864 5864 0 0.0
.text 1401692 1401692 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1199927 1199927 0 0.0
bss 141606 141606 0 0.0
rodata 156312 156312 0 0.0
text 823096 823096 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1147887 1147887 0 0.0
bss 140858 140858 0 0.0
rodata 132840 132840 0 0.0
text 795316 795316 0 0.0
p6 all-clusters-app default (read/write) 2555392 2555392 0 0.0
.bss 143392 143392 0 0.0
.data 2776 2776 0 0.0
.text 1513656 1513656 0 0.0
all-clusters-minimal-app default (read/write) 2501240 2501240 0 0.0
.bss 142672 142672 0 0.0
.data 2776 2776 0 0.0
.text 1459504 1459504 0 0.0
light-app default (read/write) 2432000 2432000 0 0.0
.bss 134752 134752 0 0.0
.data 2592 2592 0 0.0
.text 1390264 1390264 0 0.0
lock-app default (read/write) 2452688 2452688 0 0.0
.bss 134576 134576 0 0.0
.data 2600 2600 0 0.0
.text 1410952 1410952 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 790472 790472 0 0.0
bss 69900 69900 0 0.0
noinit 40416 40416 0 0.0
text 560392 560392 0 0.0
lighting-app tlsr9518adk80d (read/write) 810184 810184 0 0.0
bss 70148 70148 0 0.0
noinit 40416 40416 0 0.0
text 576852 576852 0 0.0

@boring-cyborg boring-cyborg bot added the app label Jun 21, 2022
@github-actions
Copy link

github-actions bot commented Jun 21, 2022 •
edited
Loading

PR #19812: Size comparison from 39073b3 to da040f0

Increases (27 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, nrfconnect, p6, telink)
platform target config section 39073b3 da040f0 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660127 660135 8 0.0
.text 572576 572584 8 0.0
lock-mtd LP_CC2652R7 (read only) 640919 640927 8 0.0
.text 541020 541028 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 613246 613254 8 0.0
.app_xip_area 469896 469904 8 0.0
lock cyw930739m2evb_01 (read/write) 610602 610610 8 0.0
.app_xip_area 467076 467084 8 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 617134 617142 8 0.0
.app_xip_area 474672 474680 8 0.0
esp32 all-clusters-app c3devkit (read only) 1013698 1013704 6 0.0
.flash.text 1013698 1013704 6 0.0
m5stack (read only) 1068163 1068171 8 0.0
.flash.text 1062779 1062787 8 0.0
k32w lock k32w061+release (read/write) 722132 722148 16 0.0
.text 645128 645144 16 0.0
linux all-clusters-app debug (read only) 2936105 2936169 64 0.0
.text 2498514 2498578 64 0.0
all-clusters-minimal-app debug (read only) 2789817 2789881 64 0.0
.text 2352866 2352930 64 0.0
bridge-app debug+rpc (read only) 2292513 2292577 64 0.0
.text 1935394 1935458 64 0.0
chip-tool debug (read only) 10147117 10147181 64 0.0
.text 8230997 8231061 64 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9886988 9887052 64 0.0
.text 7877380 7877444 64 0.0
lighting-app debug+rpc (read only) 2525209 2525273 64 0.0
.text 2143730 2143794 64 0.0
lock-app debug (read only) 2463905 2463985 80 0.0
.text 2074130 2074210 80 0.0
ota-provider-app debug (read only) 2301857 2301937 80 0.0
.text 1937986 1938066 80 0.0
ota-requestor-app debug (read only) 2417665 2417729 64 0.0
.text 2041906 2041970 64 0.0
shell debug (read only) 2609921 2609985 64 0.0
.text 2218786 2218850 64 0.0
thermostat-no-ble arm64 (read only) 2575988 2576052 64 0.0
.text 2172720 2172784 64 0.0
tv-app debug (read only) 3073777 3073857 80 0.0
.text 2639618 2639698 80 0.0
tv-casting-app debug (read only) 5539297 5539361 64 0.0
.text 4921810 4921874 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 823096 823100 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1147887 1147903 16 0.0
text 795316 795320 4 0.0
p6 light-app default (read/write) 2432000 2432016 16 0.0
.text 1390264 1390280 16 0.0
lock-app default (read/write) 2452688 2452704 16 0.0
.text 1410952 1410968 16 0.0
telink light-switch-app tlsr9518adk80d (read/write) 790472 790480 8 0.0
text 560392 560396 4 0.0
lighting-app tlsr9518adk80d text 576852 576856 4 0.0
Decreases (1 build for cc13x2_26x2)
platform target config section 39073b3 da040f0 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 190744 190736 -8 -0.0
Full report (36 builds for cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 39073b3 da040f0 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660127 660135 8 0.0
(read/write) 190744 190736 -8 -0.0
.bss 73764 73764 0 0.0
.data 3356 3356 0 0.0
.rodata 87239 87239 0 0.0
.text 572576 572584 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 648947 648947 0 0.0
(read/write) 157324 157324 0 0.0
.bss 73052 73052 0 0.0
.data 3356 3356 0 0.0
.rodata 90771 90771 0 0.0
.text 557856 557856 0 0.0
lock-ftd LP_CC2652R7 (read only) 691511 691511 0 0.0
(read/write) 149472 149472 0 0.0
.bss 70764 70764 0 0.0
.data 3280 3280 0 0.0
.rodata 99527 99527 0 0.0
.text 591500 591500 0 0.0
lock-mtd LP_CC2652R7 (read only) 640919 640927 8 0.0
(read/write) 143896 143896 0 0.0
.bss 66500 66500 0 0.0
.data 3280 3280 0 0.0
.rodata 99407 99407 0 0.0
.text 541020 541028 8 0.0
pump-app LP_CC2652R7 (read only) 672799 672799 0 0.0
(read/write) 169072 169072 0 0.0
.bss 70884 70884 0 0.0
.data 3280 3280 0 0.0
.rodata 87903 87903 0 0.0
.text 584412 584412 0 0.0
pump-controller-app LP_CC2652R7 (read only) 658675 658675 0 0.0
(read/write) 183308 183308 0 0.0
.bss 70996 70996 0 0.0
.data 3276 3276 0 0.0
.rodata 83747 83747 0 0.0
.text 574448 574448 0 0.0
shell LP_CC2652R7 (read only) 689870 689870 0 0.0
(read/write) 156496 156496 0 0.0
.bss 76060 76060 0 0.0
.data 3360 3360 0 0.0
.rodata 110022 110022 0 0.0
.text 579536 579536 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 613246 613254 8 0.0
.app_xip_area 469896 469904 8 0.0
.bss 86304 86304 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 610602 610610 8 0.0
.app_xip_area 467076 467084 8 0.0
.bss 86480 86480 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 617134 617142 8 0.0
.app_xip_area 474672 474680 8 0.0
.bss 85472 85472 0 0.0
.data 672 672 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1013698 1013704 6 0.0
(read/write) 1483554 1483554 0 0.0
.dram0.bss 69400 69400 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 214080 214080 0 0.0
.flash.text 1013698 1013704 6 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068163 1068171 8 0.0
(read/write) 485640 485640 0 0.0
.dram0.bss 74920 74920 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244580 244580 0 0.0
.flash.text 1062779 1062787 8 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 659604 659604 0 0.0
.bss 68764 68764 0 0.0
.data 1992 1992 0 0.0
.text 583048 583048 0 0.0
lock k32w061+release (read/write) 722132 722148 16 0.0
.bss 69204 69204 0 0.0
.data 2000 2000 0 0.0
.text 645128 645144 16 0.0
linux all-clusters-app debug (read only) 2936105 2936169 64 0.0
(read/write) 177072 177072 0 0.0
.bss 84160 84160 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 84664 84664 0 0.0
.dynamic 608 608 0 0.0
.got 4536 4536 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 261149 261149 0 0.0
.text 2498514 2498578 64 0.0
all-clusters-minimal-app debug (read only) 2789817 2789881 64 0.0
(read/write) 168976 168976 0 0.0
.bss 83488 83488 0 0.0
.data 2048 2048 0 0.0
.data.rel.ro 77304 77304 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 262685 262685 0 0.0
.text 2352866 2352930 64 0.0
bridge-app debug+rpc (read only) 2292513 2292577 64 0.0
(read/write) 147840 147840 0 0.0
.bss 71552 71552 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 66728 66728 0 0.0
.dynamic 608 608 0 0.0
.got 4400 4400 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 195936 195936 0 0.0
.text 1935394 1935458 64 0.0
chip-tool debug (read only) 10147117 10147181 64 0.0
(read/write) 609544 609544 0 0.0
.bss 24352 24352 0 0.0
.data 1088 1088 0 0.0
.data.rel.ro 577808 577808 0 0.0
.dynamic 624 624 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 640 640 0 0.0
.rodata 510389 510389 0 0.0
.text 8230997 8231061 64 0.0
chip-tool-no-interactive-ipv6only arm64 (read only) 9886988 9887052 64 0.0
(read/write) 674225 674225 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 613208 613208 0 0.0
.dynamic 528 528 0 0.0
.got 13416 13416 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473180 473180 0 0.0
.text 7877380 7877444 64 0.0
lighting-app debug+rpc (read only) 2525209 2525273 64 0.0
(read/write) 151896 151896 0 0.0
.bss 72032 72032 0 0.0
.data 2064 2064 0 0.0
.data.rel.ro 71896 71896 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 816 816 0 0.0
.rodata 211688 211688 0 0.0
.text 2143730 2143794 64 0.0
lock-app debug (read only) 2463905 2463985 80 0.0
(read/write) 146544 146544 0 0.0
.bss 70432 70432 0 0.0
.data 1680 1680 0 0.0
.data.rel.ro 68568 68568 0 0.0
.dynamic 608 608 0 0.0
.got 4432 4432 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 225384 225384 0 0.0
.text 2074130 2074210 80 0.0
ota-provider-app debug (read only) 2301857 2301937 80 0.0
(read/write) 140680 140680 0 0.0
.bss 70112 70112 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 62840 62840 0 0.0
.dynamic 608 608 0 0.0
.got 4496 4496 0 0.0
.init 27 27 0 0.0
.init_array 672 672 0 0.0
.rodata 201624 201624 0 0.0
.text 1937986 1938066 80 0.0
ota-requestor-app debug (read only) 2417665 2417729 64 0.0
(read/write) 147392 147392 0 0.0
.bss 72416 72416 0 0.0
.data 2200 2200 0 0.0
.data.rel.ro 66936 66936 0 0.0
.dynamic 608 608 0 0.0
.got 4488 4488 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 205280 205280 0 0.0
.text 2041906 2041970 64 0.0
shell debug (read only) 2609921 2609985 64 0.0
(read/write) 196088 196088 0 0.0
.bss 111304 111304 0 0.0
.data 1232 1232 0 0.0
.data.rel.ro 77808 77808 0 0.0
.dynamic 608 608 0 0.0
.got 4168 4168 0 0.0
.init 27 27 0 0.0
.init_array 936 936 0 0.0
.rodata 231378 231378 0 0.0
.text 2218786 2218850 64 0.0
thermostat-no-ble arm64 (read only) 2575988 2576052 64 0.0
(read/write) 180577 180577 0 0.0
.bss 87889 87889 0 0.0
.data 1688 1688 0 0.0
.data.rel.ro 82928 82928 0 0.0
.dynamic 528 528 0 0.0
.got 5056 5056 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164196 164196 0 0.0
.text 2172720 2172784 64 0.0
tv-app debug (read only) 3073777 3073857 80 0.0
(read/write) 277768 277768 0 0.0
.bss 187656 187656 0 0.0
.data 4656 4656 0 0.0
.data.rel.ro 79016 79016 0 0.0
.dynamic 608 608 0 0.0
.got 4840 4840 0 0.0
.init 27 27 0 0.0
.init_array 952 952 0 0.0
.rodata 247296 247296 0 0.0
.text 2639618 2639698 80 0.0
tv-casting-app debug (read only) 5539297 5539361 64 0.0
(read/write) 184080 184080 0 0.0
.bss 72840 72840 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 102576 102576 0 0.0
.dynamic 608 608 0 0.0
.got 4712 4712 0 0.0
.init 27 27 0 0.0
.init_array 864 864 0 0.0
.rodata 341257 341257 0 0.0
.text 4921810 4921874 64 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439048 2439048 0 0.0
.bss 208212 208212 0 0.0
.data 5864 5864 0 0.0
.text 1401692 1401692 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1199927 1199927 0 0.0
bss 141606 141606 0 0.0
rodata 156312 156312 0 0.0
text 823096 823100 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1147887 1147903 16 0.0
bss 140858 140858 0 0.0
rodata 132840 132840 0 0.0
text 795316 795320 4 0.0
p6 all-clusters-app default (read/write) 2555392 2555392 0 0.0
.bss 143392 143392 0 0.0
.data 2776 2776 0 0.0
.text 1513656 1513656 0 0.0
all-clusters-minimal-app default (read/write) 2501240 2501240 0 0.0
.bss 142672 142672 0 0.0
.data 2776 2776 0 0.0
.text 1459504 1459504 0 0.0
light-app default (read/write) 2432000 2432016 16 0.0
.bss 134752 134752 0 0.0
.data 2592 2592 0 0.0
.text 1390264 1390280 16 0.0
lock-app default (read/write) 2452688 2452704 16 0.0
.bss 134576 134576 0 0.0
.data 2600 2600 0 0.0
.text 1410952 1410968 16 0.0
telink light-switch-app tlsr9518adk80d (read/write) 790472 790480 8 0.0
bss 69900 69900 0 0.0
noinit 40416 40416 0 0.0
text 560392 560396 4 0.0
lighting-app tlsr9518adk80d (read/write) 810184 810184 0 0.0
bss 70148 70148 0 0.0
noinit 40416 40416 0 0.0
text 576852 576856 4 0.0

@bzbarsky-apple
Update ZAP.
88315da 
Fixes type sizes for external attributes for which a size is known.

Fixes project-chip#19647

The darwin-framework-tool change for bitmaps was needed because
presumably something changed on the ZAP side in terms of weak bitmaps
suddenly testing true for if_is_bitmap, which I thought they had
already been doing...
@bzbarsky-apple
Ignore the size of external attributes when computing offsets into th…
c4b7761 
…e singleton store.

External attributes are not actually stored in the singleton store.
@github-actions
Copy link

github-actions bot commented Jun 22, 2022 •
edited
Loading

PR #19812: Size comparison from d1a4bb7 to c4b7761

Increases (11 builds for cc13x2_26x2, cyw30739, esp32, linux, nrfconnect, p6, telink)
platform target config section d1a4bb7 c4b7761 change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read/write) 183604 183612 8 0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 589106 589114 8 0.0
.app_xip_area 459828 459836 8 0.0
esp32 all-clusters-app c3devkit (read only) 1014134 1014138 4 0.0
.flash.text 1014134 1014138 4 0.0
m5stack (read only) 1068459 1068463 4 0.0
.flash.text 1063075 1063079 4 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9925180 9925244 64 0.0
.text 7910292 7910356 64 0.0
thermostat-no-ble arm64 (read only) 2578364 2578428 64 0.0
.text 2174752 2174816 64 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 823984 823988 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 796032 796036 4 0.0
p6 all-clusters-minimal-app default (read/write) 2501624 2501640 16 0.0
.text 1459888 1459904 16 0.0
telink light-switch-app tlsr9518adk80d text 561060 561064 4 0.0
lighting-app tlsr9518adk80d (read/write) 811784 811792 8 0.0
text 577520 577522 2 0.0
Decreases (2 builds for cc13x2_26x2, cyw30739)
platform target config section d1a4bb7 c4b7761 change % change
cc13x2_26x2 pump-controller-app LP_CC2652R7 (read only) 659123 659115 -8 -0.0
.text 575136 575128 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591730 591722 -8 -0.0
.app_xip_area 462628 462620 -8 -0.0
Full report (30 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section d1a4bb7 c4b7761 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 660439 660439 0 0.0
(read/write) 191168 191168 0 0.0
.bss 74500 74500 0 0.0
.data 3356 3356 0 0.0
.rodata 86975 86975 0 0.0
.text 573152 573152 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 649251 649251 0 0.0
(read/write) 158060 158060 0 0.0
.bss 73788 73788 0 0.0
.data 3356 3356 0 0.0
.rodata 90507 90507 0 0.0
.text 558424 558424 0 0.0
lock-ftd LP_CC2652R7 (read only) 691999 691999 0 0.0
(read/write) 149720 149720 0 0.0
.bss 71500 71500 0 0.0
.data 3280 3280 0 0.0
.rodata 99351 99351 0 0.0
.text 592164 592164 0 0.0
lock-mtd LP_CC2652R7 (read only) 641415 641415 0 0.0
(read/write) 144632 144632 0 0.0
.bss 67236 67236 0 0.0
.data 3280 3280 0 0.0
.rodata 99239 99239 0 0.0
.text 541684 541684 0 0.0
pump-app LP_CC2652R7 (read only) 673231 673231 0 0.0
(read/write) 169384 169384 0 0.0
.bss 71628 71628 0 0.0
.data 3280 3280 0 0.0
.rodata 87663 87663 0 0.0
.text 585084 585084 0 0.0
pump-controller-app LP_CC2652R7 (read only) 659123 659115 -8 -0.0
(read/write) 183604 183612 8 0.0
.bss 71740 71740 0 0.0
.data 3276 3276 0 0.0
.rodata 83507 83507 0 0.0
.text 575136 575128 -8 -0.0
shell LP_CC2652R7 (read only) 690198 690198 0 0.0
(read/write) 156912 156912 0 0.0
.bss 76804 76804 0 0.0
.data 3360 3360 0 0.0
.rodata 109758 109758 0 0.0
.text 580128 580128 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 591730 591722 -8 -0.0
.app_xip_area 462628 462620 -8 -0.0
.bss 72064 72064 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589106 589114 8 0.0
.app_xip_area 459828 459836 8 0.0
.bss 72240 72240 0 0.0
.data 720 720 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 594250 594250 0 0.0
.app_xip_area 466020 466020 0 0.0
.bss 71248 71248 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 926072 926072 0 0.0
(read/write) 133664 133664 0 0.0
.bss 131584 131584 0 0.0
.data 2080 2080 0 0.0
.text 926064 926064 0 0.0
BRD4161A+rpc (read only) 963216 963216 0 0.0
(read/write) 150552 150552 0 0.0
.bss 148264 148264 0 0.0
.data 2284 2284 0 0.0
.text 963208 963208 0 0.0
BRD4161A+rs911x (read only) 802580 802580 0 0.0
(read/write) 140316 140316 0 0.0
.bss 138228 138228 0 0.0
.data 2088 2088 0 0.0
.text 802572 802572 0 0.0
lock-app BRD4161A+wf200 (read only) 968288 968288 0 0.0
(read/write) 140692 140692 0 0.0
.bss 138604 138604 0 0.0
.data 2088 2088 0 0.0
.text 968280 968280 0 0.0
window-app BRD4161A (read only) 911240 911240 0 0.0
(read/write) 133768 133768 0 0.0
.bss 131656 131656 0 0.0
.data 2108 2108 0 0.0
.text 911232 911232 0 0.0
esp32 all-clusters-app c3devkit (read only) 1014134 1014138 4 0.0
(read/write) 1484770 1484770 0 0.0
.dram0.bss 70640 70640 0 0.0
.dram0.data 14632 14632 0 0.0
.flash.rodata 214064 214064 0 0.0
.flash.text 1014134 1014138 4 0.0
.iram0.text 62902 62902 0 0.0
m5stack (read only) 1068459 1068463 4 0.0
(read/write) 486856 486856 0 0.0
.dram0.bss 76152 76152 0 0.0
.dram0.data 34144 34144 0 0.0
.flash.rodata 244564 244564 0 0.0
.flash.text 1063075 1063079 4 0.0
.iram0.text 123267 123267 0 0.0
k32w light k32w061+release (read/write) 661524 661524 0 0.0
.bss 69756 69756 0 0.0
.data 1992 1992 0 0.0
.text 583976 583976 0 0.0
lock k32w061+release (read/write) 723452 723452 0 0.0
.bss 70204 70204 0 0.0
.data 2000 2000 0 0.0
.text 645448 645448 0 0.0
linux chip-tool-no-interactive-ipv6only arm64 (read only) 9925180 9925244 64 0.0
(read/write) 676161 676161 0 0.0
.bss 42641 42641 0 0.0
.data 1152 1152 0 0.0
.data.rel.ro 615080 615080 0 0.0
.dynamic 528 528 0 0.0
.got 13472 13472 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 473916 473916 0 0.0
.text 7910292 7910356 64 0.0
thermostat-no-ble arm64 (read only) 2578364 2578428 64 0.0
(read/write) 180609 180609 0 0.0
.bss 87905 87905 0 0.0
.data 1704 1704 0 0.0
.data.rel.ro 82896 82896 0 0.0
.dynamic 528 528 0 0.0
.got 5080 5080 0 0.0
.init 24 24 0 0.0
.init_array 400 400 0 0.0
.rodata 164540 164540 0 0.0
.text 2174752 2174816 64 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439432 2439432 0 0.0
.bss 212180 212180 0 0.0
.data 5864 5864 0 0.0
.text 1402076 1402076 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1201883 1201883 0 0.0
bss 142862 142862 0 0.0
rodata 156108 156108 0 0.0
text 823984 823988 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1149639 1149639 0 0.0
bss 142098 142098 0 0.0
rodata 132592 132592 0 0.0
text 796032 796036 4 0.0
p6 all-clusters-app default (read/write) 2555776 2555776 0 0.0
.bss 147360 147360 0 0.0
.data 2776 2776 0 0.0
.text 1514040 1514040 0 0.0
all-clusters-minimal-app default (read/write) 2501624 2501640 16 0.0
.bss 146640 146640 0 0.0
.data 2776 2776 0 0.0
.text 1459888 1459904 16 0.0
light-app default (read/write) 2432384 2432384 0 0.0
.bss 138720 138720 0 0.0
.data 2592 2592 0 0.0
.text 1390648 1390648 0 0.0
lock-app default (read/write) 2453096 2453096 0 0.0
.bss 138544 138544 0 0.0
.data 2600 2600 0 0.0
.text 1411360 1411360 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 792080 792080 0 0.0
bss 71140 71140 0 0.0
noinit 40416 40416 0 0.0
text 561060 561064 4 0.0
lighting-app tlsr9518adk80d (read/write) 811784 811792 8 0.0
bss 71388 71388 0 0.0
noinit 40416 40416 0 0.0
text 577520 577522 2 0.0

@andy31415 andy31415 merged commit f36569f into project-chip:master Jun 22, 2022
@bzbarsky-apple bzbarsky-apple deleted the update-zap branch June 22, 2022 20:30
@bzbarsky-apple bzbarsky-apple mentioned this pull request Aug 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@msandstedt msandstedt msandstedt approved these changes

@mrjerryjohns mrjerryjohns mrjerryjohns approved these changes

@woody-apple woody-apple woody-apple approved these changes

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@hawk248 hawk248 Awaiting requested review from hawk248

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kghost kghost Awaiting requested review from kghost

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
app examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EmberAfAttributeMetadata size field is always 0 for external attributes
8 participants
@bzbarsky-apple @tcarmelveilleux @msandstedt @mrjerryjohns @woody-apple @jmartinez-silabs @jmeg-sfy @andy31415