-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Groups cluster: GroupInfo is now removed from the GroupTable whenever… #19221
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
rcasallas-silabs:remove_group
Jun 6, 2022
Merged
Groups cluster: GroupInfo is now removed from the GroupTable whenever… #19221
bzbarsky-apple
merged 1 commit into
project-chip:master
from
rcasallas-silabs:remove_group
Jun 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #19221: Size comparison from a8f12fa to 8e23f2e Increases (27 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, nrfconnect, p6, telink)
Decreases (3 builds for cc13x2_26x2)
Full report (28 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
… the last endpoint is removed from the group.
8e23f2e
to
275804d
Compare
tcarmelveilleux
approved these changes
Jun 6, 2022
PR #19221: Size comparison from 0ef4a9d to 275804d Increases (40 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
Decreases (3 builds for cc13x2_26x2)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GroupInfo is now removed from the GroupTable when the last endpoint is removed from the group.
Problem
Groups are not removed from GroupTable even after RemoveGroup command gets Success response.
Change overview
Testing
Groups and GroupKeyManagement cluster YAML tests executed successfully.