-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Darwin framework glue for all known data model things. #18220
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:darwin-include-all
May 10, 2022
Merged
Generate Darwin framework glue for all known data model things. #18220
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:darwin-include-all
May 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
234e460
to
620608b
Compare
PR #18220: Size comparison from c880e28 to 620608b Full report (27 builds for cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, p6, telink)
|
vivien-apple
approved these changes
May 9, 2022
PR #18220: Size comparison from c880e28 to 4f5e355 Increases above 0.2%:
Increases (2 builds for linux)
Decreases (1 build for linux)
Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
4f5e355
to
6ac6691
Compare
The Darwin codegen was only generating things for clusters/commands/attributes enabled in controller-clusters.zap. We should generate for everything instead.
6ac6691
to
36f31b2
Compare
PR #18220: Size comparison from afb7ccb to 36f31b2 Full report (34 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Fast-tracking platform-specific change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Darwin codegen was only generating things for
clusters/commands/attributes enabled in controller-clusters.zap. We
should generate for everything instead.
Problem
See above.
Change overview
Add a way to have ClustersHelper do everything, not just the things in controller-clusters.
Testing
Looked at generated code, ensured that the removals are all just reorderings due to the various ZAP not-sorting bugs.