[Diagnostic] Mark feature bit controlled attributes as optional since…

[yufengwangca]

… they are allowed to not be present.

Problem

What is being fixed? Examples:

• All feature bit controlled attributes should be marked as optional sine they are allowed to not be present at all, as long as the feature flag is not set.
• Fixes Fix network diagnostics cluster to actually follow the spec #14932

Change overview

Mark all diagnostic feature bit controlled attributes as optional per spec.

Testing

How was this tested? (at least one bullet point required)

• xml update only, regression covered by CI

[github-actions]

PR #15657: Size comparison from 4ba01f6 to d86eac5

Increases above 0.2%:

platform	target	config	section	4ba01f6	d86eac5	change	% change
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1038939	1075259	36320	3.5
			bss	125756	127608	1852	1.5
			rodata	135900	141804	5904	4.3
			text	700076	728436	28360	4.1

Increases (1 build for nrfconnect)

platform	target	config	section	4ba01f6	d86eac5	change	% change
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1038939	1075259	36320	3.5
			bss	125756	127608	1852	1.5
			rodata	135900	141804	5904	4.3
			text	700076	728436	28360	4.1

Full report (22 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)

platform	target	config	section	4ba01f6	d86eac5	change	% change
cyw30739	light	cyw930739m2evb_01	(read/write)	599582	599582	0	0.0
			.app_xip_area	504428	504428	0	0.0
			.bss	77844	77844	0	0.0
			.data	652	652	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	lock	cyw930739m2evb_01	(read/write)	557614	557614	0	0.0
			.app_xip_area	463996	463996	0	0.0
			.bss	76348	76348	0	0.0
			.data	616	616	0	0.0
			.rodata	0	0	0	0.0
			.text	0	0	0	0.0
	ota-requestor	cyw930739m2evb_01	(read/write)	578138	578138	0	0.0
			.app_xip_area	475088	475088	0	0.0
			.bss	85452	85452	0	0.0
			.data	560	560	0	0.0
			.rodata	0	0	0	0.0
			.text	112	112	0	0.0
efr32	lighting-app	BRD4161A	(read only)	916516	916516	0	0.0
			(read/write)	128608	128608	0	0.0
			.bss	126560	126560	0	0.0
			.data	2048	2048	0	0.0
			.text	916508	916508	0	0.0
		BRD4161A+rpc	(read only)	946604	946604	0	0.0
			(read/write)	145548	145548	0	0.0
			.bss	143336	143336	0	0.0
			.data	2212	2212	0	0.0
			.text	946596	946596	0	0.0
	lock-app	BRD4161A+wf200	(read only)	986436	986436	0	0.0
			(read/write)	120360	120360	0	0.0
			.bss	118436	118436	0	0.0
			.data	1924	1924	0	0.0
			.text	986428	986428	0	0.0
	window-app	BRD4161A	(read only)	850596	850596	0	0.0
			(read/write)	126844	126844	0	0.0
			.bss	124928	124928	0	0.0
			.data	1916	1916	0	0.0
			.text	850588	850588	0	0.0
esp32	all-clusters-app	c3devkit	(read only)	956574	956574	0	0.0
			(read/write)	1392986	1392986	0	0.0
			.dram0.bss	62592	62592	0	0.0
			.dram0.data	14228	14228	0	0.0
			.flash.rodata	197248	197248	0	0.0
			.flash.text	956574	956574	0	0.0
			.iram0.text	62016	62016	0	0.0
		m5stack	(read only)	1004711	1004711	0	0.0
			(read/write)	458264	458264	0	0.0
			.dram0.bss	68096	68096	0	0.0
			.dram0.data	34072	34072	0	0.0
			.flash.rodata	224600	224600	0	0.0
			.flash.text	999327	999327	0	0.0
			.iram0.text	122767	122767	0	0.0
k32w	light	k32w061+release	(read/write)	691904	691904	0	0.0
			.bss	77480	77480	0	0.0
			.data	1924	1924	0	0.0
			.text	606700	606700	0	0.0
	lock	k32w061+release	(read/write)	695176	695176	0	0.0
			.bss	77688	77688	0	0.0
			.data	1964	1964	0	0.0
			.text	609724	609724	0	0.0
linux	chip-tool-ipv6only	arm64	(read only)	8757484	8757484	0	0.0
			(read/write)	412049	412049	0	0.0
			.bss	58673	58673	0	0.0
			.data	1216	1216	0	0.0
			.data.rel.ro	296840	296840	0	0.0
			.dynamic	560	560	0	0.0
			.got	51512	51512	0	0.0
			.init	24	24	0	0.0
			.init_array	208	208	0	0.0
			.rodata	457028	457028	0	0.0
			.text	7435172	7435172	0	0.0
	thermostat-no-ble	arm64	(read only)	2163236	2163236	0	0.0
			(read/write)	148577	148577	0	0.0
			.bss	65265	65265	0	0.0
			.data	1056	1056	0	0.0
			.data.rel.ro	75080	75080	0	0.0
			.dynamic	560	560	0	0.0
			.got	4216	4216	0	0.0
			.init	24	24	0	0.0
			.init_array	352	352	0	0.0
			.rodata	132964	132964	0	0.0
			.text	1811968	1811968	0	0.0
mbed	lock-app	CY8CPROTO_062_4343W+release	(read only)	6224	6224	0	0.0
			(read/write)	2350140	2350140	0	0.0
			.bss	187092	187092	0	0.0
			.data	5776	5776	0	0.0
			.text	1312740	1312740	0	0.0
nrfconnect	all-clusters-app	nrf52840dk_nrf52840	(read/write)	1038939	1075259	36320	3.5
			bss	125756	127608	1852	1.5
			rodata	135900	141804	5904	4.3
			text	700076	728436	28360	4.1
p6	all-clusters-app	default	(read/write)	2488104	2488104	0	0.0
			.bss	118664	118664	0	0.0
			.data	2688	2688	0	0.0
			.text	1446368	1446368	0	0.0
	light-app	default	(read/write)	2395304	2395304	0	0.0
			.bss	112984	112984	0	0.0
			.data	2536	2536	0	0.0
			.text	1353568	1353568	0	0.0
	lock-app	default	(read/write)	2358880	2358880	0	0.0
			.bss	112728	112728	0	0.0
			.data	2496	2496	0	0.0
			.text	1317144	1317144	0	0.0
qpg	lighting-app	qpg6105+debug	(read only)	601200	601200	0	0.0
			(read/write)	146936	146936	0	0.0
			.bss	90904	90904	0	0.0
			.data	1124	1124	0	0.0
			.text	595880	595880	0	0.0
	lock-app	qpg6105+debug	(read only)	566964	566964	0	0.0
			(read/write)	146936	146936	0	0.0
			.bss	90912	90912	0	0.0
			.data	1076	1076	0	0.0
			.text	561644	561644	0	0.0
	persistent-storage-app	qpg6105+debug	(read only)	99536	99536	0	0.0
			(read/write)	146941	146941	0	0.0
			.bss	24001	24001	0	0.0
			.data	180	180	0	0.0
			.text	94216	94216	0	0.0
telink	lighting-app	tlsr9518adk80d	(read/write)	883126	883126	0	0.0
			bss	86336	86336	0	0.0
			noinit	37160	37160	0	0.0
			text	623982	623982	0	0.0

[andy31415]

Should this have side-effects that change .matter IDL file (chaning some things to optional)? Or changing other files than python files?

[bzbarsky-apple]

Should this have side-effects that change .matter IDL file (chaning some things to optional)?

IDL files are based on a particular ZAP config, so just reflect whether attributes are enabled or not, not whether they could be disabled.