Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added printing MRP intervals in resolver log output #15457

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Added printing MRP intervals in resolver log output #15457

merged 1 commit into from
Feb 23, 2022

Conversation

kkasperczyk-no
Copy link
Contributor

Problem

Resolver LogDetails() method used by chip-tool doesn't print MRP interval values

Change overview

Added printing MRP interval idle and active values.

Testing

Manually tested the logging change.

@boring-cyborg boring-cyborg bot added the lib label Feb 23, 2022
Damian-Nordic
Damian-Nordic approved these changes Feb 23, 2022
View reviewed changes
src/lib/dnssd/Resolver.h Show resolved Hide resolved
@kkasperczyk-no kkasperczyk-no force-pushed the chip_tool_discover_output branch from 5cff905 to d328390 Compare February 23, 2022 15:01
@github-actions
Copy link

github-actions bot commented Feb 23, 2022 •
edited
Loading

PR #15457: Size comparison from 63c06b6 to d328390

Increases (1 build for linux)
platform target config section 63c06b6 d328390 change % change
linux chip-tool-ipv6only arm64 (read only) 8821396 8821684 288 0.0
.rodata 456540 456652 112 0.0
.text 7446532 7446708 176 0.0
Full report (9 builds for cyw30739, linux, qpg, telink)
platform target config section 63c06b6 d328390 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598702 598702 0 0.0
.app_xip_area 503508 503508 0 0.0
.bss 77884 77884 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556738 556738 0 0.0
.app_xip_area 463088 463088 0 0.0
.bss 76380 76380 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577742 577742 0 0.0
.app_xip_area 474660 474660 0 0.0
.bss 85484 85484 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8821396 8821684 288 0.0
(read/write) 434705 434705 0 0.0
.bss 59265 59265 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 319024 319024 0 0.0
.dynamic 560 560 0 0.0
.got 51392 51392 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456540 456652 112 0.0
.text 7446532 7446708 176 0.0
thermostat-no-ble arm64 (read only) 2160220 2160220 0 0.0
(read/write) 149873 149873 0 0.0
.bss 66433 66433 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 75216 75216 0 0.0
.dynamic 560 560 0 0.0
.got 4208 4208 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132700 132700 0 0.0
.text 1808816 1808816 0 0.0
qpg lighting-app qpg6105+debug (read only) 600244 600244 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90936 0 0.0
.data 1124 1124 0 0.0
.text 594924 594924 0 0.0
lock-app qpg6105+debug (read only) 566012 566012 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90944 90944 0 0.0
.data 1076 1076 0 0.0
.text 560692 560692 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 881402 881402 0 0.0
bss 86372 86372 0 0.0
noinit 37160 37160 0 0.0
text 622704 622704 0 0.0

@kkasperczyk-no
Added printing MRP intervals in resolver log output
fd2ba43 
Resolver LogDetail() method used by chip-tool doesn't
print MRP interval values

Added printing MRP interval idle and active values
@kkasperczyk-no kkasperczyk-no force-pushed the chip_tool_discover_output branch from d328390 to fd2ba43 Compare February 23, 2022 15:29
@github-actions
Copy link

github-actions bot commented Feb 23, 2022 •
edited
Loading

PR #15457: Size comparison from 22dc4c6 to fd2ba43

Increases (1 build for linux)
platform target config section 22dc4c6 fd2ba43 change % change
linux chip-tool-ipv6only arm64 (read only) 8821412 8821700 288 0.0
.rodata 456540 456652 112 0.0
.text 7446548 7446724 176 0.0
Full report (34 builds for cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 22dc4c6 fd2ba43 change % change
cyw30739 light cyw930739m2evb_01 (read/write) 598714 598714 0 0.0
.app_xip_area 503520 503520 0 0.0
.bss 77884 77884 0 0.0
.data 652 652 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
lock cyw930739m2evb_01 (read/write) 556750 556750 0 0.0
.app_xip_area 463100 463100 0 0.0
.bss 76380 76380 0 0.0
.data 616 616 0 0.0
.rodata 0 0 0 0.0
.text 0 0 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 577754 577754 0 0.0
.app_xip_area 474672 474672 0 0.0
.bss 85484 85484 0 0.0
.data 560 560 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read only) 915708 915708 0 0.0
(read/write) 128648 128648 0 0.0
.bss 126600 126600 0 0.0
.data 2048 2048 0 0.0
.text 915700 915700 0 0.0
BRD4161A+rpc (read only) 944432 944432 0 0.0
(read/write) 145568 145568 0 0.0
.bss 143376 143376 0 0.0
.data 2188 2188 0 0.0
.text 944424 944424 0 0.0
window-app BRD4161A (read only) 850088 850088 0 0.0
(read/write) 126552 126552 0 0.0
.bss 124632 124632 0 0.0
.data 1916 1916 0 0.0
.text 850080 850080 0 0.0
esp32 all-clusters-app c3devkit (read only) 951282 951282 0 0.0
(read/write) 1399522 1399522 0 0.0
.dram0.bss 66672 66672 0 0.0
.dram0.data 14172 14172 0 0.0
.flash.rodata 199784 199784 0 0.0
.flash.text 951282 951282 0 0.0
.iram0.text 62056 62056 0 0.0
m5stack (read only) 1001243 1001243 0 0.0
(read/write) 464920 464920 0 0.0
.dram0.bss 71824 71824 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 226896 226896 0 0.0
.flash.text 995859 995859 0 0.0
.iram0.text 123399 123399 0 0.0
k32w light k32w061+release (read/write) 691396 691396 0 0.0
.bss 77520 77520 0 0.0
.data 1924 1924 0 0.0
.text 606152 606152 0 0.0
lock k32w061+release (read/write) 694204 694204 0 0.0
.bss 77720 77720 0 0.0
.data 1964 1964 0 0.0
.text 608720 608720 0 0.0
linux chip-tool-ipv6only arm64 (read only) 8821412 8821700 288 0.0
(read/write) 434705 434705 0 0.0
.bss 59265 59265 0 0.0
.data 1216 1216 0 0.0
.data.rel.ro 319024 319024 0 0.0
.dynamic 560 560 0 0.0
.got 51392 51392 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 456540 456652 112 0.0
.text 7446548 7446724 176 0.0
thermostat-no-ble arm64 (read only) 2160220 2160220 0 0.0
(read/write) 149873 149873 0 0.0
.bss 66433 66433 0 0.0
.data 1056 1056 0 0.0
.data.rel.ro 75216 75216 0 0.0
.dynamic 560 560 0 0.0
.got 4208 4208 0 0.0
.init 24 24 0 0.0
.init_array 352 352 0 0.0
.rodata 132700 132700 0 0.0
.text 1808816 1808816 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2439820 2439820 0 0.0
.bss 194612 194612 0 0.0
.data 5360 5360 0 0.0
.text 1402392 1402392 0 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2400940 2400940 0 0.0
.bss 188712 188712 0 0.0
.data 5656 5656 0 0.0
.text 1363512 1363512 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2336696 2336696 0 0.0
.bss 187608 187608 0 0.0
.data 5632 5632 0 0.0
.text 1299296 1299296 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139840 1139840 0 0.0
.bss 11796 11796 0 0.0
.data 4368 4368 0 0.0
.text 103224 103224 0 0.0
shell CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2327348 2327348 0 0.0
.bss 186244 186244 0 0.0
.data 5464 5464 0 0.0
.text 1289920 1289920 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 1022187 1022187 0 0.0
bss 122664 122664 0 0.0
rodata 120768 120768 0 0.0
text 699748 699748 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 991447 991447 0 0.0
bss 119852 119852 0 0.0
rodata 112292 112292 0 0.0
text 679628 679628 0 0.0
nrf52840dongle_nrf52840 (read/write) 1037183 1037183 0 0.0
bss 123868 123868 0 0.0
rodata 119616 119616 0 0.0
text 703796 703796 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 928830 928830 0 0.0
bss 119224 119224 0 0.0
rodata 114024 114024 0 0.0
text 614780 614780 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 951227 951227 0 0.0
bss 120876 120876 0 0.0
rodata 109608 109608 0 0.0
text 642144 642144 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 858702 858702 0 0.0
bss 117468 117468 0 0.0
rodata 102776 102776 0 0.0
text 557952 557952 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 527567 527567 0 0.0
bss 53632 53632 0 0.0
rodata 49948 49948 0 0.0
text 361016 361016 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 949371 949371 0 0.0
bss 120596 120596 0 0.0
rodata 108560 108560 0 0.0
text 641532 641532 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 945331 945331 0 0.0
bss 120600 120600 0 0.0
rodata 108256 108256 0 0.0
text 637772 637772 0 0.0
shell nrf52840dk_nrf52840 (read/write) 811667 811667 0 0.0
bss 113348 113348 0 0.0
rodata 79752 79752 0 0.0
text 540932 540932 0 0.0
p6 all-clusters-app default (read/write) 2490400 2490400 0 0.0
.bss 122400 122400 0 0.0
.data 2688 2688 0 0.0
.text 1448664 1448664 0 0.0
light-app default (read/write) 2394376 2394376 0 0.0
.bss 113648 113648 0 0.0
.data 2536 2536 0 0.0
.text 1352640 1352640 0 0.0
lock-app default (read/write) 2357952 2357952 0 0.0
.bss 113400 113400 0 0.0
.data 2496 2496 0 0.0
.text 1316216 1316216 0 0.0
qpg lighting-app qpg6105+debug (read only) 600268 600268 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90936 90936 0 0.0
.data 1124 1124 0 0.0
.text 594948 594948 0 0.0
lock-app qpg6105+debug (read only) 566036 566036 0 0.0
(read/write) 146936 146936 0 0.0
.bss 90944 90944 0 0.0
.data 1076 1076 0 0.0
.text 560716 560716 0 0.0
persistent-storage-app qpg6105+debug (read only) 99536 99536 0 0.0
(read/write) 146941 146941 0 0.0
.bss 24001 24001 0 0.0
.data 180 180 0 0.0
.text 94216 94216 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 881402 881402 0 0.0
bss 86372 86372 0 0.0
noinit 37160 37160 0 0.0
text 622708 622708 0 0.0

@andy31415 andy31415 merged commit 198a679 into project-chip:master Feb 23, 2022
Damian-Nordic pushed a commit to Damian-Nordic/connectedhomeip that referenced this pull request Mar 3, 2022
@kkasperczyk-no @Damian-Nordic
Added printing MRP intervals in resolver log output (project-chip#15457)
4927197 
Resolver LogDetail() method used by chip-tool doesn't
print MRP interval values

Added printing MRP interval idle and active values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@austinh0 austinh0 Awaiting requested review from austinh0

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@hawk248 hawk248 Awaiting requested review from hawk248

@holbrookt holbrookt Awaiting requested review from holbrookt

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@kghost kghost Awaiting requested review from kghost

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@lzgrablic02 lzgrablic02 Awaiting requested review from lzgrablic02

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
lib review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkasperczyk-no @andy31415 @Damian-Nordic